How to gather last 4 values of Swing indicator

[tkaboris]

Hi,

I want to work with lat four swing indicator values. How do i obtain them?

I created this series but its not right, when i print they dont come up as last 3 values that swing indicator laid on the chart...
Thank you

private Series<double> myDoubleSeries;
in dataloaded
myDoubleSeries = new Series<double>(this);
and in barupdate
myDoubleSeries[0] = High[Math.Max(0, Swing(5).SwingHighBar(0, 1, 10))];
myDoubleSeries[1] = High[Math.Max(0, Swing(5).SwingHighBar(0, 2, 10))];
myDoubleSeries[2] = High[Math.Max(0, Swing(5).SwingHighBar(0, 3, 10))];

Print("TmyDoubleSeries[0] " + myDoubleSeries[0]);
Print("TmyDoubleSeries[1] " + myDoubleSeries[1]);
Print("TmyDoubleSeries[2] " + myDoubleSeries[2]);

[NinjaTrader_Jesse]

Hello tkaboris,

The SwingHighBar method returns the bars ago for the instance you select, to have 4 swing values would require 4 lines of code where you increment the instance in SwingHighBar. You would just need to use double variables for that task. Here is an example of getting the price of 1 instance of the swing.

int swing1BarsAgo = Swing(5).SwingHighBar(0, 1, 10);
double firstSwingInstance = High[Math.Max(0,swing1BarsAgo)];

You could repeat this type of code a number of times if you wanted multiple variables for multiple swings. Keep in mind that using Math.Max will make it return non swing values if a swing is not found. You are just getting the High of 0 bars ago if the swing is not found. If you want to always have swing values you would have to check if the returned BarsAgo greater than 0 is being used to know if that specific swing instance was found instead of using the default of 0 bars ago like this sample code.

[tkaboris]

Thank you
You mean like this?

int swing1BarsAgo = Swing(5).SwingHighBar(0, 1, 10);
double firstSwingInstance = High[Math.Max(0,swing1BarsAgo)];

int swing2BarsAgo = Swing(5).SwingHighBar(0, 2, 10);
double secondSwingInstance = High[Math.Max(0,swing2BarsAgo)];

Print("firstSwingInstance"+firstSwingInstance);
Print("secondSwingInstance"+secondSwingInstance);

[NinjaTrader_Jesse]

Hello tkaboris,

Yes that would get either the swing values or the current bar high depending if swings are found in that lookback period.

[tkaboris]

Thank you can you please help with the syntax for checking the bars ago >0 my solution not working
if (SwingHighBar.barsAgo > 0){
int swing1BarsAgo = Swing(5).SwingHighBar(0, 1, 10);
double firstSwingInstance = High[Math.Max(0,swing1BarsAgo)];


int swing2BarsAgo = Swing(5).SwingHighBar(0, 2, 10);
double secondSwingInstance = High[Math.Max(0,swing2BarsAgo)];
}

[NinjaTrader_Jesse]

Hello tkaboris,

You would need to make a condition using the bars ago variable in that sample, that is named swing1BarsAgo.

The SwingHighBar method returns a bars ago, that is saved to a variable in the sample you are working with.

[tkaboris]

I am sorry its not working for me. There is no barsAgo method in swing1barsAgo

[NinjaTrader_Jesse]

Hello tkaboris,

Why are you putting a period after the variable name? The variable is already the bars ago as an int. You would compare that variable against the number of bars ago that you wanted.

[tkaboris]

I changed to this but still its not picking the second instance correctly. Second one should print 15066 value.
Here is my code. What am i doing wrong?

int swing1BarsAgo = Swing(5).SwingHighBar(0, 1, 10);
if(swing1BarsAgo > 0){
firstSwingInstance = High[Math.Max(0,swing1BarsAgo)];
}
int swing2BarsAgo = Swing(5).SwingHighBar(0, 2, 10);
if(swing2BarsAgo > 0){
secondSwingInstance = High[Math.Max(0,swing2BarsAgo)];
}
Print("firstSwingInstance"+firstSwingInstance);
Print("secondSwingInstance"+secondSwingInstance);

[NinjaTrader_Jesse]

Hello tkaboris,

You are only looking back 10 bars, try increasing the lookback period to a period that includes the full length of the swings you wanted.

[tkaboris]

ok thank you i think its what i needed now.

[tkaboris]

When defining Low, do i use Math.Max or Math.Min?

int swing1BarsAgoL = Swing(5).SwingLowBar(0, 1, 100);
if(swing1BarsAgoL > 0){
firstLowSwingInstance = Low[Math.Max(0,swing1BarsAgoL)];
}

[NinjaTrader_Jesse]

Hello tkaboris,

The purpose of the Math.max is to prevent -1 from being used as the bars ago. A bars ago needs to be at least 0. The swing methods return -1 if no swing is found which would generate an error. Math.Max returns 0 if the choice is between -1 and 0.