problem with two instructions

[BIOK.NT]

Hi everyone!

I have a problem with the these "If" instruction. I create these lines of code in OnBarUpdate with two diferent instructions.

if (Close[1] != Open[0]);
{
If(xxx)
{
Draw.Rectangle(xxxx, blue);
}
If(yyy)
{
Draw.Rectangle(xxxx.green):
}
If (xxx) == (yyy)return;


My problem is when loading the indicator it does not draw the two different rectangles on the chart. In the data output window it does print correctly everything I want it, but I not find the way to draw it correctly on the Chart.

If I erase one of the two variables it works perfectly but I only get it to draw correctly one type of the instruction. Any way to can make work the chart with the 2 instructions at same time.

Thanks in advance

[NinjaTrader_Gaby]

Hello BIOK.NT,

Thank you for your post.

In what way is it drawing the rectangles incorrectly compared to the data in the output window?

Are you using unique tag names to draw two different objects, or are you reusing the tag name to update an existing drawing object? To give a drawing object a unique tag name, please see the forum post linked below:

https://forum.ninjatrader.com/forum/ninjatrader-8/strategy-development/109349-strategy-buy-sell-signal-on-chart?p=838630#post838630

If you have already implemented prints to start debugging, can you share the results of your output?

The prints should include the time of the bar and should print all values from all variables and all hard coded values in all conditions that must evaluate as true for this action to be triggered. It is very important to include a text label for each value and for each comparison operator in the print to understand what is being compared in the condition sets.

I am happy to assist you with analyzing the output from the output window.

Run the script and when the output from the output window appears save this by right-clicking the output window and selecting Save As... -> give the output file a name and save -> then attach the output text file to your reply.

Below is a link to a forum post that demonstrates using informative prints to understand behavior and includes a link to a video recorded using the Strategy Builder to add prints.

https://ninjatrader.com/support/forum/forum/ninjatrader-7/strategy-development-aa/99209-date-conditions-not-working?p=791121#post791121

Please let me know if I may further assist with analyzing the output or if you need any assistance creating a print.

[BIOK.NT]

Hi NinjaTrader_Gaby

Thanks for your reply

I used a CurrentBar variable to make unique the tag of each rectangle. The problem I found when use the two instructions is the first of them draw a rectangle on each candle without logical, but on the output window only appear the correct rectangles. I attach the output file, please if you think any information is missing, let me know.

these are my 2 Draw.Rectangle line, maybe something is wrong.

{
Draw.Rectangle(this, "Tag1"+CurrentBar, true, 1, closePrice, -4, openPrice, Brushes.Green, Brushes.Green, 25);
}

{
Draw.Rectangle(this, "Tag2"+CurrentBar, true, 1, openPrice2, -4, closePrice2, Brushes.Blue, Brushes.Blue, 25);
}

Thanks on advance.

[NinjaTrader_Gaby]

Hello,

Please note negative barsAgo indexes are not supported. If you want the rectangle to end 4 bars ago, the endBarsAgo should be positive 4.

It looks like you are supplying similar arguments to both rectangles. Add prints for closePrice/openPrice and closePrice2/openPrice2. Are the rectangles being drawn on top of eachother? Checking the Drawing Objects window and see if there are two objects, and compare their anchor price/times are.

What are the conditions to draw the two different rectangles? It isn't clear from your print statements what these conditions are.

Is it possible you could share a reduced sample script for testing?

Thank you in advance.

[BIOK.NT]

Thanks for your help

I want to expand the rectangle to the future, for that I put in negative, is the only way I found.

Yes, one of the problems I find when put the two instruction, is just draw the first instruction, if I erase the return condition for the first rectangle, the second condition draws me well but in the first it draws all the candles without respecting the first instruction.

if (Close[1] != Open[0]);
{

if(Low[0] > High[1])Print(string.Format("{0}Gap Up| Max {1} | Min {2}", Time[0], High[1], Low[0]));
{

if (Low[0] <= High[1])return;

{

Draw.Rectangle(this, "Gap Alcista"+CurrentBar, true, 1, closePrice, -4, openPrice, Brushes.Green, Brushes.Green, 25);

}

}

if((High[0]) < Low[1])Print(string.Format("{0}Gap Down| Min {1} | Max {2}", Time[0], Low[1], High[0]));

{

if (High[0] >= Low[1])return;

{

Draw.Rectangle(this, "Gap Bajista"+CurrentBar, true, 1, openPrice2, -4, closePrice2, Brushes.Blue, Brushes.Blue, 25);

}

}

}

if (Close[1] == Open[0])return;

and the details of open and closePrice for Draw.Rectangle instruction are these

openPrice = Low[0];
closePrice = High[1];
openPrice2 = High[0];
closePrice2 = Low[1];

Thanks for your help!.

[NinjaTrader_Gaby]

Hello,

You can't extend a drawing object into the future, as the method can't draw on bars that doesn't exist yet. This is why negative barsAgo indexes are not supported.

If you would like, I can add your vote to a feature request for supporting extending drawing objects into the future.

Additionally,

I'm a little bit confused by your syntax:


if (Low[0] <= High[1])return;

{

Draw.Rectangle(this, "Gap Alcista"+CurrentBar, true, 1, closePrice, -4, openPrice, Brushes.Green, Brushes.Green, 25);

}

if (High[0] >= Low[1])return;

{

Draw.Rectangle(this, "Gap Bajista"+CurrentBar, true, 1, openPrice2, -4, closePrice2, Brushes.Blue, Brushes.Blue, 25);

}



Do you want these to return if Low[0] <= High[1] or High[0] >= Low[1] else use Draw.Rectangle?