User Preference for Time

[NinjaTrader_CodyB]

Hello,
With your code I am seeing everything run within the correct time filter. Can you provide a screenshot of the chart showing the drawobjects or entry orders outside of the time filter?

[ScottieDog]

Im glad it´s working your end, it was starting to drive me insane

It must be something (probably very simple) that is wrong inside my code as a whole, this is the first strategy I've ever done from scratch - I'm kind of shocked it compiled at all. lol.

Thanks for your help.

Screenshot attached, as you can see it is missing the time filter altogether and printing all trades without break, pretty messy obviously lol. Based on the settings in the screenshot, it shouldn´t have started until 9am.

I´m going to investigate further and see if I can find what is causing the issue.

[NinjaTrader_CodyB]

Hello,
Unfortunately the screenshot did not come through properly.
Can I have you try and upload it again?

[ScottieDog]

screenshot again. not sure what happened there.

[ScottieDog]

This is as simple as it gets, only 2 conditions, with the time filter on each.

Sorry for the hassle. I´m sure it is something silly.

It´s totally ignoring the time filter. Can you see why?

#region Using declarations
using System;
using System.ComponentModel;
using System.Diagnostics;
using System.Drawing;
using System.Drawing.Drawing2D;
using System.Xml.Serialization;
using NinjaTrader.Cbi;
using NinjaTrader.Data;
using NinjaTrader.Indicator;
using NinjaTrader.Gui.Chart;
using NinjaTrader.Strategy;
#endregion

// This namespace holds all strategies and is required. Do not change it.
namespace NinjaTrader.Strategy
{
    /// <summary>
    /// Enter the description of your strategy here
    /// </summary>
    [Description("Enter the description of your strategy here")]
    public class MyCustomStrategy : Strategy
    {
        #region Variables
        
        private int startTime = 090000; // Default setting for StartTime
        private int endTime = 100000; // Default setting for EndTime
		
        #endregion

        /// <summary>
        /// This method is used to configure the strategy and is called once before any strategy method is called.
        /// </summary>
        protected override void Initialize()
        {
            CalculateOnBarClose = true;
        }

        /// <summary>
        /// Called on each bar update event (incoming tick)
        /// </summary>
        protected override void OnBarUpdate()
        {
			if (GetCurrentAsk() > High[1]
                && ToTime(Time[0]) >= (startTime) && ToTime(Time[0]) < (endTime));   
            {
         //       ExitShort("", "");
                EnterLong(DefaultQuantity, "");
            }

       
            if (GetCurrentBid() < Low[1]
                && ToTime(Time[0]) >= (startTime) && ToTime(Time[0]) < (endTime));
           {
        //        ExitLong("", "");
                EnterShort(DefaultQuantity, "");
            }
		}

        #region Properties
        [Description("Trading Start")]
        [GridCategory("Parameters")]
        public int StartTime
        {
            get { return startTime; }
            set { startTime = Math.Max(1, value); }
        }

        [Description("Trading End")]
        [GridCategory("Parameters")]
        public int EndTime
        {
            get { return endTime; }
            set { endTime = Math.Max(1, value); }
        }
		
        #endregion
    }
}

[NinjaTrader_CodyB]

Hello,
It would appear that you have a semicolon entered after each of your if statement thus ending the condition without an action. I am seeing that the orders are entered in correctly with the semi colon removed.
If , else if, and else statements do not end with a semi colon. Please see the following link for the syntax when using these conditions: http://ninjatrader.com/support/helpG...g_commands.htm

[ScottieDog]

That´s sorted it! Thank-you.

Is there a way to check for this kind of error without doing it manually? I thought the error log at the bottom of the window would check such things like that, like when it says a ; is missing etc.

I´m glad thats sorted, that drove me insane the last 24 hours. Thanks again.

Can´t believe I missed that..

Hello,
It would appear that you have a semicolon entered after each of your if statement thus ending the condition without an action. I am seeing that the orders are entered in correctly with the semi colon removed.
If , else if, and else statements do not end with a semi colon. Please see the following link for the syntax when using these conditions: http://ninjatrader.com/support/helpG...g_commands.htm

[NinjaTrader_CodyB]

Hello,
This was a logic error not a syntax error really. if(Condition); is considered correct syntax the strategy processes this in a logically faction in the it checks the condition and then when the condition is true its told not to do anything. Logic errors do not come up as compile errors. The only way to resolve logic errors is through debugging.
I would highly recommend to review the following thread on debugging your NinjaScript code: http://ninjatrader.com/support/forum...ead.php?t=3418

[ScottieDog]

I´ve added a second time INT in the Variables. This is on a bool which when true exits all trades at a specific time.

Cant get it to compile though, i´m not sure why, i´m using the same code as before just with a different variable name.

private bool exitAll = true; // Bool to exit all trades
private int exitTime = 100000; // Default setting for ExitTime

 
// Condition set 2
			if (ExitAll == true
                && ToTime(Time[0]) == ToTime(exitTime))
			{
              // do stuff
            }

I´m getting a CS1502, and CS 1503 when I use the (exitTime)

If I use ToTime(10, 0, 0) then it compiles and works as it should. I thought I could just replace the (10,0,0) with a Variable which can be changed in the Preferences?

Can you point out my error please?




EDIT: When I use

ToTime(exitHour, exitMin, 0)

it also works, why won't it work using the exitTime I configured?

[NinjaTrader_CodyB]

Hello,
For this comparison to work you will not have ToTime(exitTime). The ToTime() method takes a datetime variable and has it return as an integer to compare to another integer. As exitTime is already an integer you do not need to have it within the ToTime() method. If exitTime was a datetime object then you would.

Please try the following instead:

if(ToTime(Time[0] == exitTime)
    //Do Something

]

[ScottieDog]

Thank-you! That sorted it.

Hello,
For this comparison to work you will not have ToTime(exitTime). The ToTime() method takes a datetime variable and has it return as an integer to compare to another integer. As exitTime is already an integer you do not need to have it within the ToTime() method. If exitTime was a datetime object then you would.

Please try the following instead:

if(ToTime(Time[0] == exitTime)
    //Do Something

]