Draw Arrows not working

[asimbhuta]

Hello,

OK, so I am kind of new to c#, but have enough 'coding' background to be able to grasp things pretty well.

I tried creating a simple indicator that draws arrows above and below bars that are overbought and oversold. However without the second and statements, the arrows would plot on every bar that was ob or os.

// Condition set 1
if (RSI(5, 1)[0] >= 80 &&
RSI(5, 1)[1] < 80)
{
DrawArrowDown("My down arrow" + CurrentBar, false, 0, High[0] + 2 * TickSize, Color.Red);
}


// Condition set 2
if (RSI(5, 1)[0] <= 20 &&
RSI(5, 1)[1] > 20)
{

DrawArrowUp("My up arrow" + CurrentBar, false, 0, Low[0] + -2 * TickSize, Color.Lime);
}

When I remove just the second condition for Condition Set 2 (the oversold case) and leaving Condition Set 1 as above, the indicator works fine, but with all conditions laid out, nothing is drawn on the chart.

// Condition set 2
if (RSI(5, 1)[0] <= 20)
{

DrawArrowUp("My up arrow" + CurrentBar, false, 0, Low[0] + -2 * TickSize, Color.Lime);
}

Would really appreciate some help on this

Asim

[ninZa]

The second condition of each condition set is a must. So why do you want to remove it?

Thanks
Pi

[asimbhuta]

I don't want to remove it. That's the point. It doesn't work with my full condition set at all But only works when I behin to remove the second condition on the second set.

[ninZa]

Have you checked this:

if (CurrentBar == 0) return;

Please put it at the very first line in OnBarUpdate.

Thanks,
Pi

[asimbhuta]

Ah, thanks it works now.

Didn't realise I needed such a line, as I was calculating/updating on bar close.

Asim

[ninZa]

Do you realize that you refer to the RSI value of 1 bar ago: RSI(5, 1)[1]
However, obviously at CurrentBar = 0 you have no bars before it to get the RSI value, which caused the error.

You should regularly monitor the Log tab (from the Control Center) to look for errors and hints

Cheers,
Pi

[asimbhuta]

lol my bad I thought the currentBar was the right most bar i.e. the latest bar, rather than the left most bar. (Different platforms allocate numbers differently, so got mixed up).

[ninZa]

Ya, that is the point.