Why parameter section is missing from result

[Benluk]

I cloned from a working indicator program to make changes. It works fine. But the result (see attached) does not have a Parameter section that allows me to change PERIOD. That forces me to change program to have different sets of values tested. What did I do wrong?

Below is a code segment:

public class MyWMACrossoverDot : Indicator
{
#region Variables
// Wizard generated variables
private int fastperiod = 6;
private int slowperiod = 30;
// User defined variables (add any user defined variables below)
#endregion

/// <summary>
/// This method is used to configure the indicator and is called once before any bar data is loaded.
/// </summary>
protected override void Initialize()
{
CalculateOnBarClose = false;
Overlay = true;
}

[NinjaTrader_CalH]

Benluk,

Thank you for your post.

Is this the full script or just part of it?

In the full script do you see a Properties region towards the bottom of the script?

[Benluk]

I add the region Properties. When I compile, I have a warning message:

Your indicator likely holds one or more recursive properties which could cause Ninja Trader to crash: fastperiod slowperiod.

// This namespace holds all indicators and is required. Do not change it.
namespace NinjaTrader.Indicator
{
/// <summary>
///
/// </summary>
[Description("")]
public class MyWMACrossoverDot : Indicator
{
#region Variables
// Wizard generated variables
private int fastperiod = 6;
private int slowperiod = 30;
// User defined variables (add any user defined variables below)
#endregion

/// <summary>
/// This method is used to configure the indicator and is called once before any bar data is loaded.
/// </summary>
protected override void Initialize()
{
CalculateOnBarClose = false;
Overlay = true;
}

/// <summary>
/// Called on each bar update event (incoming tick)
/// </summary>
protected override void OnBarUpdate()
{
if (CurrentBar < 2) return;

if (WMA(Close, fastperiod)[0] > WMA(Close, slowperiod)[0] && WMA(Close, fastperiod)[1] < WMA(Close, slowperiod)[1])
{DrawArrowUp("tag"+CurrentBar, true, Time[0], Low[0]-(4*TickSize), Color.Cyan);}
else
if (WMA(Close, fastperiod)[0] < WMA(Close, slowperiod)[0] && WMA(Close, fastperiod)[1] > WMA(Close, slowperiod)[1])
{DrawArrowDown("tag"+CurrentBar, true, Time[0], High[0]+(4*TickSize), Color.Red);}
else
{RemoveDrawObject("tag"+CurrentBar);}

}

#region Properties

[Description("Number of Period")]
[GridCategory("Parameters")]
public int fastperiod
{
get { return fastperiod; }
set { fastperiod = Math.Max(1, value); }
}

[Description("Number of Period")]
[GridCategory("Parameters")]
public int slowperiod
{
get { return slowperiod; }
set { slowperiod = Math.Max(1, value); }
}
#endregion

}
}

[koganam]

I add the region Properties. When I compile, I have a warning message:

Your indicator likely holds one or more recursive properties which could cause Ninja Trader to crash: fastperiod slowperiod.

// This namespace holds all indicators and is required. Do not change it.
namespace NinjaTrader.Indicator
{
/// <summary>
///
/// </summary>
[Description("")]
public class MyWMACrossoverDot : Indicator
{
#region Variables
// Wizard generated variables
private int fastperiod = 6;
private int slowperiod = 30;
// User defined variables (add any user defined variables below)
#endregion

/// <summary>
/// This method is used to configure the indicator and is called once before any bar data is loaded.
/// </summary>
protected override void Initialize()
{
CalculateOnBarClose = false;
Overlay = true;
}

/// <summary>
/// Called on each bar update event (incoming tick)
/// </summary>
protected override void OnBarUpdate()
{
if (CurrentBar < 2) return;

if (WMA(Close, fastperiod)[0] > WMA(Close, slowperiod)[0] && WMA(Close, fastperiod)[1] < WMA(Close, slowperiod)[1])
{DrawArrowUp("tag"+CurrentBar, true, Time[0], Low[0]-(4*TickSize), Color.Cyan);}
else
if (WMA(Close, fastperiod)[0] < WMA(Close, slowperiod)[0] && WMA(Close, fastperiod)[1] > WMA(Close, slowperiod)[1])
{DrawArrowDown("tag"+CurrentBar, true, Time[0], High[0]+(4*TickSize), Color.Red);}
else
{RemoveDrawObject("tag"+CurrentBar);}

}

#region Properties

[Description("Number of Period")]
[GridCategory("Parameters")]
public int Fastperiod
{
get { return fastperiod; }
set { fastperiod = Math.Max(1, value); }
}

[Description("Number of Period")]
[GridCategory("Parameters")]
public int Slowperiod
{
get { return slowperiod; }
set { slowperiod = Math.Max(1, value); }
}
#endregion

}
}

In each case, your public variable is defined exactly as its backing store. That is a recursive loop that will cause what is in effect an infinite loop of object creation until the computer runs out of memory and crashes.

There are many ways that resolve the issue. What I have modified in red is the method most often used, and seems to be the Microsoft sanctified method. (That is not the method that I use, as it is not informative enough for my coding style.)

[Benluk]

Although I do not understand, it works. Thank you.

Could you help me to understand the following coding please? Are the value 1 correctly code for this purpose?

Within region Properties...

set { fastperiod = Math.Max(1, value); }
set { slowperiod = Math.Max(1, value); }

[koganam]

Although I do not understand, it works. Thank you.

Could you help me to understand the following coding please? Are the value 1 correctly code for this purpose?

Within region Properties...

set { fastperiod = Math.Max(1, value); }
set { slowperiod = Math.Max(1, value); }

That just says that the variables' value is the maximum value between 1 and the value supplied through the parameter. In effect, it means that the minimum value that the parameter will supply to the class is 1, as, if a value less than 1 is supplied, then the maximum value between that supplied value and 1 would be 1.