Is this the correct co ordinate for the low of the current bar?

[Mindset]

I am trying to get an indicator to plot text at the low of the current bar
I have used the following code successfully in NT7 but want to check if something is different in NT8?

    int lowplace     =  (int)(ChartPanel.Y + chartScale.Height) - ((int) ((((Low.GetValueAt(ChartBars.ToIndex ))  - chartScale.MinValue) / chartScale.MaxMinusMin) * chartScale.Height)) - 1;

I ask because this code works on one machine with NT8 but not 2 others??

So first I just want to check that the code is basically correct.

[s.kinra]

Hello Mindset,
If your requirement is only to place text at current bar's low, it can be done easily with Low[0]. I don't know why exactly you're doing this calculation. You can use it in Draw.Text(). Hope it helps!

[NinjaTrader_ChelseaB]

Hello Mindset,

Draw.Text() would be the easiest way to draw text at the Low[0] of the of the bar.

https://ninjatrader.com/support/helpGuides/nt8/draw_text.htm

If you are wanting to custom render the text, you can use ChartControl.GetXByBarIndex() to get the x value of a bar, and ChartScale.GetYByValue() to get a y from a price.

https://ninjatrader.com/support/helpGuides/nt8/getxbybarindex.htm

https://ninjatrader.com/support/helpGuides/nt8/getybyvalue.htm

https://ninjatrader.com/support/helpGuides/nt8/onrender.htm

[Mindset]

I think the best way is to show you what I am up against.
As you can see in the first instance - rectangle and text is perfectly placed.
In the second it isn't and it doesn't scale when you move the chart axis.
Same code (as in the first post) different machines.

[s.kinra]

Hello Mindset,
You're using rectangle & text so you can definitely use Draw.Rectangle() & Draw.Text() & use Low[0] for current bar low. I can see there is a difference in font size in both machines, you can check it by right click on chart -> properties -> font. When you use Draw.Text() be sure to define the font in it so the font size is not altered & you don't see any discrepancies. I am sure with these built-in functions your task can be achieved & you won't get any scaling issues. Just in case you still face issues do let me know.

[NinjaTrader_ChelseaB]

Hello Mindset,

Is the rectangle drawn with Draw.Rectangle?

Is the indicator applied to the same Scale Justification in the indicator parameters?

If the object is drawn with Draw.Rectangle() using the Low[0] of the bar, I would expect the draw method object to scroll with the chart.

[Mindset]

HI Chelsea

Its currently drawn with RenderTarget(rect,AreaBrushDx,TempWidth);
it actually uses Low[1].
I should add I paid money to have this converted as this was an original indicator I posted in NT7 back in 2011.
and it works fine on 1 machine and it works fine for the guy who converted it - so it's a weird one. Is it code or is it platform or something else.

Currently it's useless and that is frustrating.
I understand a little about code but not really enough ( Im a cut and paste trial and error guy) - but in the past I have always got there.
Just not this time.
Support s going to connect to machine and have a look tomorrow so maybe they will see something.

[NinjaTrader_ChelseaB]

Hello Mindset,

If this is in OnRender() the behavior is different.

You should be using Bars.GetLow() or TriggerCustomEvent to use bar data in a non-data-driven method.

https://ninjatrader.com/support/helpGuides/nt8/triggercustomevent.htm

https://ninjatrader.com/support/helpGuides/nt8/getlow.htm

If you want the object to scroll with the chart, you have to write custom logic to do that. It won't do it by itself.

Below is a link to an example.

https://ninjatrader.com/support/forum/forum/ninjatrader-8/indicator-development/97796-how-to-anchor-grid-control-to-chart?p=786906#post786906

[Mindset]

Ok well that took a complete rewrite of the code but at least it works now. :-)
Get YBy Value was an important contributor plus also a little bit of out of the box thinking.
(Getting the rectangle to sit correctly took forever and doesn't appear to be something you can do using Draw.
Rectangle as that is based around the centre of the bar.

[Mindset]

Lol this isn't simple this indicator of mine now completely screws up Advanced Risk Reward indicator.
My best guess is the ONRender function - is there something I should do?
I have already put in
base(OnRender(chartControl,chartScale);


Edit here's a video - is it me or is this indicator not behaving correctly? It doesn't seem to retain the user input lines.
if you press Hide/Show the lines go to their original settings ( which are always wrong because they are approximations of mouse clicks ( I don't know why that should be either?) not the ones where say you moved them too.
I made a video but apparenlty you can't upload those.
Heres a quick couple of screenshots instead

[NinjaTrader_Jim]

Hello Mindset,

This is Jim responding on behalf of Chelsea who is out of the office at this time.

I would suggest continuing to work on your indicator outside the context of using Advanced Risk Reward. If you are able to identify something specific that affects Advanced Risk Reward, I would like to take a look. I converted the indicator from the NinjaTrader 7 version so functionality should match there, but if there is an existing issue that is easy to understand and correct I would like to have a look. I suggest commenting out sections of code to get to specific modifications that are affecting this indicator.

Please email me at platformsupport [at] ninjatrader [dot] com with a small test script that can reproduce issues with Advanced Risk Reward. Please include the text "Attn Jim 2813839 Advanced Risk Reward." I only converted the indicator and by no means an expert of its functionality, so please be explicit with steps needed to reproduce issues.

We look forward to assisting.

[Mindset]

thanks Jim
However the behaviour I show in the snapshots is just your Indicator on it's own - it doesnt seem to retain the new lines if you move them and then hide/show? Or is it my platform?
With regards to my own indicator - its not worth the time and effort to work it out - I am not a coder so these things take forever. Its just a shame as I really like your indicator!
I will give it a go - as you say - commenting out sections to see if/where the problem is.
Just wanted to give you a heads up about the issue
Edit - what a dumbass I am! There is a button called save changes and guess what that does doh!