Rewriting Indicator EMA to use Ninjascript Base but not working

[KhaosTrader]

Hi,

I want to write an add-on that can be used like an indicator from a strategy. I believe i cant pass the Indicator object to my classes - where my classes use indicators. So that means that I must rewrite the indicators that my classes use to use Ninjascript base.

I use the EMA indicator in my classes, so i decided to rewrite that, and came up with the following code below, but it doesnt seem to work.. what am I doing incorrectly..

Thank you in advance.

namespace Khaos_Elements
{
	public class Khaos_EMA
	{
		
		private NinjaScriptBase NinjaScriptBase;
		
		private int Period;
		
		private double constant1;
		private double constant2;
		
		public Series<double> Value { get; private set; }
		
		
		
		public Khaos_EMA(NinjaScriptBase NinjaScriptBase)
		{
			this.NinjaScriptBase = NinjaScriptBase;
			this.Period = Period;
			constant1 = 2.0 / (1 + Period);
			constant2 = 1 - (2.0 / (1 + Period));
			
			 Value = new Series<double>(NinjaScriptBase);
		}
		
		
		public Series<double> TickTock(int Period)
		{
			
			
			try
			{
			Value[0] = (NinjaScriptBase.CurrentBar == 0 ? NinjaScriptBase.Input[0] : NinjaScriptBase.Input[0] * constant1 + constant2 * Value[1]);
			
			return Value;
				
			}
			
				catch (Exception e)
			{
				NinjaScriptBase.Log ("Cought Error Khaos Moving Average = " + e.ToString(), NinjaTrader.Cbi.LogLevel.Warning);
				NinjaScriptBase.Print(NinjaScriptBase.Time[0] +  " " + e.ToString());
				return Value;
			}				
		}
	}
}

[NinjaTrader_JessicaP]

Hello KhaosTrader, and thank you for your question. The attached add-on compiles properly for me. If you could let us know which errors you are receiving when you try to use it during runtime, or I could answer any questions about the operation of NinjaTrader add-ons, please let us know.

[KhaosTrader]

Hi,

There is some sort of error, its not calculating properly, One thing I noted was that there was one error which i fixed, but still it does not yield the proper result when calling TickTock

Here is the latest code below.. Thank you for your patience with me on this, I really cant figure why its not calculating properly.

	public class Khaos_EMA
	{
		
		private NinjaScriptBase NinjaScriptBase;
		
		private int Period;
		
		private double constant1;
		private double constant2;
		
		public Series<double> Value { get; private set; }
		
		
		
		public Khaos_EMA(NinjaScriptBase NinjaScriptBase)
		{
			this.NinjaScriptBase = NinjaScriptBase;

			
			 Value = new Series<double>(NinjaScriptBase);
		}
		
		
		public Series<double> TickTock(int Period)
		{
			
			
			try
			{
			this.Period = Period;
			constant1 = 2.0 / (1 + Period);
			constant2 = 1 - (2.0 / (1 + Period));
			
			Value[0] = (NinjaScriptBase.CurrentBar == 0 ? NinjaScriptBase.Input[0] : NinjaScriptBase.Input[0] * constant1 + constant2 * Value[1]);
				
			return Value;
				
			}
			
				catch (Exception e)
			{
				NinjaScriptBase.Log ("Cought Error Khaos Moving Average = " + e.ToString(), NinjaTrader.Cbi.LogLevel.Warning);
				NinjaScriptBase.Print(NinjaScriptBase.Time[0] +  " " + e.ToString());
				return Value;
			}				
		}
	}
}

[KhaosTrader]

I did some more testing and it seems like the above function does indeed work, thank you for your assistance on this..

[NinjaTrader_JessicaP]

I am glad you were able to determine what happened. I am pasting my original unedited reply for the benefit of other users. Please let us know if there are any other ways we can help.

I am happy to help set up a test which will let us know exactly what is happening and why. Before we can do so, we must ensure your code is being executed at all. If you have not already, please follow these instructions to load your code into the Visual Studio editor, so we may have breakpoints available.

http://ninjatrader.com/support/helpGuides/nt8/en-us/?visual_studio_debugging.htm

Once we have done so, please add a breakpoint to your TickTock method on the line which sets this.Period, to ensure this section is being executed. Please also add a breakpoint to your constructor where it sets NinjaScriptBase .

If you are unable to reach either debug point, for the time being, please use the add-on namespace rather than your own namespace. I would recommend copying your code body into a new add-on you create through the NinjaScript editor, with add-on template code, to change namespaces. If you are still unable to reach an execution point, you will need to experiment further before I can assist through the forums beyond answering basic questions about Ninja.

Once you are able to ensure you are reaching your code, please give us a complete scenario we can use to test with. For example, to test the line where Value[0] is set, we would need to pick a known Input[0], constant1, constant2, and Value[1] value. It is preferable to set these both directly and at the highest level possible, to determine if we need to write more tests. In other words, if you know of a circumstance that would set Input[0] for us, we should specify that circumstance as well. Finally, we need an expected value for Value[0].

With this information, we should definitely be able to get your add-on working properly. I look forward to assisting further.