Announcement

Collapse
No announcement yet.

Partner 728x90

Collapse

Strategy Entering Additional Trades

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

    Strategy Entering Additional Trades

    Hello NinjaTrader Experts.

    I have a strategy that is working fine in Back Testing but creates additional unintended trades when running live. Please see below the simple code:
    ================================
    if (Closes[0][0] < SMA(10)[0]) )
    {

    EnterShort(2, "S1");

    entryPriceS1=Close[0];

    return;
    }

    if (Position.MarketPosition == MarketPosition.Short)
    {

    if( ((entryPriceS1-Closes[0][0]) >10))
    {
    ExitShort(1,"XS1", "S1");
    }


    if (Highs[0][0] > (SMA(10)[1]))
    {
    ExitShort("XS2", "S1");
    }



    if((Closes[0][0]) > (SMA(10)[0]-2) )
    {
    ExitShort("XS3", "S1");
    }

    }

    Issue. It closes the Short S1 trades but also enters LONG trades like XS1, XS2, XS3. And, it is random.

    Any help is greatly appreciated.

    Thanks!​​
    Last edited by NRITV; 03-04-2025, 09:50 AM.

    #2
    Hello,

    Thank you for your post.

    To understand why the script is behaving as it is, such as placing orders or not placing orders or drawing objects when expected, it is necessary to add prints to the script that print the values used for the logic of the script to understand how the script is evaluating.

    In the strategy add prints (outside of any conditions) that print the date time of the bar and all values compared in every condition that places an order.

    The prints should include the time of the bar and should print all values from all variables and all hard coded values in all conditions that must evaluate as true for this action to be triggered. It is very important to include a text label for each value and for each comparison operator in the print to understand what is being compared in the condition sets.

    The debugging print output should clearly show what the condition is, what time the conditions are being compared, all values being compared, and how they are being compared.


    Prints will appear in the NinjaScript Output window (New > NinjaScript Output window).


    Further, enable TraceOrders which will let us know if any orders are being ignored and not being submitted when the condition to place the orders is evaluating as true.

    After enabling TraceOrders remove the instance of the strategy from the Configured list in the Strategies window and add a new instance of the strategy from the Available list.


    I am happy to assist you with analyzing the output from the output window.


    Run or backtest the script and when the output from the output window appears save this by right-clicking the output window and selecting Save As... -> give the output file a name and save -> then attach the output text file to your reply.


    Below is a link to a support article that demonstrates using informative prints to understand behavior and includes a link to a video recorded using the Strategy Builder to add prints.

    https://support.ninjatrader.com/s/ar...nd-TraceOrders

    Comment


      #3
      Thank YOU Gaby V. for the detailed solution. I am in the process of trying the prints.

      A quick favor. What other function can I use to exit a Short trade other than the below:

      {
      ExitShort(1,"XS1", "S1");
      }

      Thanks Again!​

      Comment


        #4
        Hello,

        You can find all managed approach order methods, including all methods to exit a short trade, at the link below:



        Calling EnterLong() when in a short trade will automatically reverse your position as well.

        Comment

        Latest Posts

        Collapse

        Topics Statistics Last Post
        Started by NullPointStrategies, Today, 05:17 AM
        0 responses
        30 views
        0 likes
        Last Post NullPointStrategies  
        Started by argusthome, 03-08-2026, 10:06 AM
        0 responses
        124 views
        0 likes
        Last Post argusthome  
        Started by NabilKhattabi, 03-06-2026, 11:18 AM
        0 responses
        64 views
        0 likes
        Last Post NabilKhattabi  
        Started by Deep42, 03-06-2026, 12:28 AM
        0 responses
        41 views
        0 likes
        Last Post Deep42
        by Deep42
         
        Started by TheRealMorford, 03-05-2026, 06:15 PM
        0 responses
        46 views
        0 likes
        Last Post TheRealMorford  
        Working...
        X