Adjusting Order Quantity of Stops/Take Profits After ScaleIn

[Draikon7276]

Morning, I've tried everything I know to try and I can't get this to work. My strategy scales in if the price goes against it. It then needs to update the order quantity for the stop loss and take profit (the take profit price is also changed). I've been doing this by cancelling the existing exit orders and adding new ones. Everything seems to work fine, but when it scales in the order quantity of the new stop and take profit are 1. I checked to make sure Order.Quantity was correctly 2 and it was, so I explicitly set the order quantity of the new orders to 2 and that also failed. I thought that perhaps it was the ATM strategy order quantity getting in the way so I set that to 2 and that also didn't help. Here's the problematic code: what am I doing wrong?

protected override void OnExecutionUpdate(Execution execution, string executionId, double price, int quantity, MarketPosition marketPosition, string orderId, DateTime time)
{
// Phase 1: Cancel Existing Orders
if (execution.Order == longScaleInOrder)
{
Print($"Scale-in executed for long position at {price}. Initiating cancellation phase.");

// Cancel any existing long exit orders
if (longLimitOrder != null)
{
CancelOrder(longLimitOrder);
longLimitOrder = null;
Print("Cancelled existing long limit order.");
}
if (longStopOrder != null)
{
CancelOrder(longStopOrder);
longStopOrder = null;
Print("Cancelled existing long stop order.");
}

// Set a flag indicating new orders need to be placed
isLongOrdersPending = true;
}
else if (execution.Order == shortScaleInOrder)
{
Print($"Scale-in executed for short position at {price}. Initiating cancellation phase.");

// Cancel any existing short exit orders
if (shortLimitOrder != null)
{
CancelOrder(shortLimitOrder);
shortLimitOrder = null;
Print("Cancelled existing short limit order.");
}
if (shortStopOrder != null)
{
CancelOrder(shortStopOrder);
shortStopOrder = null;
Print("Cancelled existing short stop order.");
}

// Set a flag indicating new orders need to be placed
isShortOrdersPending = true;
}

// Phase 2: Place New Orders
if (isLongOrdersPending)
{
Print($"Placing new long exit orders for position size: {Position.Quantity}");

longLimitOrder = ExitLongLimit(0, true, Position.Quantity, originalEntryPrice, "NewExitLongLimit", "ScaleInLong");
Print($"New long limit order placed at {originalEntryPrice} with quantity {Position.Quantity}");

longStopOrder = ExitLongStopMarket(0, true, Position.Quantity, stopPrice, "NewExitLongStop", "ScaleInLong");
Print($"New long stop order placed at {stopPrice} with quantity {Position.Quantity}");

isLongOrdersPending = false; // Reset the flag
}
else if (isShortOrdersPending)
{
Print($"Placing new short exit orders for position size: {Position.Quantity}");

shortLimitOrder = ExitShortLimit(0, true, Position.Quantity, originalEntryPrice, "NewExitShortLimit", "ScaleInShort");
Print($"New short limit order placed at {originalEntryPrice} with quantity {Position.Quantity}");

shortStopOrder = ExitShortStopMarket(0, true, Position.Quantity, stopPrice, "NewExitShortStop", "ScaleInShort");
Print($"New short stop order placed at {stopPrice} with quantity {Position.Quantity}");

isShortOrdersPending = false; // Reset the flag
}
// Original entrys and stop and take profit placement
if (execution.Name == "BullishGapEntry")
{
// Set stop loss and profit target for long position with isLiveUntilCancelled
longStopOrder = ExitLongStopMarket(0, true, quantity, stopPrice, "ExitLongStop", "BullishGapEntry");
longLimitOrder = ExitLongLimit(0, true, quantity, targetPrice, "ExitLongLimit", "BullishGapEntry");
longScaleInOrder = EnterLongLimit(0, true, 1, High[2], "ScaleInLong");
Print($"longScaleInOrder: {scaleInPriceLong}");

}
else if (execution.Name == "BearishGapEntry")
{
// Set stop loss and profit target for short position with isLiveUntilCancelled
shortStopOrder = ExitShortStopMarket(0, true, quantity, stopPrice, "ExitShortStop", "BearishGapEntry");
shortLimitOrder = ExitShortLimit(0, true, quantity, targetPrice, "ExitShortLimit", "BearishGapEntry");
Print($" ExitShortLimit: {targetPrice}, ExitShortLimit");
shortScaleInOrder = EnterShortLimit(0, true, 1, Low[2], "ScaleInShort");
Print($" shortScaleInOrder price: {scaleInPriceShort}");
}
}

[Draikon7276]

Jk, I figured it out. I used ChangeOrder instead and that fixed it.

[NinjaTrader_ChelseaB]

Hello Draikon7276,

Assign orders to variables from the order parameter of OnOrderUpdate() only.

From the Desktop SDK:
"OnOrderUpdate() will run inside of order methods such as EnterLong() or SubmitOrderUnmanaged(), therefore attempting to assign an order object outside of OnOrderUpdate() may not return as soon as expected. If your strategy is dependent on tracking the order object from the very first update, you should try to match your order objects by the order.Name (signal name) from during the OnOrderUpdate() as the order is first updated."

https://developer.ninjatrader.com/docs/desktop/onorderupdate

Then to change the order price or quantity, supply the variable (assigned from OnOrderUpdate()) to the ChangeOrder() method.

https://developer.ninjatrader.com/docs/desktop/changeorder

Below is a link to examples that modify orders.

https://support.ninjatrader.com/s/article/Profit-Chase-Stop-Trail