Help with strategy

[BakerBro1]

Hi all,
I am trying to write a strategy that monitors my unrealized P/L and closes out all positions when it reaches a certain threshold.

For example, if I set the profit threshold to 10 and the loss threshold to 5, when my unrealized P/L hits +$10 it closes all positions and similarly, if the unrealized P/L reaches -$5, it will close all positions.


Here is the code I have:

It compiles correctly and I can load it on the chart, but it never closes when the profit or loss threshold is hit in the unrealized P/L...


region Using declarations

using System;

using NinjaTrader.Cbi;

using NinjaTrader.NinjaScript;

#endregion




namespace NinjaTrader.NinjaScript.Strategies

{

public class AutoCloseOnPL : Strategy

{

// User-defined parameters for profit and loss thresholds

public double ProfitThreshold { get; set; } = 5.0; // Default to 5

public double LossThreshold { get; set; } = 10.0; // Default to 10




protected override void OnStateChange()

{

if (State == State.SetDefaults)

{

Description = "Automatically closes all positions when P/L threshold is met.";

Name = "AutoCloseOnPL";

Calculate = Calculate.OnEachTick;

}

}




protected override void OnBarUpdate()

{

// Check if there's an open position

if (Position.MarketPosition == MarketPosition.Flat)

return;




// Get the current unrealized profit/loss

double unrealizedPL = Position.GetUnrealizedProfitLoss(PerformanceUnit.C urrency, Close[0]);




// Print unrealized P/L for debugging purposes

Print("Current Unrealized P/L: " + unrealizedPL);




// Check if unrealized P/L meets the threshold criteria for auto-closing positions

if (unrealizedPL >= ProfitThreshold || unrealizedPL <= -LossThreshold)

{

Print("P/L threshold met. Closing all positions.");

CloseAllPositions();

}

}




private void CloseAllPositions()

{

// Close any active positions based on their type

if (Position.MarketPosition == MarketPosition.Long)

{

Print("Closing long position.");

ExitLong();

}

else if (Position.MarketPosition == MarketPosition.Short)

{

Print("Closing short position.");

ExitShort();

}

}

}

}

Any help would be appreciated!

[NinjaTrader_Gaby]

Hello BakerBro1,

Thank you for your post.

We have sample scripts demonstrating how to implement a daily loss limit, similar logic can be used to also implement a profit limit:

https://forum.ninjatrader.com/forum/ninjatrader-8/strategy-development/93881-daily-loss-limit-examples#post93881

I recommend studying DailyLossLimitExample to get an idea of how the logic works.


If your script still isn't working as expected, I recommend debugging the script using Prints and TraceOrders.

To understand why the script is behaving as it is, such as placing orders or not placing orders when expected, it is necessary to add prints to the script that print the values used for the logic of the script to understand how the script is evaluating.

In the strategy add prints (outside of any conditions) that print the date time of the bar and all values compared in every condition that places an order.

The prints should include the time of the bar and should print all values from all variables and all hard coded values in all conditions that must evaluate as true for this action to be triggered. It is very important to include a text label for each value and for each comparison operator in the print to understand what is being compared in the condition sets.

The debugging print output should clearly show what the condition is, what time the conditions are being compared, all values being compared, and how they are being compared.

Prints will appear in the NinjaScript Output window (New > NinjaScript Output window).

Further, enable TraceOrders which will let us know if any orders are being ignored and not being submitted when the condition to place the orders is evaluating as true.

After enabling TraceOrders remove the instance of the strategy from the Configured list in the Strategies window and add a new instance of the strategy from the Available list.

I am happy to assist you with analyzing the output from the output window.

Run or backtest the script and when the output from the output window appears save this by right-clicking the output window and selecting Save As... -> give the output file a name and save -> then attach the output text file to your reply.

Below is a link to a support article that demonstrates using informative prints to understand behavior and includes a link to a video recorded using the Strategy Builder to add prints.

https://support.ninjatrader.com/s/ar...nd-TraceOrders