Strategy level stoploss

[RaddiFX]

I'm trying to create a strategy level stoploss that checks the strategies net profit and closes the strategy if the net profit is greater than -5% of the account. The issue I'm running into is that it's only checking realized profit and never unrealized, so if a trade it's currently in goes over that limit it won't close until it's too late.

if ((Position.GetUnrealizedProfitLoss(PerformanceUnit.Currency, Close[0]) + SystemPerformance.AllTrades.TradesPerformance.NetProfit) < accountSize * -.1) {
                if (Position.MarketPosition != MarketPosition.Long)
                    ExitLong("Exit Long - MaxLoss", "");
                else if (Position.MarketPosition != MarketPosition.Long)    
                    ExitShort("Exit Short - MaxLoss", "");
                
                CloseStrategy("MaxLoss");
                return;
            }​

[NinjaTrader_ChelseaB]

Hello RaddiFX,

Are you certain the unrealized is not being checked?

Use prints to confirm. Print the time of the bar, the value of Position.MarketPosition, the value of Position.GetUnrealizedProfitLoss(), the value of SystemPerformance.AllTrades.TradesPerformance.NetP rofit, and the value of these added together.

Below is a link to a support article on using prints to understand behavior.

https://support.ninjatrader.com/s/article/Developer-Guide-Debugging-using-Print-and-TraceOrders

The condition you have to exit long appears incorrect as well.

if (Position.MarketPosition != MarketPosition.Long)
ExitLong("Exit Long - MaxLoss", "");

This states that if the position is not long, meaning the position is either short or flat, then call ExitLong(). If the position is not long, then calling ExitLong() will have no effect as there is no long position to exit.

[RaddiFX]

Good catch, I copied and pasted them from a different part of the code without editing. I'm running a backtest with the changes now.

[RaddiFX]

That alone seems to have fixed the whole issue. thanks!