Need Help with Strategy error

[Adam Klaus]

I am making a mechanical counter-trend strategy for trading futures contracts. The strategy uses the MBox Algo indicator, filtering for Springs and Upthrusts in a counter-trend direction, to identify potential trades.
These are the rules

• Use the MBox Algo indicator and filter for Springs and Upthrusts in a counter-trend direction.
• Enter trades when the price breaks the previous swing high or low.
• Exit trades at a 1:1 risk-reward ratio.
• Only trade between 9:30 AM and 12:00 PM.

The issue is It fires multiple trades, where it shouldn't.

The MBoxUpthrust is the original file that was working fine
It isnt until I pasted it in a blank strategy template (with stops, time zones etc) that it stopped working properly.
So I think I could be in trade management, but I'm not sure.
The AlgoMbox is the new file

Could someone please help me out to find whats the bug in the new file thats causing it. Thanks

[NinjaTrader_BrandonH]

Hello Adam Klaus,

Thanks for your post.

To understand why the script is behaving as it is, such as placing orders or not placing orders when expected, it is necessary to add prints to the script that print the values used for the logic of the script to understand how the script is evaluating.

In the strategy add prints (outside of any conditions) that print the values of every variable used in every condition that places an order along with the time of that bar.

Prints will appear in the NinjaScript Output window (New > NinjaScript Output window).

Below is a link to a forum post that demonstrates how to use prints to understand behavior.

https://ninjatrader.com/support/forum/forum/ninjatrader-7/strategy-development-aa/99209-date-conditions-not-working?p=791121#post791121

Further, you could use bools to control the logic in the script for placing trades. For example, you could create a bool (initially set to true) in your script and check if the bool is true in your condition to place a trade. You would call your entry order method within that condition to place the trade and set the bool to false. By doing so, the trade would only be placed when the bool is true. Note that you would need to create a condition to reset the bool to true, such as resetting the bool to true when you are in a flat position (Position.MarketPosition == MarketPosition.Flat).

[mcosta72]

Hi Adam, just learned about this : https://youtu.be/dprA_LefyhQ . AI code generator for NT : https://quantwisetrading.com/coder.php , it could debug your code too