Strategy Builder - Using a Buy/Sell indicator

[bnoisette]

I fixed it

[bnoisette]

Thx for taking a look and pointing me in the right direction

ok Sorry to inquire again but can you check to see if you can get it to take sell orders. I can get it to take buys but it is not taking doing sell orders. I actually changed the code to this (VolumeBasedBuySellSignals1.SellSignal[0] != 0) for the buy signal as well and all it does it take buy orders.

[bnoisette]

Here is what I have for the short section. On the longs it will still take trades without the print that is why I have it commented out here. The long is exactly the same except labeled "Buy"
// Set 2
if ((VolumeBasedBuySellSignals1.SellSignal[0] != 0)
//&& (Close[0] <= Close[1])
//&& ((BarsSinceExitExecution() > 3)
//|| (BarsSinceExitExecution() == -1)
&& (Position.MarketPosition == MarketPosition.Flat))
{
//Print(@"VolumeBasedBuySellSignals1.SellSignal[0]:" + Convert.ToString(VolumeBasedBuySellSignals1.SellSi gnal[0]));
}
{
EnterShort(1, @"ShortCTP");
EnterShort(1, @"ShortCTR");

[bnoisette]

Here is what I have for the short section. On the longs it will still take trades without the print that is why I have it commented out here. The long is exactly the same except labeled "Buy"
// Set 2
if ((VolumeBasedBuySellSignals1.SellSignal[0] != 0)
//&& (Close[0] <= Close[1])
//&& ((BarsSinceExitExecution() > 3)
//|| (BarsSinceExitExecution() == -1)
&& (Position.MarketPosition == MarketPosition.Flat))
{
//Print(@"VolumeBasedBuySellSignals1.SellSignal[0]:" + Convert.ToString(VolumeBasedBuySellSignals1.SellSi gnal[0]));
}
{
EnterShort(1, @"ShortCTP");
EnterShort(1, @"ShortCTR");

[bnoisette]

Thx for taking a look and pointing me in the right direction

ok Sorry to inquire again but can you check to see if you can get it to take sell orders. I can get it to take buys but it is not taking doing sell orders. I actually changed the code to this (VolumeBasedBuySellSignals1.SellSignal[0] != 0) for the buy signal as well and all it does it take buy orders.

[bnoisette]

I forgot to mention, if you run into little problems like this try painting the background for order execution and reviewing your order entry conditions and also open the data box to get an understanding of what the indicators are printing out (saves time from having to manually use the print function).

Thx for taking a look and pointing me in the right direction

[marco231]

I forgot to mention, if you run into little problems like this try painting the background for order execution and reviewing your order entry conditions and also open the data box to get an understanding of what the indicators are printing out (saves time from having to manually use the print function).

[marco231]

Also the sell signal is committed out as I was trying to get the buy signal to work properly first.

Thanks, I've managed to load your script and get it to take orders. The problem you had was that you are checking if the buy or sell signal =0 , when in actual fact it will never be 0 (it is always be NA or a number). The number it equals is the price the marker is created, see below image of highlighted green order circled in black, see the sell signal is NA in this instance. So the condition you need to check is (0 != VolumeBasedBuySellSignals1.BuySignal[1]).

The other thing I noticed was this condition && (BarsSinceExitExecution(0, "", 0) > 3), I commented it out to get it to take a trade. You need to refine what this is as I'm not sure what this is checking. I had it active and it didn't take any trades over 5 days 23 hours of the market open.

Anyway best of luck with your strategy, It looks like a great piece of work coming together !

[bnoisette]

Also the sell signal is committed out as I was trying to get the buy signal to work properly first.

[bnoisette]

If you can share the source code of your script + where I can download the indicator then I can review your code for you and give better guidance on why the issue is occuring.

Here you go. The indicator is there as well

[marco231]

If you can share the source code of your script + where I can download the indicator then I can review your code for you and give better guidance on why the issue is occuring.

[marco231]

Yeah I have that. This is what I have tried and it is not working

if ((0 == VolumeBasedBuySellSignals1.BuySignal[1])
&& (BarsSinceExitExecution(0, "", 0) > 3)
&& (Position.MarketPosition == MarketPosition.Flat))
{
Print(@"VolumeBasedBuySellSignals.BuySignal[0]:" + Convert.ToString(VolumeBasedBuySellSignals1.BuySig nal[0]));

is this a free indicator? the Volume Base Buy Sell Signals? It's hard to understand what is going on unless you share the code so that I can review and help you out. Otherwise we'll be doing a lot of back and forth here.

[bnoisette]

I ended up reviewing my code and there was additional information , you need make sure your market position is flat as part of the condition you can do something like this , && (Position.MarketPosition == MarketPosition.Flat)) . So when you get a signal, it will check 1 are you in a trade (from a previous signal - if so do not open another trade), if you are flat and you get a signal then enter the trade.

Yeah I have that. This is what I have tried and it is not working

if ((0 == VolumeBasedBuySellSignals1.BuySignal[1])
&& (BarsSinceExitExecution(0, "", 0) > 3)
&& (Position.MarketPosition == MarketPosition.Flat))
{
Print(@"VolumeBasedBuySellSignals.BuySignal[0]:" + Convert.ToString(VolumeBasedBuySellSignals1.BuySig nal[0]));

[marco231]

marco231 can you please share how you were able to get this to work? I use a similar indicator and I tried the print solution above and I get the same results.

I ended up reviewing my code and there was additional information , you need make sure your market position is flat as part of the condition you can do something like this , && (Position.MarketPosition == MarketPosition.Flat)) . So when you get a signal, it will check 1 are you in a trade (from a previous signal - if so do not open another trade), if you are flat and you get a signal then enter the trade.

[marco231]

Make sure your logic is calculate on bar close, and try using other conditions. Like Close of previous candle must be below 50 EMA or SMA. or Only take shorts if price is under Vwap or take longs if above vwap.