Buying in green candle

[kiro1000]

Hello,

I want to make a strategy that always buys when the candle is green,
Here is my code, it compiles fine but, when I enabled it into the chart, it doesn't do anything.

 protected override void OnBarUpdate()
        {
            if (Close[0]>Open[0])
             {
                EnterLong(Convert.ToInt32(DefaultQuantity), "");
            }
        }
​

Thanks

[NinjaTrader_Jesse]

Hello kiro1000,

How did you test the strategy when you tried it?

That is a fairly basic condition that should be able to become true. You can additionally add a Print or Drawing object into the condition to check if became true in your test.

if (Close[0]>Open[0])
{
    Print("Inside condition, condition was true");
    EnterLong(Convert.ToInt32(DefaultQuantity), "");
}

[kiro1000]

Hello Jesse,

Thank you for your message and guidance.

Upon retesting, I've come to realize that the strategy does indeed work. However, it doesn't execute trades on every green candle; instead, it buys at the end of the day close and sells at the end of the day close.

[NinjaTrader_Jesse]

Hello kiro1000,

You would need to exit the trade so it can continue placing trades. Are you trying to just enter a lot of positions but not exit them? If so you need to increase the entries per direction to match how many total entries in that direction you wanted to allow.

[kiro1000]

Hello Jesse,

Thank you for your advice.

I'll make sure to exit the trade to allow for further trades. I was indeed aiming to enter multiple positions without exiting them. I'm trying to solve it with a stoploss but I got the error message :
'BuyGreenCandle' already defines a member called 'OnStateChange' with the same parameter types

Here my code

protected override void OnBarUpdate()
             {
      if (Close[0]>Open[0])
        {
                EnterLong(Convert.ToInt32(DefaultQuantity), "");
        }
              }

             protected override void OnStateChange()
{
    if (State == State.Configure)
    {
            SetStopLoss(CalculationMode.Pips, 50);
    }

}    ​

Appreciate your assistance!

[NinjaTrader_Jesse]

Hello kiro1000,

A script can only have one method called OnStateChange. You need to move that code into the existing OnStateChange that the script has. You can add additional conditions like

if (State == State.Configure)
{
SetStopLoss(CalculationMode.Pips, 50);
}

inside the original OnStateChange in the script.

[kiro1000]

Hello Jesse,

Thank you for the guidance, I've successfully followed your instructions, and now it works! I'll consolidate the code by integrating the additional conditions with only one method called OnStateChange, Here the code :

protected override void OnStateChange()
        {
            if (State == State.SetDefaults)
            {
                Description                                    = @"Enter the description for your new custom Strategy here.";
                Name                                        = "GreenCandle";
                Calculate                                    = Calculate.OnBarClose;
                EntriesPerDirection                            = 1;
                EntryHandling                                = EntryHandling.AllEntries;
                IsExitOnSessionCloseStrategy                = true;
                ExitOnSessionCloseSeconds                    = 30;
                IsFillLimitOnTouch                            = false;
                MaximumBarsLookBack                            = MaximumBarsLookBack.TwoHundredFiftySix;
                OrderFillResolution                            = OrderFillResolution.Standard;
                Slippage                                    = 0;
                StartBehavior                                = StartBehavior.WaitUntilFlat;
                TimeInForce                                    = TimeInForce.Gtc;
                TraceOrders                                    = false;
                RealtimeErrorHandling                        = RealtimeErrorHandling.StopCancelClose;
                StopTargetHandling                            = StopTargetHandling.PerEntryExecution;
                BarsRequiredToTrade                            = 20;
                // Disable this property for performance gains in Strategy Analyzer optimizations
                // See the Help Guide for additional information
                IsInstantiatedOnEachOptimizationIteration    = true;
            }
            else if (State == State.Configure)
            {
                SetStopLoss(CalculationMode.Pips, 50);        
                SetProfitTarget(CalculationMode.Pips, 50);                
            }

        }
              protected override void OnBarUpdate()
             {
        if (Close[0]>Open[0])
        {
                EnterLong(Convert.ToInt32(DefaultQuantity), "");
            }
              }

Your assistance was invaluable; thank you for helping resolve this!