Correct my trail logic please

[tkaboris]

HI i have a logic for trail, first it sets initial SL value, then once SAR is below price then SAR becomes SL. All is working ok, however, if later SAR becomes above the price, SL becomes iniial price again and I dont want that to happen.
Thank you.

if (Position.MarketPosition == MarketPosition.Long && myFreeTradeLongTrail == true )
                    {
                        MySarStopL = (Position.AveragePrice - (StopTicksLong * TickSize)) ;
//                        Print("MySarStopL In trail:" + MySarStopL);
                    }
                    if ((Position.MarketPosition == MarketPosition.Long && myFreeTradeLongTrail == true )
                             && (ParabolicSAR1[0] > High[0]))


                        {
                            if(MySarStopL <= currentbid ){
//                                Print("condition1");
                            ExitLongStopMarket(1, true, Position.Quantity, MySarStopL, "SLL", "TML");
                            }
                        }

                    {

                        if ((Position.MarketPosition == MarketPosition.Long && myFreeTradeLongTrail == true)
                             && (ParabolicSAR1[0] <= Low[0]) )

                        {
//                                Print("condition2");
//                            Print("MySarStopL" + MySarStopL);
                                MySarStopL = ParabolicSAR1[0];
                        }    

                        if (Position.MarketPosition == MarketPosition.Long && myFreeTradeLongTrail == true  )
                        {
                             if(MySarStopL <= currentbid ){
//                                Print("condition3");
//                                 Print("MySarStopL" + MySarStopL);
                                 ExitLongStopMarket(1, true, Position.Quantity, MySarStopL, "SLL", "TML");
                             }
                        }
                        if (Position.MarketPosition == MarketPosition.Long && myFreeTradeLongTrail == true  )
                        {
                             if(MySarStopL >= currentbid ){
//                                Print("condition4");
//                                 Print("MySarStopL" + MySarStopL);
                                 ExitLong(1, Position.Quantity,"SLL", "TML");
//                                 ExitLongStopMarket(1, true, Position.Quantity, MySarStopL, "SLL", "TML");
                             }
                        }​

[NinjaTrader_ChelseaB]

Hello tkaboris,

You are setting the MySarStopL to the initial price any time the the position is long and myFreeTradeLongTrail is true, on every bar update.

if (Position.MarketPosition == MarketPosition.Long && myFreeTradeLongTrail == true )
{
MySarStopL = (Position.AveragePrice - (StopTicksLong * TickSize)) ;

Should it not be reassigned the value of ParabolicSAR1[0], due to this being greater than the bid, then that first assignment will still be assigned.

When do you want to use the first assignment? Are you wanting to assign this calculated value when the entry fills and / or the position updates?

[tkaboris]

Thank you
I want to assign first assignment open the entry only.

[NinjaTrader_ChelseaB]

Hello tkaboris,

In this case, move that condition and assignment to OnExecutionUpdate() or OnPositionUpdate().

https://ninjatrader.com/support/helpGuides/nt8/onexecutionupdate.htm

https://ninjatrader.com/support/helpGuides/nt8/onpositionupdate.htm

[tkaboris]

Would it look something like this then?

if (Position.MarketPosition == MarketPosition.Long && myFreeTradeLongTrail == true )

                    if ((Position.MarketPosition == MarketPosition.Long && myFreeTradeLongTrail == true )
                             && (ParabolicSAR1[0] > High[0]))


                        {
                            if(MySarStopL <= currentbid ){
//                                Print("condition1");
                            ExitLongStopMarket(1, true, Position.Quantity, MySarStopL, "SLL", "TML");
                            }
                        }

                    {

                        if ((Position.MarketPosition == MarketPosition.Long && myFreeTradeLongTrail == true)
                             && (ParabolicSAR1[0] <= Low[0]) )

                        {
//                                Print("condition2");
//                            Print("MySarStopL" + MySarStopL);
                                MySarStopL = ParabolicSAR1[0];
                        }    

                        if (Position.MarketPosition == MarketPosition.Long && myFreeTradeLongTrail == true  )
                        {
                             if(MySarStopL <= currentbid ){
//                                Print("condition3");
//                                 Print("MySarStopL" + MySarStopL);
                                 ExitLongStopMarket(1, true, Position.Quantity, MySarStopL, "SLL", "TML");
                             }
                        }
                        if (Position.MarketPosition == MarketPosition.Long && myFreeTradeLongTrail == true  )
                        {
                             if(MySarStopL >= currentbid ){
//                                Print("condition4");
//                                 Print("MySarStopL" + MySarStopL);
                                 ExitLong(1, Position.Quantity,"SLL", "TML");
//                                 ExitLongStopMarket(1, true, Position.Quantity, MySarStopL, "SLL", "TML");
                             }
                        }​

protected override void OnExecutionUpdate(Execution execution, string executionId, double price, int quantity, MarketPosition marketPosition, string orderId, DateTime time)
{


if (execution.Name == "TML")
{
MySarStopL = (Position.AveragePrice - (StopTicksLong * TickSize)) ;
}


}​

[NinjaTrader_ChelseaB]

Hello tkaboris,

The code would not have to change

protected override void OnExecutionUpdate(Execution execution, string executionId, double price, int quantity, MarketPosition marketPosition, string orderId, DateTime time)
{​
if (Position.MarketPosition == MarketPosition.Long && myFreeTradeLongTrail == true )
{
MySarStopL = (Position.AveragePrice - (StopTicksLong * TickSize)) ;
// Print("MySarStopL In trail:" + MySarStopL);
}​
}

[tkaboris]

Hi i dont understand what i am doing wrong but below clause breaks up my code.
Everything looks right syntax wise but its breaking my code..

protected override void OnExecutionUpdate(Execution execution, string executionId, double price, int quantity,
            MarketPosition marketPosition, string orderId, DateTime time)
        {

            if (Position.MarketPosition == MarketPosition.Long && myFreeTradeLongTrail == true )
                {
                    MySarStopL = (Position.AveragePrice - (StopTicksLong * TickSize)) ;                
                }​

            if (Position.MarketPosition == MarketPosition.Short && myFreeTradeShortTrail == true )
                {
                    MySarStopS = (Position.AveragePrice + (StopTicksShort * TickSize)) ;                        
                }        

        }    ​

[NinjaTrader_ChelseaB]

Hello tkaboris,

May I have a screenshot of the errors?

Is the OnExecutionUpdate within the scope of the class?

[tkaboris]

HI i am sorry for late response. I was able to do it like this and I get this error comes up but OnExecutionUpdate doesnt get called and i never get print condition outputed.
question about the scope. is OnExecutionUpdate has to be after onBarUpdate closing bracket?


OnBarupdate(){
}
OnExecutionUpdate(){
}
properties go below


my protected override void OnExecutionUpdate(Execution execution, string executionId, double price, int quantity,
MarketPosition marketPosition, string orderId, DateTime time)
{

if ((Position.MarketPosition == MarketPosition.Long || Position.MarketPosition == MarketPosition.Short)
&& (myFreeTradeLongTrail == true || myFreeTradeShortTrail == true))
{
Print("condition 0: ");
MySarStopL = (Position.AveragePrice - (StopTicksLong * TickSize));
MySarStopS = (Position.AveragePrice + (StopTicksShort * TickSize));
}

}

[tkaboris]

This is my scope
protected override void OnBarUpdate()
{


if (BarsInProgress == 0)
{

if(!ShowHistoricalTrades && State == State.Historical)
return;
else
{

......
......
......

} // else !historical


} // onBarInProgress



} // onbarupdate closing

protected override void OnExecutionUpdate(Execution execution, string executionId, double price, int quantity,
MarketPosition marketPosition, string orderId, DateTime time)
{

if ((Position.MarketPosition == MarketPosition.Long || Position.MarketPosition == MarketPosition.Short)
&& (myFreeTradeLongTrail == true || myFreeTradeShortTrail == true))
{
Print("condition 0: ");
MySarStopL = (Position.AveragePrice - (StopTicksLong * TickSize));
MySarStopS = (Position.AveragePrice + (StopTicksShort * TickSize));
}

}

[tkaboris]

Well apparently one of my bools is reading FALSE in OnExecutionUpdate.
I set myFreeTradeLongTrail to true when i make an order and never set it to false, only when flat. However when in onExecutionUpdate its FALSE. why does this bool sets to false?

[NinjaTrader_ChelseaB]

Hello tkaboris,

The placement of the OnExecutionUpdate() override after the closing curly brace of OnBarUpdate() so that it is within the scope of the class appears correct.

I'm uncertain of the Statement expected error. May I have you provide the .cs file so I may check there is proper syntax?

Regarding a bool value, where have you set the value to true? Place a print one line below each line of code that assigns this variable a value. Print the time of the bar, the name of the method this was called from, and the value of the variable.