Setting Target using a Variable Value

[johnMoss]

Sorry for the question, the library covers very little regarding the SetTarget methods

SetProfitTarget("Long", CalculationMode.Ticks, 40);

works just fine of course, as the 40 above is an integer.

Replacing that integer with anything other than another direct numerical integer value yields random results, mostly 1 to 1/2 point targets.

I'm sure this can be simplified, but in the moment I have:

double bodySize = Math.Abs(Open[0] - Close[0]);
double bodySize1 = Math.Round(bodySize);
int Profit = System.Convert.ToInt32(bodySize1);

Trying

SetProfitTarget("Long", CalculationMode.Ticks, Position.AveragePrice + Profit); or

SetProfitTarget("Long", CalculationMode.Ticks, Profit);

still yields random results.


Obviously my conversion method is amiss?

Setting int Profit to a direct integer value, i.e. int Profit = 40; works just fine...

Thanx
JM

[NinjaTrader_BrandonH]

Hello JM,

Thanks for your post.

Are you calling SetProfitTarget() in State.Configure?

Or, are you calling SetProfitTarget() in OnBarUpdate()?

If you are trying to use dynamic values for SetProfitTarget(), you should do your calculations in OnBarUpdate() and call SetProfitTarget() in OnBarUpdate() one line above your Entry order method.

For example:

//OnBarUpdate()

double bodySize = Math.Abs(Open[0] - Close[0]);
double bodySize1 = Math.Round(bodySize);
int Profit = System.Convert.ToInt32(bodySize1);

if (condition)
{
SetProfitTarget("Long", CalculationMode.Ticks, Profit);
EnterLong();
}

Prints should be added to the script one line after your calculations that print out the value of your calculations so that you can see how it is evaluating.

For example:

double bodySize = Math.Abs(Open[0] - Close[0]);
Print("bodySize: " + bodySize);
double bodySize1 = Math.Round(bodySize);
Print("bodySize1: " + bodySize1);
int Profit = System.Convert.ToInt32(bodySize1);
Print("Profit: " + Profit);

Below is a link to a forum post that demonstrates how to use prints to understand behavior.
https://ninjatrader.com/support/foru...121#post791121

See this help guide page for more information about SetProfitTarget(): https://ninjatrader.com/support/help...ofittarget.htm

Here is a reference sample demonstrating using SetProfitTarget() in OnBarUpdate(): https://ninjatrader.com/support/help..._lo.htm

[johnMoss]

Hi Brandon,
Thank you for taking weekend time to respond. Yes, all of the above is being called in OnBarUpdate. Our code matches so I'll look at the prints...

[johnMoss]

Prints:
bodySize: 0
bodySize1: 0
Profit: 0
bodySize: 0
bodySize1: 0
Profit: 0
bodySize: 0.75
bodySize1: 1
Profit: 1
bodySize: 0.5
bodySize1: 0
Profit: 0
bodySize: 0.5
bodySize1: 0
Profit: 0
bodySize: 0.25
bodySize1: 0
Profit: 0
bodySize: 0.5
bodySize1: 0
Profit: 0
bodySize: 0.25
bodySize1: 0
Profit: 0
bodySize: 0.75
bodySize1: 1
Profit: 1
bodySize: 0.25
bodySize1: 0
Profit: 0
bodySize: 0.25
bodySize1: 0
Profit: 0
bodySize: 0
bodySize1: 0
Profit: 0
bodySize: 0.5
bodySize1: 0

Changed Double bodysize to var bodySize..
Running another output but no values so far

[NinjaTrader_BrandonH]

Hello JM,

Thanks for your notes.

bodySize should not be changed to var. You should use double bodySize in your script.

The value argument of SetProfitTarget() is 'double value'.

SetProfitTarget(CalculationMode mode, double value)

SetProfitTarget(): https://ninjatrader.com/support/help...etprofittarget

A whole number needs to be passed into the SetProfitTarget() method when using CalculationMode.Ticks. Decimals should not be used for the double value argument in the SetProfitTarget() method when CalculationMode is set to CalculationMode.Ticks.

This means that you would need to make sure to pass in a whole number, such as 1, 5, 10, etc. for the double value argument in the SetProfitTarget() method.

[johnMoss]

Thank you Brandon. On examination I'm seeing errors in my use of logic. I'm gonna dive into that next.

[johnMoss]

Fixed... All good thank you...
JM