The Strat breakouts indicator

[ezrollin]

I'm trying to make an indicator using a strategy cause its easier and theres no Indicator Builder program.
All I'm trying to do is paint/draw an arrow where the current candle has broken above/below the previous candle (on the 15minute charts)
NinjaTrader sometimes works, but usually doesnt.
I started to make a custom series but then thought I wouldnt need it.
What am I doing wrong?
Thanks

namespace NinjaTrader.NinjaScript.Strategies
{
    public class JonsTheStratIndicatorStrategy : Strategy
    {

        private Series<double> Green;
        private Series<double> Red;

        protected override void OnStateChange()
        {
            if (State == State.SetDefaults)
            {
                Description                                    = @"";
                Name                                        = "JonsTheStratIndicatorStrategy";
                Calculate                                    = Calculate.OnBarClose;
                EntriesPerDirection                            = 1;
                EntryHandling                                = EntryHandling.AllEntries;
                IsExitOnSessionCloseStrategy                = true;
                ExitOnSessionCloseSeconds                    = 30;
                IsFillLimitOnTouch                            = false;
                MaximumBarsLookBack                            = MaximumBarsLookBack.TwoHundredFiftySix;
                OrderFillResolution                            = OrderFillResolution.Standard;
                Slippage                                    = 0;
                StartBehavior                                = StartBehavior.WaitUntilFlat;
                TimeInForce                                    = TimeInForce.Day;
                TraceOrders                                    = false;
                RealtimeErrorHandling                        = RealtimeErrorHandling.IgnoreAllErrors;
                StopTargetHandling                            = StopTargetHandling.PerEntryExecution;
                BarsRequiredToTrade                            = 1;
                // Disable this property for performance gains in Strategy Analyzer optimizations
                // See the Help Guide for additional information
                IsInstantiatedOnEachOptimizationIteration    = true;
            }
            else if (State == State.Configure)
            {
                AddDataSeries(Data.BarsPeriodType.Minute, 15);
            }
            else if (State == State.DataLoaded)
            {                
                Green = new Series<double>(this);
                Red = new Series<double>(this);            
            }
        }

        protected override void OnBarUpdate()
        {
            if (BarsInProgress != 0)
                return;

            if (CurrentBars[1] < 1)
                return;

[B] // Set 1
            if (Closes[1][0] > Highs[1][1])
            {
                Green[0] = 0;
                BarBrush = Brushes.DarkGreen;
            }

             // Set 2
            if (Closes[1][0] < Lows[1][1])
            {
                BarBrush = Brushes.Maroon;
                Red[0] = 0;[/B]
            }

        }
    }
}

[NinjaTrader_ChelseaB]

Hello ezrollin,

The code you have checks if the close of the current BarsInProgress 1 bar is greater than the high of the previous BarsInProgress 1 bar. This appears to be correct if that is what you want.

Use Prints to understand behavior.

Below is a link to a forum post on using print to understand behavior.
https://ninjatrader.com/support/foru...121#post791121

if (CurrentBars[0] < 1 || CurrentBars[1] < 1)
return;

Print(string.Format("{0} | BarsInProgress: {0}, {1} {2} {3} | Closes[1][0]: {4} > Highs[1][1]: {5}", Time[0], BarsInProgress, Instrument.FullName, BarsArray[BarsInProgress].BarsPeriod.Value, BarsArray[BarsInProgress].BarsPeriod.BarsPeriodType, Closes[1][0], Highs[1][1] ));

if (BarsInProgress == 0 && Closes[1][0] > Highs[1][1])
{
Print(string.Format("{0} | BIP 1 close is above previous BIP 1 high", Time[0]));
}

[ezrollin]

I'm just trying to say that if (On Bar Close) this bar closes lower than the previous bar then its a breakout
I cant even do that in strategy builder.
I'm figuring everything is based OnBarClose (cause thats what I chose)
but I do see in my code that it says bars in progress (I never chose that)

[NinjaTrader_ChelseaB]

Hello ezrollin,

There is a 15 minute data series added. The Strategy Builder is not able to trigger actions on that secondary series and can only use the data from the secondary series when the primary series is updating.

Your current code is selecting that 15 minute series for data, when the primary series bar closes.

Were you intending to trigger actions when the 15 minute series bar closes?
If so, you will need to unlock the script and code by hand.