ChangeOrder()

[Gianni_Destroyer]

Hi I would like some help with my code please:

Im looking to change the stop price of the unfilled order to 4 ticks higher, (It would be EMA2[0] + (-12*TickSize)), in the scenario the else if applies.
Thank you

[NinjaTrader_ChelseaB]

Hello Gianni_Destroyer,

To ensure the order is not filled, assign the order to a variable in OnOrderUpdate().

Then check the order.OrderState is OrderState.Working.

The help guide has sample code of assigning an order to a variable.

https://ninjatrader.com/support/helpGuides/nt8/onorderupdate.htm

https://ninjatrader.com/support/helpGuides/nt8/order.htm

If you wanted to change the order to be 4 ticks higher than its current working stop price, add 4 ticks to the price of the stop.

if (entryOrder != null && entryOrder.OrderState == OrderState.Working /* && conditions to trigger price change here*/)
{
EnterShortStopMarket(0, true, DefaultQuantity, entryOrder.StopPrice + 4 * TickSize, "ashe1");
}

[Gianni_Destroyer]

Hi ChelseaB, thank you for answering, but I am still having trouble to achieve what im looking for. This is for an entry going long but it is the same logic.

The original order still does not move down 4 ticks before being filled if the current close is lower than the EMA specified.

[NinjaTrader_ChelseaB]

Hello Gianni_Destroyer,

How do you know this has occurred?

Add prints to the script and enable TraceOrders to understand behavior. See the forum post below and watch the training videos.

https://ninjatrader.com/support/forum/forum/ninjatrader-7/strategy-development-aa/99209-date-conditions-not-working?p=791121#post791121

One line above the condition, print the time of the bar, print a label for entryOrderLong.OrderState, print the value for entryOrderLong.OrderState, print a label for == OrderState.Working, print a label for the Close[0] print the value of the Close[0], print a label for less than EMA2[0], print the value of EMA2[0].
Then print the entryOrderLong.StopPrice minus 4 ticks.

Save the output from the output window to a text file, and attach this to your next post.

[Gianni_Destroyer]

Hi, I´m sorry for answering some days later, but I´ve been running with this problem and I do not know how to fix it:
I enable the strategy, to see the prints you told me to add, and automatically the strategy disables leaving this error message.

[NinjaTrader_ChelseaB]

Hello Gianni_Destroyer,

The error message means the code has attempted to use a variable with a null value.

Below is a link to a forum post that discusses.

https://ninjatrader.com/support/forum/forum/ninjatrader-8/strategy-development/1107472-entryorder-null-error#post1107522

What is the specific line of code in OnBarUpdate() with the variable that has a null value?

[Gianni_Destroyer]

The code is the same one as I attached you in my second post. It used to work but suddenly this error appears and I didn´t change anything. I assign entryOrderLong to be null and if this is true and the other coditions apply then I enterLongStopMarket. In onOrderUpdate I assign the null variable (entryOrderLong) to be the current order:

[NinjaTrader_ChelseaB]

Hello Gianni_Destroyer,

What is the specific line of code causing the error?

Which variable is null?


You can add a print before each line to see which print is the last print to appear before the error appears.
You could comment out code until the error stops and look at the last line that was commented out.

https://ninjatrader.com/support/forum/forum/ninjatrader-7/strategy-development-aa/99209-date-conditions-not-working?p=791121#post791121

[Gianni_Destroyer]

I don´t know whta is the specific line causing the error. I placed loads of prints and none appears in the output.
The null variable is entryOrderLong. I am really stuck here, sorry and thanks for the help.

[NinjaTrader_ChelseaB]

Hello Gianni_Destroyer,

If you comment out all code in OnBarUpdate(), does the error still occur?

If you uncomment the first line in OnBarUpdate(), does the error occur?


If you have identified the line causing the error and have determined that the use of the entryOrderLong variable is causing the error, then ensure the variable is not null before using the variable.

if (entryOrderLong != null)
Print(entryOrderLong.ToString());

[Gianni_Destroyer]

Hi ChelseaB,

Yes, if I comment out all the code in OnBarUpdate() the error still occurs and if I uncomment the first line it still has the error. The only variable that is null is entryOrderLong so I assume that is causing the problem. What I don´t uderstand is the fact that in this example https://ninjatrader.com/support/help...rderupdate.htm they assign a null variable in the same way I did.

[QuantKey_Bruce]

I would not recommend counting on a short-circuit skipped evaluation of "if (entryorderlong !=null && entryorderlong.whatever == whatever)" - as a matter of good practice you probably should be checking for null and then, only if that instance is not null, checking its properties.

Also, make sure it's not one of your indicator instance variables like EMA1 etc that is null.

[NinjaTrader_ChelseaB]

Hello Gianni_Destroyer,

If you have commented out all code in OnBarUpdate() and the error is still occurring, then you have not compiled the script and reloaded.

The error is in OnBarUpdate(). If all code in OnBarUpdate() is commented out and the script is compiled, there would be no error able to come from OnBarUpdate() because there is no code in OnBarUpdate().

Be sure that after you have commented out all of the code, that you compile, and then reload NinjaScript on the chart. You would be looking to ensure there are no new errors appearing (with the current date and timestamp on the Log tab of the Control Center).

[Gianni_Destroyer]

Hi, I was able to fix the error, thank you!
Anyways, I'am still having problems when trying to change the price of an order that´s been accepted yet not filled. I want the unfilled order price to be 4 ticks lower than its initial price if a condition is met, here is the code:
The problem I'am having is that once the condition is met an error occurs stating I cannot change the price of the order to a price level lower than the market price. But I placed a print to see this, and as I will show you, the first stopPrice - 4 ticks gives a price higher than the Close, so i dont understand how to fix this.


p.d = I named low the current price
I also don't understand why does the entryOrderLong.StopPrice - 4 ticks changes its price because the initial order doesn´t change price.
Thank you!

[NinjaTrader_ChelseaB]

Hello Gianni_Destroyer,

A buy stop order must have the stop price above the current ask, or this will be rejected by the brokerage.

You will need a condition to ensure that entryOrderLong.StopPrice + (-4 * TickSize) is greater than GetCurrentAsk().

https://forum.ninjatrader.com/forum/ninjatrader-8/add-on-development/1198996-stop-price-can-t-be-changed#post1199001

If it is not, meaning this calculated price is equal to the current ask or below, I would recommend you instead cancel this order, and place a market order instead, which will fill immediately at market price.