Time Filter Template

[AgriTrdr]

I found a SampleTimeFilter template in the Ninjatrader help guide which I've attached for reference. I would like to use the 24hr format that it's currently in, but would like to be able to modify the time when I select the strategy. Below is a code of what I've modified so far. Would this be the correct way?


protected override void OnStateChange()
{
if (State == State.SetDefaults)
{
StartTradingTime = 083000;
EndTradingTime = 150000;
}
}

protected override void OnBarUpdate()
{
if (ToTime(Time[0]) >= StartTradingTime && ToTime(Time[0]) < EndTradingTime)
{
Logic
}
}

#region Properties
[NinjaScriptProperty]
[PropertyEditor("NinjaTrader.Gui.Tools.TimeEditorKe y")]
[Display(Name="StartTradingTime", Order=1, GroupName="TradingTime")]
public DateTime StartTradingTime
{ get; set; }

[NinjaScriptProperty]
[PropertyEditor("NinjaTrader.Gui.Tools.TimeEditorKe y")]
[Display(Name="EndTradingTime", Order=2, GroupName="TradingTime")]
public DateTime EndTradingTime
{ get; set; }

[NinjaTrader_Jesse]

Hello AgriTrdr,

If you wanted to maintain the same format of using 083000 then the public properties should be integers.

[NinjaScriptProperty]
[Display(Name="StartTradingTime", Order=1, GroupName="TradingTime")]
public int StartTradingTime
{ get; set; }

[NinjaScriptProperty]
[Display(Name="EndTradingTime", Order=1, GroupName="TradingTime")]
public int EndTradingTime
{ get; set; }

[AgriTrdr]

Thanks for your reply. Does there need to be anything for the Range?

#region Properties
[NinjaScriptProperty]
[Range(1, int.MaxValue)]
[Display(Name="StartTradingTime", Order=1, GroupName="TradingTime")]
public int StartTradingTime
{ get; set; }

[NinjaScriptProperty]
[Range(1, int.MaxValue)]
[Display(Name="EndTradingTime", Order=2, GroupName="TradingTime")]
public int EndTradingTime
{ get; set; }

[NinjaTrader_Jesse]

Hello AgriTrdr,

No you would not need the range attribute for this.

[AgriTrdr]

If there's a secondary data series in the strategy, would the below be the correct way for the if condition or do I leave it as I had initially?

if (ToTime(Times[0][0]) >= StartTradingTime && ToTime(Times[0][0]) < EndTradingTime)

[NinjaTrader_Jesse]

Hello AgriTrdr,

This code is using Times[0][0] meaning the primary series times. If you wanted to check the time for both series that depends if this code is within a BarsInProgress condition.

If there are no BarsInProgress conditions you can use Time[0] to reference whichever series has called OnBarUpdate.

protected override void OnBarUpdate()
{


if (ToTime(Time[0]) >= StartTradingTime && ToTime(Time[0]) < EndTradingTime)