Logical question about SampleOnOrderUpdate

[jetheil2]

Hi,
in SampleOnOrderUpdate: https://ninjatrader.com/support/help...and_onexec.htm

On line 122:

if (execution.Order.OrderState == OrderState.Filled || execution.Order.OrderState == OrderState.PartFilled || (execution.Order.OrderState == OrderState.Cancelled && execution.Order.Filled > 0)){
...
}

Is it a redundant judgment condition?
Is it possible to replace with:

if (execution.Order.Filled > 0){
....
}


On line 125:
Is sumFilled redundant?
On line 142 it can be replaced with if (execution.Order.OrderState == OrderState.Filled){
entryOrder = null;
sumFilled = 0;
}

[NinjaTrader_Jim]

Hello jetheil2,

Thanks for your post.

The sumFilled part was added to handle an edge case where you get a partial fill and a complete fill happening within 1/100th of a second.

It does look like some of the logic can be optimized to remove some redundancies.

I'll see about simplifying this and getting changes approved.

EDIT: It was decided to leave the code as it is. Even though there are redundancies, the repeated code and logic is intended to be educational over being concise.

We look forward to assisting.