I can't get the correct swing highs past a certain point

[jableshank]

I have a method that uses the swing indicator to get the values of previous swing highs. It's working fine for the first few instances, then begins to output incorrect values the further back that I look. The strength of the swing indicator is set to 10 and I'm trying to get 15 instances.

This is my code:

private void GetSwings() {

if(mySwing.SwingHigh[0] > 0) // check for valid swing high

{

for(int i = 1; i <= 15; i++)

{

if(mySwing.SwingHighBar(0, i, CurrentBar) > -1) // check for valid swing high bar

{

myswingHighBarsAgo = mySwing.SwingHighBar(0, i, CurrentBar);

Print(Time[myswingHighBarsAgo]+" Instance # "+i+" bars ago: "+myswingHighBarsAgo+" High was: "+High[myswingHighBarsAgo]);

Dot highDot = Draw.Dot(this, "dotHigh"+i, true, Time[myswingHighBarsAgo], High[myswingHighBarsAgo] + 6 * TickSize, Brushes.DodgerBlue);

highDot.OutlineBrush = Brushes.DodgerBlue;

}

}

}

}

The attached photo shows the blue dots become misaligned on the older instances.

[NinjaTrader_ChrisL]

Hi jableshank, thanks for posting.

Did you use Prints in your script to confirm the data is being offset in some way? It will be important to use the Print method to debug and print data coming from the script to explain the output.

https://ninjatrader.com/support/helpGuides/nt8/NT%20HelpGuide%20English.html?print.htm

The Swing indicator can re-draw its high and low values as the data is processed, so what is likely happening is the swing value is the same as the dot but as more data is processed the prior swing is changed and your dot is not changed. Try debugging by printing each value of swing high and low of each bar as notice if the values are changing. Another way to test is to use the Playback connection and see what happens on real time data vs the historical data.

https://ninjatrader.com/support/helpGuides/nt8/NT%20HelpGuide%20English.html?playback.htm

Best regards,
-ChrisL

[jableshank]

Hey Chris, thanks for the reply. This is what I get in the output window. All of the times and price levels match the dots but only match with a portion of the swings on the chart. How would I go about confirming the data is being offset in some way?

[NinjaTrader_ChrisL]

Hello jableshank , thanks for your reply.

Note these swing values and bar timestamps and play this same data back on the playback connection. Do you see the swing highs and low lines changing as new data is added? The swing indicator source code is also available to study through the NinjaScript editor and you can see how it looks back on bars to calculate the swing high and low and how this can change as new data is added.

Best regards,
-ChrisL

[jableshank]

Thanks Chris, I'll check out the source code for sure.