Passing NijnaScriptBase, NinjaScript refs to non-static class

[Wick Wrangler]

I found this post regarding private classes and access to a calling strategies data.
https://ninjatrader.com/support/foru...les#post692124

In the example, a static class is created that can act on NijnaScriptBase and NinjaScript methods from the calling strategy.

I created a non-static class to do the same thing, and it seems to be working. Here's a sample of what I'm doing:

namespace NinjaTrader.NinjaScript.Strategies
{

public class XoSignal
{


   private NinjaScriptBase nsb;
    private NinjaScript ns;

    // passed in indicators
    private SMA SMA1;
    private SMA SMA2;

    public XoSignal(NinjaScriptBase nsbPassed, NinjaScript nsPassed, SMA s1, SMA s2)
    {
        this.nsb = nsbPassed;
        this.ns = nsPassed;

        this.SMA1 = s1;
        this.SMA2 = s2;
    }

    public bool DidCrossAbove
    {
        get
        {
            return nsb.CrossAbove(SMA1, SMA2, 1);
        }
    }
}

}

The class can be instantiated and called like this:

private XoSignal Sig;

Sig = new XoSignal(this, this, SMA1, SMA2);

if (Sig.DidCrossAbove) {
    // do something
}

I'd like to know if there's any reason that static classes and methods should be used, rather than instance classes (for thread-safety, for instance), or if the two methods of doing this are both viable.

[NinjaTrader_ChelseaB]

Hello Wick Wrangler,

The approach really depends on what you are trying to achieve.

The creation of a new class instance (that does not inherit from Indicator, Strategy, or any other NinjaScript class type) would be the supported approach. And shouldn't cause any issues.

A partial class just for shared methods, with inheritance, would also be fine.
See 'Partial Classes (Porting methods and properties from UserDefinedMethods.cs)' in the Code Breaking Changes.
https://ninjatrader.com/support/help...hangesOverview

Static classes can sometimes be fine and would use less overhead (static methods would not have to take new instance memory locations) but sharing objects could get messy and would fall outside of support.
Below is a link to a shared static objects example.
https://ninjatrader.com/support/foru...245#post712245

[Wick Wrangler]

The creation of a new class instance (that does not inherit from Indicator, Strategy, or any other NinjaScript class type) would be the supported approach. And shouldn't cause any issues.

Thanks for the clarification.

[neo302]

Hello Wick Wrangler and Chelsea,

In the original post, what exactly is being passed in for the SMA indicators - Sig = new XoSignal(this, this, SMA1, SMA2);
I'm trying to figure out how to pass an indicator.

Thank you!

[NinjaTrader_ChelseaB]

Hello neo302,

That is likely an ISeries<double> property.

https://ninjatrader.com/support/forum/forum/historical-beta-archive/version-8-beta/89680-2nd-indicator-input-series-via-property-dialog?p=751109#post751109