Newbie help

[Unxander]

Hi!

So i'm trying to make a Strategy with the Crossing of MacD, alone the MacD isn't good and will only give a 48% winrate.
Now i want to filter out some of the bad trades using the 200EMA, Only going Short when the price is below and only going long when the price is above.
Like seen in this video ; https://www.youtube.com/watch?v=nmffSjdZbWQ&t=351s

I've tried putting it in a group with a 1% above or below seeing i would like to trade the trend and not a range.

protected override void OnBarUpdate()
{
if (BarsInProgress != 0)
return;

if (CurrentBars[0] < 1)
return;

// Set 1
if ((CrossAbove(MACD1.Default, MACD1.Avg, 1))
// Condition group 1
|| ((Close[0] * 1) > EMA1[0]))
{
EnterLong(Convert.ToInt32(DefaultQuantity), "");
}

// Set 2
if ((CrossBelow(MACD1.Avg, MACD1.Default, 1))
// Condition group 1
&& ((Close[0] * 1) < EMA1[0]))
{
EnterShort(Convert.ToInt32(DefaultQuantity), "");
}

}

But this doesn't solve it and the script will still go long while under the 200ema.

Any advice?
Thanks!

[NinjaTrader_Jim]

Welcome to the forums Unxander!

if ((CrossAbove(MACD1.Default, MACD1.Avg, 1))
// Condition group 1
|| ((Close[0] * 1) > EMA1[0]))

This condition checks if there is a corssover OR if the current market price (Close[0)] times 1 is greater than the EMA value. This is not factoring a percentage of the close being greater than the EMA and since you are checking OR (if any) ether condition can be true

To set up a condition factoring 1%, please see the attached screenshot.

If you are simply trying to set up entry conditions, I suggest checking if the strategy position is flat before calling EnterLong/EnterShort. (Positions will reverse if EnterLong/EnterShort is called in the opposite direction.) Please see "Creating market position comparisons" in our help guide page below.

https://ninjatrader.com/support/helpGuides/nt8/?strategybuilder_condition_builder.htm

If you have not already seen it, please see our Strategy Builder 301 tutorial for a full walk through on using this tool.

https://www.youtube.com/watch?v=HCyt90GAs9k

We look forward to assisting.