What is efficient?

[staycool3_a]

hello,

What is relatively more efficient?

if(XYZ)
{ABC = true}

if(BarsInProgress = 24)
(if ABC = true & Close>0) {EnterLong}

if(BarsInProgress = 10)
(if ABC = true & Close>0) {EnterLong}

vs

If(XYZ)
{ABC= true}

If(ABC = true && Closes[24][0] > 0) {EnterLong(24,true,Quantity.........}

If(ABC = true && Closes[10][0] > 0) {EnterLong(10,true,Quantity.........}

[NinjaTrader_Jim]

Hello staycool3_a,

Thanks for your question.

Using a BarsInProgress check will limit operations to occur only when that Data Series is iterating. If you do not use BarsInProgress checks, those operations will take place on every BarsInProgress iteration.

Limiting your operations so they only occur when necessary would be the most efficient way to design your code.

More information on setting up BarsInProgress checks along with a complete guide for working with Multi Time Frame NinjaScripts can be found below.

Event Driven OnBarUpdate (Multi Time Frame and Instruments) - https://ninjatrader.com/support/help...arupdateMethod

Also as a tip, I may suggest formatting your code so your curly braces are on separate lines. This can help with readability and can help us to better follow what you are programming. Online tools like Code Beautify can be used to quickly format code.

CodeBeautify - https://codebeautify.org/

Please let us know if we can be of further assistance.

[staycool3_a]

Hello staycool3_a,

Thanks for your question.

Using a BarsInProgress check will limit operations to occur only when that Data Series is iterating. If you do not use BarsInProgress checks, those operations will take place on every BarsInProgress iteration.

Limiting your operations so they only occur when necessary would be the most efficient way to design your code.

More information on setting up BarsInProgress checks along with a complete guide for working with Multi Time Frame NinjaScripts can be found below.

Event Driven OnBarUpdate (Multi Time Frame and Instruments) - https://ninjatrader.com/support/help...arupdateMethod

Also as a tip, I may suggest formatting your code so your curly braces are on separate lines. This can help with readability and can help us to better follow what you are programming. Online tools like Code Beautify can be used to quickly format code.

CodeBeautify - https://codebeautify.org/

Please let us know if we can be of further assistance.

Thank you Jim. I will try to beautify my code in the future.

I don't really understand iteration concept. So i'm just going to stick to the option without doing the barsinprogress check and directly indexing

[koganam]

hello,

What is relatively more efficient?

if(XYZ)
{ABC = true}

if(BarsInProgress = 24)
(if ABC = true & Close>0) {EnterLong}

if(BarsInProgress = 10)
(if ABC = true & Close>0) {EnterLong}

vs

If(XYZ)
{ABC= true}

If(ABC = true && Closes[24][0] > 0) {EnterLong(24,true,Quantity.........}

If(ABC = true && Closes[10][0] > 0) {EnterLong(10,true,Quantity.........}

Avoid redundancy

if (XYZ) {
  ABC = true;
}

if (ABC) {
  if ((BarsInProgress == 24 || BarsInProgress == 10) && Close[0] > 0) EnterLong();
}