Custom TradeCollection WinningTrades Property is Null

[BarzTrading]

When I create a custom TradeCollection as referenced in this thread (https://ninjatrader.com/support/foru...radecollection) some properties are null:

TradeCollection trades = new TradeCollection(true, true);
SystemPerformance.AllTrades.Where(t => t.Entry.Name == "Entry01").ToList().ForEach(t => trades.Add(t));
var winningTrades = trades.WinningTrades; // null
var losingTrades = trades.LosingTrades; // null

Is there something else one needs to do for those properties to be populated?

[BarzTrading]

OK. I changed

TradeCollection trades = new TradeCollection(true, true);

to

TradeCollection trades = new TradeCollection(false, true);

and the properties are now populated.

Can you tell me what I changed by doing this? The parameter name is only "sub".

Thanks,

[NinjaTrader_ChelseaB]

Hello BarzTrading,

Using a custom trade collection would be general C# and is not documented as an intended use in the NinjaTrader help guide.

However, that said, I am test adding to a custom trade collection using a secondary MSFT series with the sub parameter as false with new TradeCollection() and I am able to get performance and I am not able to reproduce this behavior.

If you test this strategy on a 1 Day AAPL chart while connected to Kinetick End of Day (Free) (so that we can ensure you get daily data for equities) is the print showing the performance as 0?

[BarzTrading]

Thanks, Chelsea. Your example is not testing the issue I described. Most of the performance values are available. It is specifically the WinningTrades and LosingTrades properties of the TradeCollection that are not populated when sub=true.

They are populated when sub=false.

When I add the following to your example the results are consistent with mine:

 if (trades.WinningTrades == null)
{
     Print("WinningTrades is null");
}
else
{
   Print("WinningTrades is NOT null");
}

[NinjaTrader_ChelseaB]

Hello BarzTrading,

Thank you for catching that I was not looking at the Winning and Losing collections specifically.

I was able to reproduce.

I'm inquiring further with our development, however, this would be undocumented and I cannot guarantee I will get a reply.
However, I will let you know anything I find out.

[NinjaTrader_ChelseaB]

Hello BarzTrading,

Our development has confirmed that the sub parameter enables separating out the trade collections into winning/losing.