Strategy performance issues

[itrader46]

Hello

I have a code finding flat parts of an indicator, which then makes List with. My question is, for the best script performance, should I use the first code, or the second?

Thank you

// Variant 1
if (Math.Abs(DMI1[1] - DMI1[2]) < 0.0001)
{                                       
      FlatDMI.Add(DMI1[1]);

// Variant 2
if (!FlatInd && Math.Abs(DMI1[1] - DMI1[2]) < 0.0001)
{      
      flat =  DMI1[1]                                
      FlatDMI.Add(flat);

[NinjaTrader_ChelseaB]

Hello itrader46,

Creating a new variable which needs memory, assigning it a value which takes an operation, and then using this will take an unperceivable amount of more work.
Using the value that already exists would use less work.

[itrader46]

Hi Chelsea

I take it Variant 1 is better, then?

I thought so myself, but just wanted to check, as my code got longer every day and I am now in a process of eliminating bits I don't actually need.

The code below is from Ninja Best Practices -> Referencing indicator methods, with mySma initialised in State.Historical.

With my DMI1 being initialised in OnStateChange() -> State.DataLoaded, would that make any difference?

private SMA mySma;

protected override void OnStateChange()
{
  // when the indicator begins processing
  // save an instance of the SMA indicator with the desired input  
  if (State == State.Historical)
  {
    mySma = SMA(20);
  }

[NinjaTrader_ChelseaB]

Hello itrader46,

Assigning the instance of an indicator to a variable is often useful to access the indicator at a later time.

[itrader46]

Hi Chelsea.
Do you mind reading and addressing the issues my previous post?
Thank you

[NinjaTrader_ChelseaB]

Hello itrader46,

No, calling an indicator after the data is ready in DataLoaded will not make a difference.