simplify code

[user10]

Hello to the forum,

I want to outsource recurring calculations from my strategy and simplify my code. That's why I wrote the following code.

        protected override void OnBarUpdate()
        {
            // create dummy signal to evaluate
            barCounter++;
            if (barCounter % 2 == 0) barCounter2 += 2;
            testSeries[0] = barCounter2;

            MyHistoricSeries myHistoricSeries = new MyHistoricSeries();

            // Does not add!
            methodCounter =   myHistoricSeries.Counter(testSeries);

            Print (Time[0]
            + "  barCounter  " + barCounter
            + "  barCounter2 " + barCounter2
            + "  methodCounter  " + methodCounter
            );
        }
    }
}

    public class MyHistoricSeries
    {
        int myCounter;
        // Evaluate testSeries
        public int Counter (Series<int>mySeries)
        {
            if (mySeries[0] > mySeries[1]) myCounter++;
            return myCounter;
        }
    }

The testSeries is passed to the Counter method and returns the evaluation.
But I want the methodCounter to cumulate!

Is that basically possible or what other solution is there for my problem?

Many thanks for the support!

[koganam]

Hello to the forum,

I want to outsource recurring calculations from my strategy and simplify my code. That's why I wrote the following code.

protected override void OnBarUpdate()
{
// create dummy signal to evaluate
barCounter++;
if (barCounter % 2 == 0) barCounter2 += 2;
testSeries[0] = barCounter2;

MyHistoricSeries myHistoricSeries = new MyHistoricSeries();

// Does not add!
methodCounter = myHistoricSeries.Counter(testSeries);

Print (Time[0]
+ " barCounter " + barCounter
+ " barCounter2 " + barCounter2
+ " methodCounter " + methodCounter
);
}
}
}

public class MyHistoricSeries
{
int myCounter;
// Evaluate testSeries
public int Counter (Series<int>mySeries)
{
if (mySeries[0] > mySeries[1]) myCounter++;
return myCounter;
}
}

The testSeries is passed to the Counter method and returns the evaluation.
But I want the methodCounter to cumulate!

Is that basically possible or what other solution is there for my problem?

Many thanks for the support!

Try using ++myCounter instead of myCounter++

[NinjaTrader_ChrisL]

Hi user10, thanks for your note.

It's not incrementing because you're initializing the counter class withing OnBarUpdate, so it is deleted when OBU is finished calling. Place this at the class level (the one that inherits the Indicator class) and it will work properly.

Best regards.

[user10]

Hi user10, thanks for your note.

It's not incrementing because you're initializing the counter class withing OnBarUpdate, so it is deleted when OBU is finished calling. Place this at the class level (the one that inherits the Indicator class) and it will work properly.

Best regards.

Thank you very much!