plotting on secondary data series

[fgs092790]

hi im trying to modify this code to plot from secondary data series of (2500 volume bar type) but im having little difficulties so far i know i have to add the se secondary data series (AddDataSeries(Data.BarsPeriodType.Volume, 2500); on State.Configure but after that i need little help to know what else i have to change to make it work here is the code.


namespace NinjaTrader.NinjaScript.Indicators
{
public class TSSuperTrend : Indicator
{

//Notes: Beta5, SMMA not available, HomodyneDiscriminator not available so those choices have been commented out for now

private Series<bool> _trend;
private Series<double> _avg;
private int _length = 14;
private int _smooth = 14;
private int _thisbar = -1;
private bool _showArrows;
private bool _colorBars;
private bool _playAlert;
private bool firstArrow = true; // addded to eliminate first arrow draw which is usually on noise and distorts the autoscale
private double _th;
private double _tl = double.MaxValue;
private double _offset;
private double _multiplier = 2.618;
private Brush _barColorUp = Brushes.Blue;
private Brush _barColorDown = Brushes.Red;
private Brush _tempColor;
private Brush _prevColor;
private string _longAlert = @"C:\Program Files (x86)\NinjaTrader 8\sounds\Alert3.wav";
private string _shortAlert = @"C:\Program Files (x86)\NinjaTrader 8\sounds\Alert4.wav";
private MovingAverageType _maType = MovingAverageType.HMA;
private SuperTrendMode _smode = SuperTrendMode.ATR;

protected override void OnStateChange()
{
if (State == State.SetDefaults)
{
Description = @"TSSuperTrend Indicator developed by TradingStudies.com (Version 2.3)";
Name = "TSSuperTrend";
Calculate = Calculate.OnBarClose;
IsOverlay = true;
DisplayInDataBox = true;
DrawOnPricePanel = true;
DrawHorizontalGridLines = true;
DrawVerticalGridLines = true;
PaintPriceMarkers = true;
ScaleJustification = NinjaTrader.Gui.Chart.ScaleJustification.Right;
//Disable this property if your indicator requires custom values that cumulate with each new market data event.
//See Help Guide for additional information.
IsSuspendedWhileInactive = true;
AddPlot(new Stroke(Brushes.Green, 2), PlotStyle.Hash, "UpTrend");
AddPlot(new Stroke(Brushes.Red,2), PlotStyle.Hash, "DownTrend");

}
else if (State == State.Configure)
{
_trend = new Series<bool>(this);
_avg = new Series<double>(this);

switch (_maType)
{
case MovingAverageType.SMA:
_avg = SMA(Input, _smooth).Value;
break;
// case MovingAverageType.SMMA: // Not available at time of Beta 5
// _avg = SMMA(Input, _smooth).Value;
// break;
case MovingAverageType.TMA:
_avg = TMA(Input, _smooth).Value;
break;
case MovingAverageType.WMA:
_avg = WMA(Input, _smooth).Value;
break;
case MovingAverageType.VWMA:
_avg = VWMA(Input, _smooth).Value;
break;
case MovingAverageType.TEMA:
_avg = TEMA(Input, _smooth).Value;
break;
case MovingAverageType.HMA:
_avg = HMA(Input, _smooth).Value;
break;
case MovingAverageType.VMA:
_avg = VMA(Input, _smooth, _smooth).Value;
break;
default:
_avg = EMA(Input, _smooth).Value;
break;
}
}
}

protected override void OnBarUpdate()
{
if (CurrentBar < 1)
{
_trend[0] = true;
UpTrend[0] = Input[0];
DownTrend[0]= Input[0];
return;
}

switch (_smode)
{
case SuperTrendMode.ATR:
_offset = ATR(_length)[0] * Multiplier;
break;
// case SuperTrendMode.Adaptive:
// _offset = ATR(_length)[0] * HomodyneDiscriminator(Input)[0] / 10; // Not available at time of Beta 5
// break;
default:
_offset = Dtt(_length, Multiplier);
break;
}

if (IsFirstTickOfBar)
_prevColor = _tempColor;

// _trend[0] = (Close[0] > DownTrend[1] ? true : Close[0] < UpTrend[1] ? false : _trend[1]); - NT7 code note dataseries in Nt7 automatically contained close[0] values.

if (UpTrend[1] > 0.0) // Note in NT8 dataseries by default will hold 0, not the close[0] value.
{
_trend[0] = (Close[0] < UpTrend[1] ? false : _trend[1]);
}
else
_trend[0] = (Close[0] > DownTrend[1] ? true : false);


if (_trend[0] && !_trend[1])
{
_th = High[0];
UpTrend[0] = Math.Max(_avg[0] - _offset, _tl);
if (Plots[0].PlotStyle == PlotStyle.Line) UpTrend[1] = DownTrend[1];
_tempColor = _barColorUp;
if (ShowArrows && !firstArrow)
Draw.ArrowUp(this, CurrentBar.ToString(), true, 0, UpTrend[0] - TickSize, _barColorUp);
else firstArrow = false; // Don't draw the very first arrow as it will be near the zero line.

if(PlayAlert && _thisbar != CurrentBar)
{
_thisbar = CurrentBar;
PlaySound(_longAlert);
}
}
else
if (!_trend[0] && _trend[1])
{
_tl = Low[0];
DownTrend[0] = Math.Min(_avg[0] + _offset, _th);
if (Plots[1].PlotStyle == PlotStyle.Line) DownTrend[1] = UpTrend[1];
_tempColor = _barColorDown;
if (ShowArrows && !firstArrow)
Draw.ArrowDown(this, CurrentBar.ToString(), true, 0, DownTrend[0] + TickSize, _barColorDown);
else firstArrow = false; // Don't draw the very first arrow as it will be near the zero line.

if (PlayAlert && _thisbar != CurrentBar)
{
_thisbar = CurrentBar;
PlaySound(_shortAlert);
}
}
else
{
if (_trend[0])
{
UpTrend[0] = ((_avg[0] - _offset) > UpTrend[1] ? (_avg[0] - _offset) : UpTrend[1]);
_th = Math.Max(_th, High[0]);
}
else
{
DownTrend[0] = ((_avg[0] + _offset) < DownTrend[1] ? (_avg[0] + _offset) : DownTrend[1]);
_tl = Math.Min(_tl, Low[0]);
}
RemoveDrawObject(CurrentBar.ToString());
_tempColor = _prevColor;
}

if (!_colorBars)
return;

CandleOutlineBrush = _tempColor;

BarBrush = Open[0] < Close[0] ? Brushes.Transparent : _tempColor;

} // end protected override void OnBarUpdate()

private double Dtt(int nDay, double mult)
{
double hh = MAX(High, nDay)[0];
double hc = MAX(Close, nDay)[0];
double ll = MIN(Low, nDay)[0];
double lc = MIN(Close, nDay)[0];
return mult * Math.Max((hh - lc), (hc - ll));
}

region Properties
[NinjaScriptProperty]
[Display(Name="SuperTrend Mode", Description="", Order=1, GroupName="Parameters")]
public SuperTrendMode Smode
{
get {return _smode;}
set {_smode = value;}
}


[Range(1, int.MaxValue)]
[NinjaScriptProperty]
[Display(Name="Period", Description="ATR/DT Period", Order=2, GroupName="Parameters")]
public int Length
{
get {return _length;}
set {_length = value;}
}

[Range(0.0001, double.MaxValue)]
[NinjaScriptProperty]
[Display(Name="Multiplier", Description="ATR Multiplier", Order=3, GroupName="Parameters")]
public double Multiplier
{
get {return _multiplier;}
set {_multiplier = value;}
}
[NinjaScriptProperty]
[Display(Name="Moving Avg. Type", Description="", Order=4, GroupName="Parameters")]
public MovingAverageType MaType
{
get {return _maType;}
set {_maType = value;}
}


[Range(1, int.MaxValue)]
[NinjaScriptProperty]
[Display(Name="Smooth", Description="Smoothing Period", Order=5, GroupName="Parameters")]
public int Smooth
{
get {return _smooth;}
set {_smooth = value;}
}

[NinjaScriptProperty]
[Display(Name="ShowArrows", Description="Show Arrows when Trendline is violated?", Order=6, GroupName="Visual")]
public bool ShowArrows
{
get {return _showArrows ;}
set {_showArrows = value;}
}

[NinjaScriptProperty]
[Display(Name="ColorBars", Description="Color the bars in the direction of the trend?", Order=7, GroupName="Visual")]
public bool ColorBars
{
get {return _colorBars;}
set {_colorBars = value;}
}

[XmlIgnore]
[Display(Name="BarColorUp", Description="Color of up bars", Order=8, GroupName="Visual")]
public Brush BarColorUp
{
get {return _barColorUp;}
set {_barColorUp = value;}
}

[Browsable(false)]
public string BarColorUpSerializable
{
get { return Serialize.BrushToString(_barColorUp); }
set {_barColorUp = Serialize.StringToBrush(value); }
}

[XmlIgnore]
[Display(Name="BarColorDown", Description="Color of down bars", Order=9, GroupName="Visual")]
public Brush BarColorDown
{
get {return _barColorDown;}
set {_barColorDown = value;}
}
[Browsable(false)]
public string BarColorDownSerializable
{
get { return Serialize.BrushToString(_barColorDown); }
set { _barColorDown = Serialize.StringToBrush(value); }
}

[NinjaScriptProperty]
[Display(Name="PlayAlert", Description="Play alert sounds", Order=8, GroupName="Visual")]
public bool PlayAlert
{
get {return _playAlert;}
set {_playAlert = value;}
}

[Browsable(false)]
[XmlIgnore]
public Series<double> UpTrend
{
get
{return Values[0];}
}

[Browsable(false)]
[XmlIgnore]
public Series<double> DownTrend
{
get
{return Values[1];}
}
#endregion

}
}


public enum SuperTrendMode
{
ATR,
// DualThrust, - not available at time of beta 5
Adaptive
}

public enum MovingAverageType
{
SMA,
//SMMA, - Not available at time of beta 5
TMA,
WMA,
VWMA,
TEMA,
HMA,
EMA,
VMA
}

[NinjaTrader_ChelseaB]

Hello fgs092790,

Below is a link to an example of plotting information from a different time frame you may find helpful.

https://ninjatrader.com/support/forum/forum/ninjatrader-8/indicator-development/105828-indicator-accessing-multiple-time-frame?p=820196#post820196

As a tip for the future, to export a NinjaTrader 8 NinjaScript so this can be shared and imported by the recipient do the following:

1. Click Tools -> Export -> NinjaScript Add-on...
2. Click the 'add' link -> check the box(es) for the script(s) and reference(s) you want to include
3. Click the 'Export' button
4. Enter the script name in the value for 'File name:'
5. Choose a save location -> click Save
6. Click OK to clear the export location message

By default your exported file will be in the following location:

• (My) Documents/NinjaTrader 8/bin/Custom/ExportNinjaScript/<export_file_name.zip>

Below is a link to the help guide on Exporting NinjaScripts.

http://ninjatrader.com/support/helpGuides/nt8/export.htm

To understand the behavior, start by identifying the specific issue and expected behavior.

To understand why the script is behaving as it is, such as placing orders or not placing orders or drawing objects or setting plot values when expected, it is necessary to add prints to the script that print the values used for the logic of the script to understand how the script is evaluating.

In the strategy add prints (outside of any conditions) that print the date time of the bar and all values compared in every condition that triggers the action.
The prints should include the time of the bar and should print all values from all variables and all hard coded values in all conditions that must evaluate as true for this action to be triggered. It is very important to include a text label for each value and for each comparison operator in the print to understand what is being compared in the condition sets.
The debugging print output should clearly show what the condition is, what time the conditions are being compared, all values being compared, and how they are being compared.

Prints will appear in the NinjaScript Output window (New > NinjaScript Output window).

I am happy to assist you with analyzing the output from the output window.

Run or backtest the script and when the output from the output window appears save this by right-clicking the output window and selecting Save As... -> give the output file a name and save -> then attach the output text file to your reply.

Below is a link to a support article that demonstrates using informative prints to understand behavior and includes a link to a video recorded using the Strategy Builder to add prints.

https://support.ninjatrader.com/s/article/Developer-Guide-Debugging-using-Print-and-TraceOrders

Let me know the date and time the behavior occurred or when you are expecting the behavior to occur.

Please let me know if I may further assist with analyzing the output or if you need any assistance creating a print.