Parameter ordering

[Philippe56140]

Hi

I noticed that, event if you order your parameters correctly in the properties section, they are not in the attended order when the label display on the panel.
Lets consider this declaration:

        #region Properties
        [Range(1, int.MaxValue), NinjaScriptProperty]
        [Display(ResourceType = typeof(Custom.Resource), Name = "Min Period", GroupName = "NinjaScriptParameters", Order = 0)]
        public int MinPeriod
        { get; set; }

        [Range(1, int.MaxValue), NinjaScriptProperty]
        [Display(ResourceType = typeof(Custom.Resource), Name = "Middle Period", GroupName = "NinjaScriptParameters", Order = 1)]
        public int MiddlePeriod
        { get; set; }

        [Range(1, int.MaxValue), NinjaScriptProperty]
        [Display(ResourceType = typeof(Custom.Resource), Name = "Max Period", GroupName = "NinjaScriptParameters", Order = 2)]
        public int MaxPeriod
        { get; set; }

        [Range(1, int.MaxValue), NinjaScriptProperty]
        [Display(ResourceType = typeof(Custom.Resource), Name = "EMA Period", GroupName = "NinjaScriptParameters", Order = 3)]
        public int PeriodEMA
        { get; set; }
        #endregion
​

In the OnStateChange section:

                MinPeriod            = 13;
                MiddlePeriod        = 21;
                MaxPeriod            = 34;
                
                PeriodEMA            = 3;
​

Here is the result:




Did I miss something ?

[ninZa]

Hi Philippe56140,

We notice that the parameters are sorted in alphabetical order. You can rename the parameters to sort them in the desired order.

Regards,
William

[NinjaTrader_Gaby]

Hello Philippe56140,

ninZa is correct. The ordering for parameters in the Chart label is alphabetical.

[Philippe56140]

I followed your advise, renaming the indicators properties name:

        [Range(1, int.MaxValue), NinjaScriptProperty]
        [Display(ResourceType = typeof(Custom.Resource), Name = "1.Min Period", GroupName = "NinjaScriptParameters", Order = 0)]
        public int MinPeriod
        { get; set; }

        [Range(1, int.MaxValue), NinjaScriptProperty]
        [Display(ResourceType = typeof(Custom.Resource), Name = "2.Middle Period", GroupName = "NinjaScriptParameters", Order = 1)]
        public int MiddlePeriod
        { get; set; }

        [Range(1, int.MaxValue), NinjaScriptProperty]
        [Display(ResourceType = typeof(Custom.Resource), Name = "3.Max Period", GroupName = "NinjaScriptParameters", Order = 2)]
        public int MaxPeriod
        { get; set; }
​

Everything is initialized in the State == State.SetDefaults section:

                MinPeriod            = 13;
                MiddlePeriod        = 21;
                MaxPeriod            = 34;
                
​

However, the displayed ordre is still incorrect:

[ninZa]

Hi Philippe56140,

Please refer to the code below:

#region Properties
[Range(1, int.MaxValue), NinjaScriptProperty]
[Display(ResourceType = typeof(Custom.Resource), Name = "Min Period", GroupName = "NinjaScriptParameters", Order = 0)]
public int Property1_MinPeriod { get; set; }

[Range(1, int.MaxValue), NinjaScriptProperty]
[Display(ResourceType = typeof(Custom.Resource), Name = "Middle Period", GroupName = "NinjaScriptParameters", Order = 1)]
public int Property2_MiddlePeriod { get; set; }

[Range(1, int.MaxValue), NinjaScriptProperty]
[Display(ResourceType = typeof(Custom.Resource), Name = "Max Period", GroupName = "NinjaScriptParameters", Order = 2)]
public int Property3_MaxPeriod { get; set; }

[Range(1, int.MaxValue), NinjaScriptProperty]
[Display(ResourceType = typeof(Custom.Resource), Name = "EMA Period", GroupName = "NinjaScriptParameters", Order = 3)]
public int Property4_PeriodEMA { get; set; }
#endregion


protected override void OnStateChange() {
    if (State == State.SetDefaults) {
        Description = @"Enter the description for your new custom Indicator here.";
        Name = "MyCustomIndicator11111";
        Calculate = Calculate.OnBarClose;
        IsOverlay = false;
        DisplayInDataBox = true;
        DrawOnPricePanel = true;
        DrawHorizontalGridLines = true;
        DrawVerticalGridLines = true;
        PaintPriceMarkers = true;
        ScaleJustification = NinjaTrader.Gui.Chart.ScaleJustification.Right;
        //Disable this property if your indicator requires custom values that cumulate with each new market data event.
        //See Help Guide for additional information.
        IsSuspendedWhileInactive = true;

        Property1_MinPeriod = 13;
        Property2_MiddlePeriod = 21;
        Property3_MaxPeriod = 34;

        Property4_PeriodEMA = 3;
    }
}

Regards,
William