Filling a space between two sma with color

[ryju81]

Hello. I need help with indicator written by chatgpt.
Thera are two sma's, high and low. I want the space between thems to be filled with color.
Unfortunatelly this functionality doesn't work.
I am not a programmer, I would be gratefull if someone could fix this code.

#region Using declarations
using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.ComponentModel.DataAnnotations;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows;
using System.Windows.Input;
using System.Windows.Media;
using System.Xml.Serialization;
using NinjaTrader.Cbi;
using NinjaTrader.Gui;
using NinjaTrader.Gui.Chart;
using NinjaTrader.Gui.SuperDom;
using NinjaTrader.Gui.Tools;
using NinjaTrader.Data;
using NinjaTrader.NinjaScript;
using NinjaTrader.Core.FloatingPoint;
using NinjaTrader.NinjaScript.DrawingTools;
#endregion

namespace NinjaTrader.NinjaScript.Indicators
{
    public class TwoSmaHighLowIndicator : Indicator
    {
        private SMA smaHigh;
        private SMA smaLow;

        [NinjaScriptProperty]
        [Range(1, int.MaxValue)]
        [Display(Name="SMA Period for High", Order=1, GroupName="Parameters")]
        public int PeriodHigh { get; set; }

        [NinjaScriptProperty]
        [Range(1, int.MaxValue)]
        [Display(Name="SMA Period for Low", Order=2, GroupName="Parameters")]
        public int PeriodLow { get; set; }

        [XmlIgnore]
        [Display(Name="Fill Color", Order=3, GroupName="Parameters")]
        public Brush FillColor { get; set; }

        [Browsable(false)]
        public string FillColorSerializable
        {
            get { return Serialize.BrushToString(FillColor); }
            set { FillColor = Serialize.StringToBrush(value); }
        }

        protected override void OnStateChange()
        {
            if (State == State.SetDefaults)
            {
                Description = @"Indicator drawing two SMA moving averages based on High and Low prices and filling the area between them with a color.";
                Name = "TwoSmaHighLowIndicator";
                Calculate = Calculate.OnEachTick;  // Ensure the indicator works on each tick
                IsOverlay = true;
                
                // Default periods for SMA
                PeriodHigh = 14;
                PeriodLow = 14;

                // Default fill color
                FillColor = Brushes.LightBlue;

                // Adding plot lines
                AddPlot(Brushes.Blue, "SMA High");
                AddPlot(Brushes.Red, "SMA Low");
            }
            else if (State == State.DataLoaded)
            {
                smaHigh = SMA(High, PeriodHigh);
                smaLow = SMA(Low, PeriodLow);
            }
        }

        protected override void OnBarUpdate()
        {
            // Ensure there are enough bars for calculations
            if (CurrentBar < Math.Max(PeriodHigh, PeriodLow))
                return;

            // Setting values for SMA
            Values[0][0] = smaHigh[0];
            Values[1][0] = smaLow[0];

            // Filling the area between SMAs
            // Drawing the area from the previous bar to the current one
            Draw.Region(this, "Region" + CurrentBar, CurrentBar - 1, CurrentBar, smaHigh, smaLow, FillColor, FillColor, 0);
        }

        #region Properties
        [Browsable(false)]
        [XmlIgnore]
        public Series<double> SmaHigh
        {
            get { return Values[0]; }
        }

        [Browsable(false)]
        [XmlIgnore]
        public Series<double> SmaLow
        {
            get { return Values[1]; }
        }
        #endregion
    }
}

[NinjaTrader_Gaby]

Hello ryju81,

Thank you for your post.

Here are some existing indicators on the forum which use Draw.Region():

https://ninjatraderecosystem.com/user-app-share-download/new-version-using-multiple-moving-average-to-find-the-region/

https://ninjatraderecosystem.com/user-app-share-download/keltner-channel-with-color/

To understand why the script is behaving as it is, such as placing orders or not placing orders or drawing objects when expected, it is necessary to add prints to the script that print the values used for the logic of the script to understand how the script is evaluating.

In the strategy add prints (outside of any conditions) that print the date time of the bar and all values compared in every condition that places an order.

The prints should include the time of the bar and should print all values from all variables and all hard coded values in all conditions that must evaluate as true for this action to be triggered. It is very important to include a text label for each value and for each comparison operator in the print to understand what is being compared in the condition sets.

The debugging print output should clearly show what the condition is, what time the conditions are being compared, all values being compared, and how they are being compared.

Prints will appear in the NinjaScript Output window (New > NinjaScript Output window).

I am happy to assist you with analyzing the output from the output window.

Run or backtest the script and when the output from the output window appears save this by right-clicking the output window and selecting Save As... -> give the output file a name and save -> then attach the output text file to your reply.


Below is a link to a support article that demonstrates using informative prints to understand behavior and includes a link to a video recorded using the Strategy Builder to add prints.

https://support.ninjatrader.com/s/article/Developer-Guide-Debugging-using-Print-and-TraceOrders

If you are not wanting to create or debug your script yourself with our guidance through email, you can also contact a professional NinjaScript Consultant who would be eager to create or modify this script at your request or assist you with your script. The NinjaTrader Ecosystem has affiliate contacts who provide educational as well as consulting services. Please let me know if you would like our NinjaTrader Ecosystem team follow up with you with a list of affiliate consultants who would be happy to create this script or any others at your request.

The NinjaTrader Ecosystem website is for educational and informational purposes only and should not be considered a solicitation to buy or sell a futures contract or make any other type of investment decision. The companies and services listed on this website are not to be considered a recommendation and it is the reader's responsibility to evaluate any product, service, or company. NinjaTrader Ecosystem, LLC is not responsible for the accuracy or content of any product, service or company linked to on this website.

Let me know if I may be of further assistance.

[ryju81]

Thank Yiou Gaby V!