getting max & min price of chart in OnRender

[tidicofx]

I need a simple code that I can get max and min price of chart at each moment
I have tried this but min price is showing as negative number,

        protected override void OnRender(ChartControl chartControl, ChartScale chartScale)
        {
            double maxPrice=ChartPanel.MaxValue;
            double minPrice=ChartPanel.MinValue;//chartScale.MinValue;
            Draw.TextFixed(this, "Test", minPrice.ToString()+", "+maxPrice.ToString(), TextPosition.TopLeft);
        }
​

I also tried chartScale.MinValue but it is not getting what I need
this should be quite simple, not sure what is wrong!
ChartPanel.MaxValue shows correct number but ChartPanel.MinValue returns -0.015!

[NinjaTrader_Gaby]

Hello tidicofx,

Thank you for your post.

ChartPanel.MinValue indicates the minimum Y value of objects within the chart panel, based on the current y-axis scale. The scale of the y-axis is dependent upon the values of objects in the panel which have Auto Scale enabled.

https://ninjatrader.com/support/helpguides/nt8/minvalue_chartpanel.htm

So any objects on the chart which have auto scale enabled can be included.

To only work with the bars on the chart, you would need to use OnRender() and loop through the bars.

To loop you could access ChartBars.FromIndex and ChartBars.ToIndex.

https://ninjatrader.com/support/helpGuides/nt8/chartbars_fromindex.htm

https://ninjatrader.com/support/helpGuides/nt8/chartbars_toindex.htm

To get the high of bar use: https://ninjatrader.com/support/help...8/?gethigh.htm
To get the low of a bar use: https://ninjatrader.com/support/help...t8/?getlow.htm

Both Help Guide pages above show a code sample looping through the bars.

Please let us know if you have any further questions.

[tidicofx]

Hello
thank you for your reply
actually my goal is to achieve highest/lowest visible price on chart, I dont look for bars highest/lowest price or objects lowest/highest price, normally I expect this to be achievable easily
based on your comments ChartPanel.MaxValue/MinValue is not what I am looking for even that they dont work correctly as you explained, I have no object on chart so why MinValue is a negative number, anyway I dont need them because they seems to have different usage
there is also chartScale.MinValue, chartScale.MaxValue, they are also returning different numbers that I dont understand
I attach a full screenshot of chart for both values ChartPanel, chartScale
left side is ChartPanel.MaxValue, MinValue
right side is chartScale.MaxValue, MinValue

[tidicofx]

to explain more, for x scale that is time, i can easily get first (left) and last (right) visible time using code like this : DateTime dtEnd=chartControl.GetTimeByX(chartWidth);
i think there should be similar function that give me values on Y scale

[NinjaTrader_Gaby]

Hello tidicofx,

You can loop through the ChartBars.FromIndex and ChartBars.ToIndex and find the lowest and highest visible price on the chart. Save the high price and low price to a variable that you can compare the .GetHigh() and .GetLow() of each bar to. For example,

double highPrice = 0;
double lowPrice = 0;;

for(int barIndex = ChartBars.FromIndex; barIndex <= ChartBars.ToIndex; barIndex++)
{ 
if(Bars.GetHigh(barIndex) > highPrice)
highPrice = Bars.GetHigh(barIndex);

if(Bars.GetLow(barIndex) < lowPrice)
lowPrice = Bars.GetLow(barIndex);

}​

Please let me know if this does not lead you in the right direction.

[tidicofx]

Hello tidicofx,

You can loop through the ChartBars.FromIndex and ChartBars.ToIndex and find the lowest and highest visible price on the chart. Save the high price and low price to a variable that you can compare the .GetHigh() and .GetLow() of each bar to. For example,

double highPrice = 0;
double lowPrice = 0;;

for(int barIndex = ChartBars.FromIndex; barIndex <= ChartBars.ToIndex; barIndex++)
{
if(Bars.GetHigh(barIndex) > highPrice)
highPrice = Bars.GetHigh(barIndex);

if(Bars.GetLow(barIndex) < lowPrice)
lowPrice = Bars.GetLow(barIndex);

}​

Please let me know if this does not lead you in the right direction.

Hello, thank you for your reply
I think I clearly said I don't look for highest/lowest of candles visible on chart
and if you look at screenshot I have sent, it clearly shows how much difference is between chart max/min price and candles highest/lowest prices
thanks

[NinjaTrader_Gaby]

Hello tidicofx,

Your previous reply stated:

my goal is to achieve highest/lowest visible price on chart

Which is what the code snippet I shared will achieve. It will loop through all the visible bars on the chart, and save the highPrice and lowPrice to a variable. This variable is compared to the high and low price of every single bar, if the current bar being compared has a lower or higher price, it will be saved to the highPrice or lowPrice variable. After looping through all the visible bars on the chart, highPrice will have saved the highest price visible on the chart and lowPrice will have saved the lowest price visible on the chart.

If this isn't what you are looking for, could you please explain with more detail what values on the chart you are actually looking for?

[tidicofx]

Hello tidicofx,

Your previous reply stated:



Which is what the code snippet I shared will achieve. It will loop through all the visible bars on the chart, and save the highPrice and lowPrice to a variable. This variable is compared to the high and low price of every single bar, if the current bar being compared has a lower or higher price, it will be saved to the highPrice or lowPrice variable. After looping through all the visible bars on the chart, highPrice will have saved the highest price visible on the chart and lowPrice will have saved the lowest price visible on the chart.

If this isn't what you are looking for, could you please explain with more detail what values on the chart you are actually looking for?

I think you should read my post completely, you quote a part of it and ignore following hints



I clearly stated, I dont look for bars highest/lowest price or objects lowest/highest price
I am talking about chart highest/lowest price not candles highest/lowest

[tidicofx]

image below shows chart price is from18430 to 18100, but visible candles highest/lowest is 18380 to 18150 (not accurately but estimated)
i am looking for 18430, 18100 numbers

[NinjaTrader_Gaby]

Hello tidicofx,

Thank you for your clarification!

I understand now that you are looking for the highest and lowest values displayed in the chart scale.

To get this, you can use ChartScale.MinValue and ChartScale.MaxValue. However, these will return the absolute rendered MinValue and MaxValue on the chart scale - including pixels above or below the text.

The Help Guide pages below demonstrate with pictures:

https://ninjatrader.com/support/helpGuides/nt8/chartscale_minvalue.htm

https://ninjatrader.com/support/helpGuides/nt8/chartscale_maxvalue.htm

You could round the numbers using C# methods like Math.Round or Math.Floor.

https://learn.microsoft.com/en-us/dotnet/api/system.math.round?view=net-8.0

https://learn.microsoft.com/en-us/dotnet/api/system.math.floor?view=net-8.0

Please let me know if I can assist further.

[tidicofx]

Hello tidicofx,

Thank you for your clarification!

I understand now that you are looking for the highest and lowest values displayed in the chart scale.

To get this, you can use ChartScale.MinValue and ChartScale.MaxValue. However, these will return the absolute rendered MinValue and MaxValue on the chart scale - including pixels above or below the text.

The Help Guide pages below demonstrate with pictures:

https://ninjatrader.com/support/helpGuides/nt8/chartscale_minvalue.htm

https://ninjatrader.com/support/helpGuides/nt8/chartscale_maxvalue.htm

You could round the numbers using C# methods like Math.Round or Math.Floor.

https://learn.microsoft.com/en-us/dotnet/api/system.math.round?view=net-8.0

https://learn.microsoft.com/en-us/dotnet/api/system.math.floor?view=net-8.0

Please let me know if I can assist further.

Thank you for follow up
as I stated earlier, I also tried chartScale.MinValue, MaxValue
and as you can see on screenshot those values are printed on chart top right
I am getting -0.015, 0.265
and this is code I have tried

        protected override void OnRender(ChartControl chartControl, ChartScale chartScale)
        {
​                Draw.TextFixed(this, "Test2", barsToCount.ToString()+", "+chartScale.MinValue.ToString()+", "+chartScale.MaxValue.ToString(), TextPosition.TopRight);
        }

​

what I am doing wrong?
my indicator has IsOverLay property set to true

[NinjaTrader_Gaby]

Hello,

Please see the attached sample script which demonstrates. This will display the minValue and maxValue of the chart scale on the chart.

If you have any further questions, please let me know.

[tidicofx]

Hello,

Please see the attached sample script which demonstrates. This will display the minValue and maxValue of the chart scale on the chart.

If you have any further questions, please let me know.

thank you for your time
I deleted old indicator, created new one and used same code I have tried before and it works, not sure what going wrong with old file
thank you