Trying to add RSI as a divergence indicator to PAS

[notenufftime]

Hi everyone.

I've been trying to learn coding in Ninjascript and suffering silently for quite a while now. Honestly, I usually have simply given up by this time and resolve to use things that already work.

I do keep seeing the same errors over and over in my coding though and will now endeavor to defeat this one most common for me.

In this case, I am editing PriceActionSwing Indicator by Dorschen, trying to add other indicators (RSI in this case) to display divergence. It seems a simple enough process, having used the included MACD and Stochastics as a reference. I had a few naming errors and have worked those out but am left with two instances of:

'NinjaTrader.NinjaScript.Indicators.PriceActionSwi ng.DivergenceMode' does not contain a definition for 'Rsi'

I am in your hands if anyone dares to help me resolve a constant thorn in my coding and set me on a higher path.

[Leeroy_Jenkins]

I checked PAS code, DivergenceMode is enum and it actually doesn't have RSI. Just look for "public enum DivergenceMode" and add RSI at the end.

[notenufftime]

Hi Leeroy, thanks for your effort and response. I know it doesn't have RSI, it doesn't have a lot of things but apparently, it's supposed to be easy to add them as a source. I added RSI in exactly the same way and places that MACD and Stochastics are already in place, but I still can't compile because of that definition error.
Did you try adding it?

[Leeroy_Jenkins]

Did you add RSI in DivergenceMode enum? This enum resided in PriceActionSwing file, not in PriceActionSwingPro you're trying to modify. This causes that error.

[NinjaTrader_BrandonH]

Hello notenufftime,

Thanks for your notes.

Leeroy_Jenkins has provided some great information on this topic that you could look into.

If DivergenceMode is an enum as Leeroy_Jenkins noted, you would have to add the RSI to the DivergenceMode enum so that it is available to access from the enum.

Something you could consider is reaching out to the developer of the indicator directly to ask for information on how to go about adding more indicators to the third-party script.

[notenufftime]

Did you add RSI in DivergenceMode enum? This enum resided in PriceActionSwing file, not in PriceActionSwingPro you're trying to modify. This causes that error.

Ok I did mention that I am new to coding so I'll beg your patience from the onset. I am editing PriceActionSwingPro from Ninja Editor. Where do I find PriceActionSwing file and with what do I edit it?

[notenufftime]

Hello notenufftime,

Thanks for your notes.

Leeroy_Jenkins has provided some great information on this topic that you could look into.

If DivergenceMode is an enum as Leeroy_Jenkins noted, you would have to add the RSI to the DivergenceMode enum so that it is available to access from the enum.

Something you could consider is reaching out to the developer of the indicator directly to ask for information on how to go about adding more indicators to the third-party script.

Hi Brandon and thank you for your input.

I did reach out to the originator long ago but he's very quiet. This indicator is more than 10 years old now but has a fabulous base for things I want to try.

Where and what is the DivergenceMode enum and how should I edit it? Not within PriceActionSwingBase or PriceActionSwingPro, I've searched.

[notenufftime]

Oh wait...I've found someting... 'public enum DivergenceMode { Off, MACD, Stochastics, }' in PriceActionSwingBase. I'll do some editing, thank you

[notenufftime]

Well there you go, works like a charm now.

It makes me wonder:
Is it typical to have a reference call to another file?
Why not simply have it within the file you are working with?

I've no doubt I'll be back for more tutelage, RSI wasn't really what I wanted to add but it seemed most basic. At least I have some ammo now.

Thank you Leeroy and Brandon

[NinjaTrader_BrandonH]

Hello notenufftime,

Thanks for your notes.

Depending on the logic of a script and how the programmer wants it to function, it could be common to have a reference call to another file.

For example, if you have a script that has public methods that are used by multiple scripts, those public methods would be placed in a separate file for individual scripts to access.

[notenufftime]

Understood and I'll bear that in mind. It's like learning an entirely new language.

[Leeroy_Jenkins]

I would recommend you install Visual Studio because editing in the NT Editor is kinda cumbersome. In Visual Studio, you can simply right click on "DivergenceMode" and select "go to definition" to quickly navigate to where this enum is defined. It's much easier to deal with all these dependencies Not to mention all other stuff that VS has but not NT Editor.

[notenufftime]

I appreciate the advice, I have VS installed and have toyed with it on occasion. I've stuck with NT editor because its native, so I assumed fewer problems. I'm a rank amateur with great aspirations though so I will try VS and see how it goes for me. Thank you Leeroy.