Need help with the Draw.Line & Draw.Rectangle commands

[Luckychip]

Hi All,

I have put together some thing that highlights the first 3 hours of Asia, London and New York sessions. So in between those designated times a rectangle is drawn using the highest price and lowest price.

As someone completely new to this I looked at the open range indicator provided by Ninja trader as a template and then used draw. Rectangle to shade the area to visually stand out. So after working out various problems regarding the tag name and getting this to work I am stumped by something I cant make sense of.

This problem seems to be with both the draw. Line and rectangle command. The main function itself works but for each session I have an extra rectangle above and below the main area that's highlighted with the price and for the New York session, there is an overlap. How can I get rid of the extras?

Anyone able to point me in the right direction?

Thanks in advance
Doug

[NinjaTrader_BrandonH]

Hello Luckychip,

Thanks for your post.

To understand exactly how your logic is behaving, such as drawing objects that are unexpected on the chart, you would need to add debugging prints to the indicator script that prints out the values being used for your Draw methods.

One line above the Draw method where you are drawing that rectangle on the chart, add prints that print out the startY and endY values being passed in for the rectangle, the Time[0], the Tag name, and the CurrentBar to see how your logic is evaluating.

Once you understand how those rectangles are being drawn, you could modify your script accordingly to suit your overall goal.

Below is a link to a forum post that demonstrates how to use prints to understand behavior.
https://ninjatrader.com/support/foru...121#post791121

[Luckychip]

Hi Brandon,

Thanks for your reply. I will take a look, and hopefully see what's wrong.

Regards
Doug

[Luckychip]

Hi Brandon,

Just an update, the problem had nothing to do with the commands but with the starting and closing time parameters.
The following code was missing for the times.

dtStartTime = new DateTime (dt.Year, dt.Month, dt.Day, dtStartTime.Hour, dtStartTime.Minute, dtStartTime.Second);
dtEndTime = new DateTime (dt.Year, dt.Month, dt.Day, dtEndTime.Hour, dtEndTime.Minute, dtEndTime.Second);

As soon as that was changed the extra rectangles disappeared, so thank you for the help

Regards
Doug