Help with chart trader and button

[tkaboris]

Hi i have the following code and need to make sure correct fib gets drawn. It shows correct fib for long but it doesnt show for fib short. Only drawing fiblong. What am i doing wrong?

fibLong
remove fib
fibLong
remove fib

protected void Button13Click(object sender, RoutedEventArgs e) // Fib show
        {
            fibpressed = !fibpressed;
            if (fibpressed){
                if(llPriceLevel < hhPriceLevel)
                    {
                        Print("fibLong");
                        TriggerCustomEvent(o =>
                        {
                         Draw.FibonacciRetracements(this, "fibLong", true, CurrentBar-llDrawnbar, llPriceLevel , CurrentBar-hhDrawnbar, hhPriceLevel);
                       }, null);
                    }


//                    else
//                    {
//                    Print("remove fib");
//                    RemoveDrawObject("fibLong");

//                    }
            }

            if (fibpressed){
                if(llPriceLevel > hhPriceLevel)
                    {
                        Print("fibShort");
                        TriggerCustomEvent(o =>
                        {
                         Draw.FibonacciRetracements(this, "fibShort", true, CurrentBar-hhDrawnbar, hhPriceLevel , CurrentBar-llDrawnbar, llPriceLevel);
                       }, null);
                    }



            }
            else
                    {
                    Print("remove fib");
                    RemoveDrawObject("fibShort");
                        RemoveDrawObject("fibLong");

                    }

        }​​

[NinjaTrader_ChelseaB]

Hello tkaboris,

We will need output from printing the values in the conditions to understand if this is evaluating as true or false.

One line above the conditions print the values in the conditions with labels for each value and comparison operator.

https://ninjatrader.com/support/forum/forum/ninjatrader-7/strategy-development-aa/99209-date-conditions-not-working?p=791121#post791121

Save the output to a text file and include this with your next post.

[tkaboris]

fibLofibpressedTrue
llPriceLevel15402
hhPriceLevel15409.5
fibLong
fibpressed
fibLofibpressedFalse
llPriceLevel15402
hhPriceLevel15409.5
remove fib
fibLofibpressedTrue
llPriceLevel15402
hhPriceLevel15409.5
fibLong
fibpressed
fibLofibpressedFalse
llPriceLevel15402
hhPriceLevel15409.5
remove fib
fibLofibpressedTrue
llPriceLevel15402
hhPriceLevel15409.5
fibLong
fibpressed

my code for fib short is here
else if (fibpressed && hhPriceLevel > llPriceLevel){

TriggerCustomEvent(o =>
{
Draw.FibonacciRetracements(this, "fibShort", true, CurrentBar-hhDrawnbar, hhPriceLevel , CurrentBar-llDrawnbar, llPriceLevel);
}, null);

}

and before conditions
fibpressed = !fibpressed;
Print("fibLofibpressed" + fibpressed);
Print("llPriceLevel" + llPriceLevel);
Print("hhPriceLevel" + hhPriceLevel);

[NinjaTrader_ChelseaB]

Hello tkaboris,

The output appears to be showing IIPriceLevel with a value of 15402 is not greater than hhPriceLevel at 15409.5, so the condition is not evaluated as true and no action is triggered.


Note with the print, this should be informative to match the condition and include operators (so we can look at the output and see how the values are being compared).

For the conditions:
if (fibpressed){
if(llPriceLevel > hhPriceLevel)

The print should appear as:

Print(string.Format("fibpressed: {0} == true && llPriceLevel: {1} > hhPriceLevel: {2}", fibpressed, llPriceLevel, hhPriceLevel));


To save output to a text file, right-click the the NinjaScript Output window then select Save As. Then you attach the text file with your post.

[tkaboris]

hi

Its still not showing right retracement for shorts. Yellow line and blue line is 50 and 61%, so it should be on upper side of retracement

protected void Button13Click(object sender, RoutedEventArgs e) // Fib show
        {
            fibpressed = !fibpressed;
            Print(string.Format("fibpressed: {0} == true && llPriceLevel: {1} > hhPriceLevel: {2}", fibpressed, llPriceLevel, hhPriceLevel));
            if (fibpressed && llPriceLevel < hhPriceLevel){
//                if(llPriceLevel < hhPriceLevel)
//                    {
                        Print("fibLong");
                Print("fibpressed");
//                        Print("llPriceLevel" + llPriceLevel);
//                        Print("hhPriceLevel" + hhPriceLevel);
                        TriggerCustomEvent(o =>
                        {
                         Draw.FibonacciRetracements(this, "fibLong", true, CurrentBar-llDrawnbar, llPriceLevel , CurrentBar-hhDrawnbar, hhPriceLevel);
                       }, null);
//                    }


//                    else
//                    {
//                    Print("remove fib");
//                    RemoveDrawObject("fibLong");

//                    }
            }

            else if (fibpressed && hhPriceLevel > llPriceLevel){
//                if(llPriceLevel > hhPriceLevel)
//                    {
                        Print("fibShort");
                        Print("fibpressed" + fibpressed);
//                        Print("llPriceLevel" + llPriceLevel);
//                        Print("hhPriceLevel" + hhPriceLevel);
                        TriggerCustomEvent(o =>
                        {
                         Draw.FibonacciRetracements(this, "fibShort", true, CurrentBar-hhDrawnbar, hhPriceLevel , CurrentBar-llDrawnbar, llPriceLevel);
                       }, null);
//                    }



            }
            else
                    {
                    Print("remove fib");
                    RemoveDrawObject("fibShort");
                        RemoveDrawObject("fibLong");

                    }

        }

        #endregion
        ​

[NinjaTrader_ChelseaB]

Hello tkaboris,

llPriceLevel with a value of 15189.5 is less than hhPriceLevel at 15202.75.

if (fibpressed && llPriceLevel < hhPriceLevel){

This 'if' evaluated as true, so the 'else if' below will not be evaluated.

else if (fibpressed && hhPriceLevel > llPriceLevel){

This 'else if' was not evaluated as the 'if' above evaluated as true.

[tkaboris]

I don’t understand then. First condition always evaluates to true and skips second condition for short… what other condition do I need to specify?

[NinjaTrader_ChelseaB]

Hello tkaboris,

You might not be familiar with how an 'else-if' works in C# (or pretty much all programming languages).

Below is a link to an educational site.

https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/statements/selection-statements

If the 'if' part evaluates as true, the 'else' or 'else-if' are not evaluated.

Are you expecting the 'if' above to evaluate as false even though llPriceLevel is less than hhPriceLevel?

Are you expecting both conditions to be evaluated?
If so, why are you using an 'else-if' here?

[tkaboris]

i removed else if and only have if but now it draws both of fibs for long and short
I want to evaluate only one condition to true, if its long retracement or short retracement.

fibpressed: True == true && llPriceLevel: 15244.25 > hhPriceLevel: 15268
fibLong
fibpressed
fibShort
fibpressedTrue
fibpressed: False == true && llPriceLevel: 15244.25 > hhPriceLevel: 15268
remove fib

[tkaboris]

Never mind fixed it.