Indicator doesnt get saved in template

[tkaboris]

Hi i have a customm indicator that loads fine. but when i apply to template, next time i open NT indicator doesnt load and i have to reinsert indicator each time. What would cause this?
Thank you

[NinjaTrader_Emily]

Hello tkaboris,

Thank you for your post.

Is this an indicator you developed or was it imported from a third party? When you open NinjaTrader and notice that the indicator did not load, are there any error messages on the Log tab of the Control Center? If so, what do the errors report?

I look forward to your reply.

[tkaboris]

HI thank you. I had to modify third party indicator. So i guess i made a mistake during renaming something?
down there in this section?
region NinjaScript generated code. Neither change nor remove

[tkaboris]

I checked that area and indicator name was changed becacuse it was duplicate in my system.

[tkaboris]

When i changed class name i simply did find and replacec all occurences of class name...

[NinjaTrader_Emily]

Hello tkaboris,

Thank you for your reply.

I suspect that a previous version of the indicator is saved in the template rather than the updated version. Please open NinjaTrader and reinsert the indicator as you have been doing, and then re-save the template with the new instance of the indicator added. Then, as a test, shut down and relaunch NinjaTrader to see if the indicator loads in the template without any errors.

Please let me know if I may be of further assistance.

[tkaboris]

hi, no its still not saving it. i tried that many times...
When i save template and save workspace it gives error in log couldnt save indicator....


i attach indicator just in case.

[NinjaTrader_Emily]

Hello tkaboris,

Thank you for your reply.

What is the full error message in the log when you save the template and workspace related to "couldn't save indicator?" Please provide another screenshot of the message you are seeing.

I look forward to your reply.

[tkaboris]

hi here it is

[NinjaTrader_Emily]

Hello tkaboris,

Thank you for your reply.

The error "There was an error reflecting type: ____" is sometimes related to objects that are public and do not use the XmlIgnore() attribute. I see this is the case with the four public Series<FVG> cs, cr, ls, and lr. As described in this thread, you can add the XmlIgnore() attribute so that the indicator saves properly in templates and workspaces:

https://forum.ninjatrader.com/forum/ninjatrader-8/platform-technical-support-aa/1044388-error-reflecting-type-ninjatrader-ninjascript-indicators-ffd2?p=1158643#post1158643

Otherwise, you could change them to private instead of public.

I also see that you have some user defined parameter types (enums). It is a strongly suggested best practice to define the enums outside of the class in a custom namespace as demonstrated in the following sample:

https://ninjatrader.com/support/helpGuides/nt8/creating_a_user-defined_parame.htm

Please let us know if we may be of further assistance.

[tkaboris]

thanks i changed to private and now it saves.