Trying to make selected MA type a drop down instead of numeric input

[Conceptzx]

Can someone help me to make the MA type a drop down instead of Numeric input. I'm just trying to streamline the setup of this MA Envelopes indicator I modified. I have a total of 15 different MA options available to the user.

[bltdavid]

The attached .zip file is a bit useless, since it is compiled for export.

Any chance you could attach the original source?

[Conceptzx]

CS file work? Also, If you can walk me through the process, I'd really appreciate it.

I did something similar with Keltner channels but each MA type is in a different file. Came up with some interesting results by varying the time frame, type of chart, and look back period. Was hoping I could do something similar with Envelopes because they aren't so dependent on ATR calculations

[bltdavid]

Yep, that will do ...

Looks pretty straight forward

I'll modify and attach a new version

stand by

[Conceptzx]

Thank you, I think I have to work on at least 2 of the MA's yet or possibly just remove them, but it gives a variety of methods to choose from in a simple interface. Probably even some nobody's really explored before too.

[bltdavid]

Done.

I've cleaned it up a bit,
re-factored the code some.

Change 'Name' to explicitly be 'MAEnv',
that way no naming conflicts ...



See attached.

[Conceptzx]

Thanks, I'll study it and try to learn what I couldn't get right.

[bltdavid]

I write up a few paragraphs to explain/describe the
new changes, and why I made them, later in the day.

[Conceptzx]

I appreciate it, I was working with it on CodePal and kept generating errors, but was similar to what you came up with

[bltdavid]

I write up a few paragraphs to explain/describe the
new changes, and why I made them, later in the day.

Use Google to study enum statements.

As promised, here are some notes:

1. Use of My.Common namespace.
An enum declared in a separate namespace allows the identifier used
as the type name to also be used as a variable name. For ex, this may
look confusing, but you can actually do this kind of thing,

MAType MAType = MAType.EMA;

and, yes, this actually works, but only when the type MAType is defined
in a different namespace than the identifier MAType. And so, I setup the
My.Common namespace to hold the enum MAType and added the using
directive using My.Common to gain access to it. It's not a big deal, I
mean, you could use this code,

MAType maType = MAType.EMA;

and the difference in case for the variable name maType makes this kinda
moot, but I gain the ability to not care about this with this separate name
space trick. It's very common idiom in C# to see variables using the exact
same name (with same case) as the type name. For me, this duplicity, or
more correctly, this flexibility and freedom in the type vs variable naming
convention, when using sparingly and used well, can be very nice.

2. Removed class level MA typed variables.
I removed all the variables defined for each MA, and setup a C# switch
statement to access the current value of the current MA associated with
the value in the MAType property. One of the main reasons I did this in
this specific case is for simplicity, and because some of your MAs are not
included with NinjaTrader, so this switch statement allows me to comment
out just one line of code for each MA that is not available.

3. The MAType property type uses fully qualified My.Common.MAType.
This goes back to no. 1 above -- I always use the fully qualified type name
when defining a public enum property because whenever this indicator is
exported into a compiled assembly, you could have 'enum not found' issues
during the import process. I forget the exact error, but the solution is simple,
we fix these import problems by simply making the MAType public property
use the fully qualified enum type name in the public property definition.

Any questions, let me know.

[NinjaTrader_ChelseaB]

Hello Conceptzx,

There is a reference sample in the help guide on using an enum to select a moving average.

https://ninjatrader.com/support/helpGuides/nt8/creating_a_user-defined_parame.htm

There is also an indicator that utilizes this as well.

https://ninjatraderecosystem.com/user-app-share-download/macrossbuilder/