Getting Errors When Copying the MACD Indicator in NinjaScript

[trader07]

Hello,
I am attempting to make a copy of MACD indicator to edit and make changes in NinjaScript, but I am having some issues. I use the Save As feature to save and copy the original MACD under a new name, "MACD2", but the name is still seeing "MACD" in the list of indicators to add. The name of the second version doesn't update.

If I change the name to "MACD2" in the (State == State.SetDefaults), I get the error code CS0117.

What am I doing wrong? Thank you in advance for your help.

[dj22522]

After "Save As" did you F5- compile ?

[trader07]

Yes I did and still didn't work. I think it has something to do with this warning.

[dj22522]

Where you changed the name to "MACD2" in the (State == State.SetDefaults) put the name back to what it was originally, MACD.

Then change the name from MACD to MACD2 in this line of code: public class MACD2 : Indicator

Then F5 (Compile)

namespace NinjaTrader.NinjaScript.Indicators
{

public class MACD2 : Indicator
{
private Series<double> fastEma;
private Series<double> slowEma;
private double constant1;
private double constant2;
private double constant3;
private double constant4;
private double constant5;
private double constant6;

protected override void OnStateChange()
{
if (State == State.SetDefaults)
{
Description = Custom.Resource.NinjaScriptIndicatorDescriptionMAC D;
Name = Custom.Resource.NinjaScriptIndicatorNameMACD;
Fast = 12;
IsSuspendedWhileInactive = true;
Slow = 26;
Smooth = 9;

[dj22522]

I think your issue with the indicator initially not saving with your new name MACD2 is because the indicator has a lock sign on it.


Comment out these two lines using //:

//Description = Custom.Resource.NinjaScriptIndicatorDescriptionMAC D;
//Name = Custom.Resource.NinjaScriptIndicatorNameMACD;


and replace them with these:

Description = @"MACD";
Name = "MACD2";

For Name = " " you can type what ever you want between the speech marks " " and that's what you'll see in your indicator list. ie "MACD2" or "MACD_2" etc..

​public class MACD2 : Indicator
{
private Series<double> fastEma;
private Series<double> slowEma;
private double constant1;
private double constant2;
private double constant3;
private double constant4;
private double constant5;
private double constant6;

protected override void OnStateChange()
{
if (State == State.SetDefaults)
{
//Description = Custom.Resource.NinjaScriptIndicatorDescriptionMACD;
//Name = Custom.Resource.NinjaScriptIndicatorNameMACD;
Description = @"MACD";​
Name = "MACD2";

[trader07]

That worked! Thank you! I can't believe it was that simple. I appreciate your help greatly.

[dj22522]

That worked! Thank you! I can't believe it was that simple. I appreciate your help greatly.

Glad you sorted it

BTW. I posted some additions to the MACD indicator a while back if it helps with the coding for what you might try for yourself.
You can always re-name it ("Save As") now that you know how.

https://forum.ninjatrader.com/forum/...10#post1193610

Enjoy

[trader07]

Glad you sorted it

BTW. I posted some additions to the MACD indicator a while back if it helps with the coding for what you might try for yourself.
You can always re-name it ("Save As") now that you know how.

https://forum.ninjatrader.com/forum/...10#post1193610

Enjoy

Awesome! I will check it out. Thank you again

[NinjaTrader_BrandonH]

Hello trader07,

Thanks for your post.

I am happy to hear you were able to resolve the issue with the help of dj22522.

Typically, if you want to create a copy of an indicator such as the MACD indicator, you could right-click in the MACD indicator's code, select 'Save as', name the copy of the script, and then run a compile to check for errors as dj22522 mentioned.