Problem with indicator

[badbess]

Hello,

First time posting here.

I'm trying to make an indicator to calculate some levels from previous bars.

With the code :

 else if (State == State.Configure)
            {
                BarsPeriodType bpt;
                if (Enum.TryParse(timeFrame1.ToString(), out bpt))
                {
                    AddDataSeries(bpt, tfValue);
                    if (showOutput) Print("Added time series: " + bpt + " value: " + tfValue);
                }
            }
        }

        protected override void OnBarUpdate()
        {
            if (CurrentBars[0] < BarsRequiredToPlot || CurrentBars[1] < BarsRequiredToPlot)
                return;

            if (BarsInProgress == 0)
            {

                int b = (State == State.Realtime) ? 1 : 0;


                MID[0] = (Highs[1][b] + Lows[1][b])/ 2;​

I got this indicator to plot on chart.

But when i try to add more levels to plot, code compiles but doesn't plot anything on the chart:

else if (State == State.Configure)
            {
                BarsPeriodType bpt;
                if (Enum.TryParse(timeFrame1.ToString(), out bpt))
                {
                    AddDataSeries(bpt, tfValue);
                    if (showOutput) Print("Added time series: " + bpt + " value: " + tfValue);
                }
            }
        }

        protected override void OnBarUpdate()
        {
            if (CurrentBars[0] < BarsRequiredToPlot || CurrentBars[1] < BarsRequiredToPlot || CurrentBars[2] < BarsRequiredToPlot)
                return;

            if (BarsInProgress == 0)
            {

                int b = (State == State.Realtime) ? 1 : 0;


                MID[0] = (Highs[1][b] + Lows[1][b])/ 2;
                MID2[0] = (Highs[2][b] + Lows[2][b])/2;
                MID3[0] = (MID[0] + MID2[0])/2;​

I would appreciate if somebody would help/navigate where i made mistake.

Thank you.

[NinjaTrader_ChelseaB]

Hello badbess,

Welcome to the NinjaTrader forums!

We'd want to confirm a few things first.

Are these plots being set that are added with AddPlot() in State.SetDefaults?

Are MID, MID2, MID3 public series that are returning Values[0], Values[1], Values[2]?

Below is a link to a forum post with details.
https://ninjatrader.com/support/foru...er#post1182264

If you add a print one line above those assignments of the bar time, are you seeing the prints appearing in the output window?

Below is a link to a forum post on using prints to debug and understand behavior.
https://ninjatrader.com/support/foru...121#post791121

Are there errors appearing on the Log tab of the Control Center?

If you print those calculated values, do you see the correct values appearing in the output window?

[badbess]

Hello,

Thank you for tips. I had plots and public series, i have added Print function.

I got current error on output;

With code:

if (CurrentBars[0] < BarsRequiredToPlot || CurrentBars[2] < BarsRequiredToPlot)
                return;​

Error : Error on calling 'OnBarUpdate' method on bar 20: Index was outside the bounds of the array.

or

if (CurrentBars[0] < BarsRequiredToPlot || CurrentBars[1] < BarsRequiredToPlot || CurrentBars[2] < BarsRequiredToPlot)
                return;​

Error : Error on calling 'OnBarUpdate' method on bar 2077: Index was outside the bounds of the array

Still error persists.

The indicator only works with MID[0] = (Highs[1][b] + Lows[1][b])/ 2; and the following

if (CurrentBars[0] < BarsRequiredToPlot || CurrentBars[1] < BarsRequiredToPlot)
                return;​

If im referring to [2] bars ago it gets above error mentioned.

Thank you.

[NinjaTrader_ChelseaB]

Hello badbess,

CurrentBars[2] would be the 3rd data series.

The primary chart bars is CurrentBars[0]. The first added series with AddDataSeries() would be CurrentBars[1]. An additional added series would be CurrentBars[2].

May I confirm there are 2 series added with AddDataSeries()?

As a heads up, adding series dynamically is not supported.

Where you have:

if (Enum.TryParse(timeFrame1.ToString(), out bpt))
{
AddDataSeries(bpt, tfValue);​

This would be dynamically adding the series with a condition, which NinjaTrader does not support.


What is MID?
Is this an array? Is this a List? Is this a Series? Is this Values[0]?

If this is a plot, is this being set in BarsInProgress 0?