Adding a NinjaScriptProperty to a derived class

[Aviram Y]

Hello.

I have created a custom indicator derived from Bollinger, and would like to add a couple of properties to it.

I have also tried adding more series similar to Lower/Middle/Upper, but again, no luck.

The reason I've added the Bollinger's properties here as well is because I've tried a couple of things, but I'm missing a piece of understanding, so i just left the latest code.

what am i doing wrong, is there something fundamental I'm missing? please help!
An example would be a huge help if there is one.

Thanks, Aviram Y.

[HASHTAG="t3322"]region[/HASHTAG] Properties
[Browsable(false)]
[XmlIgnore()]
public Series<double> BandsWidth
{
get { return Values[5]; }
}

[Browsable(false)]
[XmlIgnore()]
public Series<double> UpperDev
{
get { return Values[4]; }
}

[Browsable(false)]
[XmlIgnore()]
public Series<double> LowerDev
{
get { return Values[3]; }
}

[Browsable(false)]
[XmlIgnore()]
public Series<double> Lower
{
get { return Values[2]; }
}

[Browsable(false)]
[XmlIgnore()]
public Series<double> Middle
{
get { return Values[1]; }
}

[Browsable(false)]
[XmlIgnore()]
public Series<double> Upper
{
get { return Values[0]; }
}

[Range(0, int.MaxValue), NinjaScriptProperty]
[Display(ResourceType = typeof(Custom.Resource), Name = "NumStdDev", GroupName = "NinjaScriptParameters", Order = 0)]
public double NumStdDev
{ get; set; }

[Range(1, int.MaxValue), NinjaScriptProperty]
[Display(ResourceType = typeof(Custom.Resource), Name = "Period", GroupName = "NinjaScriptParameters", Order = 1)]
public int Period
{ get; set; }

[NinjaScriptProperty]
[Display(Name="Direction", GroupName = "NinjaScriptParameters", Order = 2)]
public string StrategyDirection
{ get; set; }
#endregion​

[eDanny]

Did you also add plots 3, 4 and 5 in State.SetDefaults?

[Aviram Y]

I did, but I actually just solved my problem, i was so confused on why it doesn't work, the reason is because i copied the syntax from the class declaration of Bollinger directly.

because bollinger is declared like so

public class Bollinger : Indicator

I didn't realize that i need the full path of the Bollinger indicator when declaring my class so i declared it this way

public class AdaptiveBollinger : Bollinger

When i should've just input the full path to the indicator:

public class AdaptiveBollinger : NinjaTrader.NinjaScript.Indicators.Bollinger

Is there a reasoning for this? everything works fine now, but i am still a bit confused on why the Bollinger class uses Indicator as a base without any path, I'm still missing some fundamentals on classes, since i come from a game design background i do have experience but all self taught and very specific.

[Aviram Y]

Another question, when i use the AdaptiveBollinger in my strategy like so

private AdaptiveBollinger adaptiveBollinger;

adaptiveBollinger = AdaptiveBollinger(2, 20, "long");
AddChartIndicator(adaptiveBollinger);​

i use the base.OnStateChange of the Bollinger inside the OnStateChange scope of AdaptiveBollinger before if (State == State.SetDefaults) , and i do the same for the OnBarUpdate before calculating any custom logic.

        protected override void OnStateChange()
        {
            base.OnStateChange();
            if (State == State.SetDefaults)
            {
                Description                    = NinjaTrader.Custom.Resource.NinjaScriptIndicatorDescriptionBollinger;
                Name                        = "AdaptiveBollinger";
                IsOverlay                    = true;
                IsSuspendedWhileInactive    = true;
                NumStdDev                    = 2;
                Period                             = 20;​
            }
        }

but the AdaptiveBollinger is drawing the default Bollinger values on the chart (Bollinger(2,14)) and ignores the arguments i pass onto Adaptive Bollinger unless i set the NumStdDev and Period in State.Configure

            else if( State == State.Configure)
            {
                base.NumStdDev = NumStdDev;
                base.Period    = Period;
            }​

is this the right approach? am i doing something wrong?

What exactly am i supposed to do with the NumStdDev and Period? or for the sake of a better understanding, any argument that belongs to the base class when called like i mentioned above.

[NinjaTrader_ChelseaB]

Hello Aviram Y,

NinjaTrader does not support inheritance with indicators or strategies.

Unfortunately, the wrappers that create overload signatures and optimization instances cannot recognize inheritance.

This means you would need to just copy the logic from one script into another.

If you want to share methods, you can use a partial class.

https://ninjatrader.com/support/forum/forum/ninjatrader-8/indicator-development/1142334-is-it-possible-to-hide-an-indicator-from-the-list-in-the-indicator-window#post1142340

[Aviram Y]

Thanks for the clarification! very much appreciated.