Jagged array

[Stanfillirenfro]

Hello!
I am receiving the following error message:

Error on calling 'OnBarUpdate' method on bar 500: Index was outside the bounds of the array.

I have the following code:

#region Variables
 private double [][] myArray = new double[3][];  // Declaration of the jagged array
#endregion

protected override void OnBarUpdate()
{
   if(CurrentBar < 500) return;

   for(int i = 0; i < myArray.Length; i++)
   {
        for(int j = 0; j < 25; j++)
        {
            myArray[i] = new double[j];     // set size of jagged array elements
            myArray[i][j] = Close[j];            // initialize the arrays
        }
   }
}

I have a jagged array with three simple dimensional arrays. I set the length of each simple dimesional array to 25. Even considering 75 (3*25) items, I do not approch 500. Why am I receiving the above error message?

Many thanks in advance!

[NinjaTrader_Kate]

Hello Stanfillirenfro,

Thank you for your note.

This is more of a general C# question than a NinjaScript question, and somewhat out of the scope of our support, but with jagged arrays you have to specify the size of the jagged array elements and you are giving that a 0 size on the first iteration through the inner loop. I'd recommend taking a look at this publicly available page from Microsoft's help guide:

https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/arrays/jagged-arrays

Please let us know if we may be of further assistance to you.

[jeronymite]

Stanfillirenfro You may want to add some Print statements to trace the loop execution, noting the indices and bar numbers. This should at least identify the exact point in the loop where the error is occurring. Also, if jagged arrays are not required for a specific reason, you may want to consider multi-dimensional arrays instead?

Thanks.

[Stanfillirenfro]

Many thanks Jeronymite and Kate for your answers.

I can see the error messge because I have added the print function to the code. Only what I have from the output window is the error message above. Is there a way to see the exact point where the error occurs?

From what I know, the multidimesional array sets the length of the array already at the time it is declared. I am using the jagged array to control the lentgh myself.

@Kate, thanks for the link. I had this documentation already and as you sent it to me, I was reading it already, but I do not solve that problem yet.

I am using the print function as followed:

Print("myArray" + " : " + myArray[i][j] + " : " + Time[0]);

No amelioration until now.

Many thanks!

[jeronymite]

Stanfillirenfro I suspect the Print statement you have will not help much as it still references the actual array. May I suggest something like the following:

protected override void OnBarUpdate()
{
   if(CurrentBar < 500) return;
   Print("myArray.Length = " + myArray.Length + ", CurrentBar = " + CurrentBar);

   for(int i = 0; i < myArray.Length; i++)
   {
        for(int j = 0; j < 25; j++)
        {
            Print("i,j = " + i + "," + j);
            myArray[i] = new double[j];     // set size of jagged array elements
            myArray[i][j] = Close[j];            // initialize the arrays
        }
   }
}

Thanks.

[NinjaTrader_Kate]

Hello Stanfillirenfro,

Thank you for your reply.

As for your question regarding how you can see the exact point where the error occurs, this is where debugging using Visual Studio would come in handy. Here's a link to our help guide explaining how to set it up for debugging:

https://ninjatrader.com/support/helpGuides/nt8/visual_studio_debugging.htm

If you attach the debugger and then run the script, it should pop up showing exactly where in the code the error occurs.

Aside from that, I'd try jeronymite's suggestion above!

Please let us know if we may be of further assistance to you.

[Stanfillirenfro]

Hello @Kate, Hello jeronymite,

many thanks for your help and advices.

@Kate, I have failed to replicate the complete debugging process as specified in the link. The step 4 could not be completed although I have repeated several times. The procees took sometimes more than two hours and finally, I realized that the versions of Visual Studio I have downloaded (free download) were not compatible with Ninjatrader. I finally gave up.

Nevertheless, I could resolve the problem using Series<T>.

jeronymite, thanks gain for the tip on using the Print() function. This was new for me.

Many thanks again.