Bar to close at the bottom 30% of it's size

[Ludwik]

Hi,
Chris L told me to debug in a previous post so that's what I'm trying to do right now.
I'm trying to perform the above action but NT8 seem to mark all the bars all the chart instead of ones which mach the condition of closing either at the bottom 30% for shorts or top 30% for longs.
Not sure where the issue issue is:

 if ((High [1] - Close[1]) > (High[1] - Low[1]) * 0.3); // if the bar closes at bottom 30% of it's range then mark short
{
Values[0][1] = (Close[1] + 1 * TickSize); //Place indicator at Close +1
}

if ((High [1] - Close[1]) < (High[1] - Low[1]) * 0.3); // if the bar closes at top 30% of it's range then mark long
{
Values[0][0] = (Close[1] - 1 * TickSize); //Place indicator at Close -1
}

[NinjaTrader_ChelseaB]

Hello Ludwik,

There is a semi-colon after your if condition.

That would mean if the condition is true, do no operation.

The action block in the curly braces is not attached to your condition because of the semi-colon and will all run.

[NinjaTrader_ChrisL]

Hi Ludwik, thanks for the follow up.

Using Print() is invaluable for debugging and looking at the data and code flow of OnBarUpdate, use it like this:


if ((High[1] - Close[1]) > (High[1] - Low[1]) * 0.3); // if the bar closes at bottom 30% of it's range then mark short
{
Print("Condition True");
Print("High[1] - Close[1] " + High[1] - Close[1]);
Print("High[1] - Low[1]) * 0.3 " + High[1] - Low[1]) * 0.3);
Values[0][1] = (Close[1] + 1 * TickSize); //Place indicator at Close +1
}

You will find what is wrong by doing this.

And the Semi-colon as Chelsea mentioned.

Kind regards,
-ChrisL

[Ludwik]

Fixed it all. Thanks for advice