Indexing Error

[mlprice12]

My indicator is throwing an indexing error at the "Print - 1Time" line of code.
Checking the prints...the system believes it is 6pm and not the current time which I'm guessing is causing the index error. How can I work around this?

protected override void OnRender(ChartControl chartControl, ChartScale chartScale)
{
Print("0Time"+Time[0]);
for (int idx = ChartBars.FromIndex; idx <= ChartBars.ToIndex; idx++)
{
Print("1Time"+Time[0]);
if(mid.IsValidDataPointAt(idx))
{
Print("2Time"+Time[0]);
float x = chartControl.GetXByBarIndex(ChartBars, idx);
float y = chartScale.GetYByValue(mid.GetValueAt(idx));

mid is a t series calculated every bar

Thanks

[NinjaTrader_ChelseaB]

Hello mlprice12,

Using Time[0] in a non-data-driven method like OnRender() requires synchronizing the bars with TriggerCustomEvent().

https://ninjatrader.com/support/helpGuides/nt8/triggercustomevent.htm

You could instead use Bars.GetTime().

https://ninjatrader.com/support/helpGuides/nt8/gettime.htm

Further, your for loop attempts to become one greater than the ChartBars ToIndex.
idx <= ChartBars.ToIndex; idx++
You would need to increment only if its less than, not less than or greater to.
idx < ChartBars.ToIndex; idx++

[mlprice12]

Thanks for the feedback NinjaTrader_ChelseaB

I changed the for loop and am still getting the same error at the same line of code.

[mlprice12]

I tried running it in a new workspace without other indicators and still the same issue.
Weird part is it was working this morning until I changed a few different indictors' settings that are attached to the same chart.

I attached the code if you want to take a look deeper.

Thanks a lot

[NinjaTrader_ChelseaB]

Hello mlprice12,

Which line of code is causing an error?

Are you not seeing the print 0Time+Bars.GetTime(idx) appearing?
Does the Log tab of the Control Center show the error is in OnRender()?

I'm testing this on my end, and i'm seeing prints and no errors.

https://drive.google.com/file/d/1mEObEzoM5Ojpvc4jzJWL8DuKY9KpvRjD/view?usp=drivesdk

[mlprice12]

NinjaTrader_ChelseaB
Yes it is throwing OnRender and Time0 triggers but not Time1
which means this is the line

if(mid.IsValidDataPointAt(idx))

[NinjaTrader_ChelseaB]

Hello mlprice12,

Test that code by itself (comment out all of the other code in OnRender() other than the encapsulating loop).

Still able to reproduce the error?

What is the size of mid.Count?
What is the value of idx?

[mlprice12]

With all other onrender commented out I still receive the same error.
mid.Count = 74804
idx = 80918

error on bar 74803

[NinjaTrader_ChelseaB]

Hello mlprice12,

The idx 80918 is larger than the mid series has bars. You are asking for an index that does not exist.

Note that the ChartBars are synchronized with the primary series, not the series added with AddDataSeries.

I think you might want to get the indexes of the added series with mid.GetBar() and use the time of BarsArray[0].GetTime(idx).

[mlprice12]

NinjaTrader_ChelseaB
You are right. I thought they would have the same number of bars because both series are based on 10 ticks.

I'm a little confused on the solution though. Do I need to have 2 different for loops?

[NinjaTrader_ChelseaB]

Hello mlprice12,

So your BarsArray 0, the primary, has a different number of bars than BarsArray 1.

And you want the information of a bar from an added series that is closing at approximately the same time as a bar on the chart?

If so, get the time of that bar on the chart with .GetTime(). Then use that time for BarsArray[1].GetBar() to get a bar index from the added series (that approximately has the time of the bar on the chart).

Below are links to the help guide on GetBar and GetTime.

https://ninjatrader.com/support/helpGuides/nt8/getbar.htm

https://ninjatrader.com/support/helpGuides/nt8/gettime.htm

[mlprice12]

NinjaTrader_ChelseaB

Your assumptions are correct.

I believe this would work?

protected override void OnRender(ChartControl chartControl, ChartScale chartScale)
{
base.OnRender(chartControl, chartScale);
// loop through only the rendered bars on the chart
for(int barIndex = ChartBars.FromIndex; barIndex <= ChartBars.ToIndex; barIndex++)
{
// get the time stamp at the selected bar index value
DateTime timeValue = Bars.GetTime(barIndex);
for (int idx = 0; idx < BarsArray[1].GetBar(timeValue); idx++)

[mlprice12]

Or do I just replace idx with int barsAgo = CurrentBar - BarsArray[1].GetBar(timeValue);

[NinjaTrader_ChelseaB]

Hello mlprice12,

You have two loops which I am not understanding.

DateTime primaryBarTime = Bars.GetTime(barIndex);
int addedBarIndex = BarsArray[1].GetBar(primaryBarTime);
Print(BarsArray[1].GetTime(addedBarIndex));

Print these these values, is it getting the right bar?

[mlprice12]

@NinjaTrader_ChelseaB

Not sure if this changes anything but every bar is relevant. I'm rendering an ellipse on every bar.