Getting Last Swing Low Value

[itsthefriz]

Hi, I'm working on a strategy that uses swing values and the correct swing high value prints which was taken from https://ninjatrader.com/support/help...html?swing.htm however when converted to the swing low value it's different for just about every bar.

Swing high - swinghigh0 = High[Math.Max(0, Swing1.SwingHighBar(0,1,100))];
Swing Low - swinglow0 = Low[Math.Min(0, Swing1.SwingLowBar(0,1,100))];

You can see from the picture that the swing low value appears to be constantly changing and I'm not sure what's wrong as the swing high values match the chart.

[NinjaTrader_PaulH]

Hello itsthefriz,

Thanks for your post.

You need to change Math.Min to Math.Max in this line: Swing Low - swinglow0 = Low[Math.Min(0, Swing1.SwingLowBar(0,1,100))];

What is happening is that Math.Min is choosing the Minimum of 0 or the bars ago, or if no swing found it would return a -1. A -1 would lead to a bar index error.

Math.Max is used to return either 0 or the bars ago but would not let the -1 pass through and this would prevent an index error, so the correct usage here is:
Swing Low - swinglow0 = Low[Math.Max(0, Swing1.SwingLowBar(0,1,100))];

[itsthefriz]

Ah, okay, I think I've got it... Math.Min is constantly returning the 0 bar because it is minimum bar of the given index rather than the last swing value which is found using Math.Max which returns the number of bars ago the swing occurred, if that's right?

[NinjaTrader_PaulH]

Hello itsthefriz,

Thanks for your reply.

Correct, except that could return -1 because the swing indicator will return -1 if no swing is found and in that case, you would generate a bar index error and your script would stop.