NBarsUp and NBarsDown

[WalterSkinner]

I'm learning about these methods and I've been getting some incorrect values.

I'm trying to loop through a reasonable lookback (in this case 20) to print out the consecutive number of bars that have closed either up or down, but the values that are printing are incorrect.

What am I doing wrong?

for(int i = 2; i <= lookback; i++)
{
     double nBarsUpValue = NBarsUp(i, true, false, false)[0];
     double nBarsDownValue = NBarsDown(i, true, false, false)[0];

     if(nBarsUpValue == 1)
     {
          consecutiveUpBars = i;
     }
     if(nBarsDownValue == 1)
     {
          consecutiveDownBars = i;
     }
}

Edit:
It looks like the values that I'm printing may be correct and that the issue is in getting it to plot correctly so I'm attaching the whole code.

[WalterSkinner]

"Corrected" the assignment of Value[1] and Value [0].

You can see in the screenshot that the correct value is printed (red arrows).

There's something I'm just not seeing in the code. I'm also new to making histograms so I feel like this is just something simple that I'm just unaware of.

Edit:
After looking at the MACD code because it has a histo, I commented out line 94, because the MACD code doesn't use "Value[] = " for anything aside from Value[0]. I suppose this worked, but as far as why I have no idea.

[NinjaTrader_ChrisL]

Hi Walter, thanks for posting.

This does not look correct to me:

upRotations[0] = consecutiveUpBars;
downRotations[0] = consecutiveDownBars;

Value[0] = upRotations[0];
Value[1] = -downRotations[0];

this translates to:

upRotations[0] = consecutiveUpBars;
downRotations[0] = consecutiveDownBars;

upRotations[0] = upRotations[0];
upRotations[1] = -downRotations[0];

I commented out
Value[0] = upRotations[0];
Value[1] = -downRotations[0];[/CODE]

and the plots are correct this way.

Kind regards,
-ChrisL

[WalterSkinner]

Hi Walter, thanks for posting.

This does not look correct to me:

upRotations[0] = consecutiveUpBars;
downRotations[0] = consecutiveDownBars;

Value[0] = upRotations[0];
Value[1] = -downRotations[0];

this translates to:

upRotations[0] = consecutiveUpBars;
downRotations[0] = consecutiveDownBars;

upRotations[0] = upRotations[0];
upRotations[1] = -downRotations[0];

I commented out
Value[0] = upRotations[0];
Value[1] = -downRotations[0];[/CODE]

and the plots are correct this way.

Kind regards,
-ChrisL

Any idea why the colors are showing up the opposite to what I'm trying to paint them? Trying to get blue on up and red on down. 0804b.zip

[NinjaTrader_ChrisL]

Hi Walter, thanks for your reply.

The public propertys are switched around:

[Browsable(false)]
[XmlIgnore]
public Series<double> upRotations
{
get { return Values[1]; } //returns DownRotations, the second added plot.
}

[Browsable(false)]
[XmlIgnore]
public Series<double> downRotations //returns UpRotations, the first added plot
{
get { return Values[0]; }
}