Indicator from NT7 to NT8

[LadGta2018]

Hi, The code below is fine in NT7, but it is not good in NT8, how to fix it?
The code is:

#region Properties
[Browsable(false)] // this line prevents the data series from being displayed in the indicator properties dialog, do not remove
[XmlIgnore()] // this line ensures that the indicator can be saved/recovered as part of a chart template, do not remove
public DataSeries Top //line 271
{
get { return Values[0]; } //line 271
}
The error message is:

Line 271: Expected class, delegate, enum, interface, or stuct
Line 273: Identifier expected
Line 273: Type or namespacde definition, or end-of-file expected

[NinjaTrader_ChrisL]

Hello LadGta2018,

Thanks for the post.

You can define a public series property like so:

[Browsable(false)]
[XmlIgnore]
public Series<double> Plot1
{
	get { return Values[0]; }
}

The code-breaking changes page is a good place to find where code changes took place between NinjaTrader 7 and 8:

https://ninjatrader.com/support/helpGuides/nt8/en-us/?code_breaking_changes.htm

If we may be of any further assistance, please let us know.

[LadGta2018]

Thanks for your quick response. That is what I thought.

But the same error still there. Is there any wrong with my code?


AddPlot(new Stroke(Brushes.Red), PlotStyle.Dot, "Top");

#region Properties
[Browsable(false)] // this line prevents the data series from being displayed in the indicator properties dialog, do not remove
[XmlIgnore()] // this line ensures that the indicator can be saved/recovered as part of a chart template, do not remove
public Series<double> Top
{
get { return Values[0]; }
}

[NinjaTrader_ChrisL]

Hello LadGta2018,

Thanks for the reply.

Make sure you call AddPlot within State == State.SetDefaults.

Kindly see the attached example.

Please follow these directions to import the example:

https://ninjatrader.com/support/helpGuides/nt8/en-us/?import.htm

Please let me know if you have any additional questions.

[LadGta2018]

Thanks, I found the reason. When I copy and paste, there are a few "}" before these lines.

Thanks for the help.