continuous horizontal line at highest high of n periods

[rtwave]

good day to everyone,


i want to develop a very simple indicator that will look back at the last n periods (let's say 500), determine the highest high for the symbol we are evaluating over this time period and draw a continuous horizontal line at that value (the highest high of the last n periods).

i received some invaluable assistance from other users and this is how the code for this indicator looks like in nt7:

protected override void OnBarUpdate()
{

highs.Add(High[0]);                                
                
if(highs.Count > period)
double high = highs.Skip(highs.Count-period).Take(period).Max();            

DrawLine("highesthigh"+CurrentBar,false,1,high,0,high,Color.Silver,DashStyle.Solid,4); 

}

this code is quite complicated and has some advanced functions in it, ¿does anyone know how could i now adapt it to nt8?


thanks, regards.

[NinjaTrader_PaulH]

Hello rtwave,

Thanks for your post.

You can simplify the code as follows:

if (CurrentBar > 500) // Can only check once 500 bars processed
{
double high = MAX(High, 500)[0]; // Get Maximum High of the last 500 bars
Draw.Line(this, "highesthigh"+CurrentBar,false,1,high,0,high,Brush es.Silver,DashStyleHelper.Solid,4);
}

Another alternative would be to use the indicator CurrentDayOHL which will plot the current High (You can turn off the Open and Low if you wish), however it will reset at each session break.

[rtwave]

Paul,


thanks a lot.


the code you kindly provided works perfectly in nt8. in this case nt8's ninjascript commands are far easier and more intuitive than nt7's version.


thanks.

[NinjaTrader_PaulH]

Hello rtwave,

Thanks for your reply.

The same method, MAX() also exists in NT7 and would work equally as well. Please see attached NT7 example.

[rtwave]

good day to everyone,


i have looked further at this indicator and there's one small adjustment i would like to make. currently, the indicator is not calculated and plotted until the number of bars in the chart is greater than the period over the which we are doing this analysis.


i would prefer if the indicator was calculated and plotted from the first bar in the chart, initially working with as many bars as there are available and then after the number of bars is greater than the period we have determined, using only as many bars as have been set as an input.


to achieve this i tried to create some variables to hold the values of the current number of bars, the minimum between the current number of bars and the period we have used as an input and finally the highest high like before. however this code is not compiling, there are error messages about int, double and overload methods.

{
            double    currbarv    = CurrentBars[0];
            double    hhpere        = MIN(Hhperiod, currbarv)[0];
            double    hhighv        = MAX(High, hhpere)[0];
            Draw.Line(this, "highesthigh"+CurrentBar,false,1,hhighv,0,hhighv,Brushes.White,DashStyleHelper.Solid,4);

}

i think the logic should work and it is the syntax that would need some fine tuning. ¿does anyone know how these variables could be defined so that this code would work? thanks.

[NinjaTrader_PaulH]

Hello rtwave,

Thanks for your post.

The MIN and MAX method require an integer parameter for the second parameter (period).

An alternative to start with the first bar is:

double high = MAX(High, CurrentBar > 500 ? 500 : CurrentBar)[0];
Draw.Line(this, "highesthigh"+CurrentBar,false,1,high,0,high,Brush es.Silver,DashStyleHelper.Solid,4);

In the double high statement, the period for MAX is resolved through the use of a logic condition that states, if the CurrentBar is greater than 500 then use 500 for the period, otherwise use the CurrentBar number for the period.

[rtwave]

Paul,



thanks.


the structure you suggested works perfectly and now the indicator can generate visual signalling right from the start of a chart.

coding can be really elegant and effective when people know their stuff.

[rtwave]

regards to everyone,



i have noticed that some weeks ago i received a message from another user who wanted to share the code to this indicator.


i share it below in case it could be useful for other members:




Highesthighperiod = 500;

AddPlot(Brushes.White, "Highesthigh");
}
else if (State == State.Configure)
{
}
}

protected override void OnBarUpdate()
{


if (CurrentBar < 1) return;


{
double hhighv = MAX(High, CurrentBar > Highesthighperiod ? Highesthighperiod : CurrentBar)[0];
Draw.Line(this, "highesthigh"+CurrentBar,false,1,hhighv,0,hhighv,B rushes.DarkBlue,DashStyleHelper.Solid,4);
}

}

#region Properties
[NinjaScriptProperty]
[Range(0, int.MaxValue)]
[Display(Name="highesthighperiod", Description="highesthighperiod", Order=1, GroupName="Parameters")]
public int Highesthighperiod
{ get; set; }



[Browsable(false)]
[XmlIgnore]
public Series<double> Highesthigh
{
get { return Values[0]; }
}
#endregion

[NinjaTrader_Kate]

Hello rtwave,

Thank you for your reply.

If you'd like to share the full script, I'd invite you to export your indicator and upload it to our User App Share.

You can submit your script through the forum here:

https://ninjatrader.com/support/forum/forum/ninjascript-file-sharing/user-app-submission

Please let us know if we may be of further assistance to you.