Account Selector issue

[michaeldim]

Hi,

I don't know if this is a bug or something else but I am having difficulty in isolating positions so they are only displaying if the specific account is selected in ' accountSelector.SelectedAccount' field.

Take for example the AddOn Framework example. If i update the OnPositionUpdate method with the following code,

        // This method is fired as a position changes
        private void OnPositionUpdate(object sender, PositionEventArgs e)
        {
            try
            {
                Dispatcher.InvokeAsync(() =>
                {
                    if (e.Position.Instrument != Instrument)
                        return;

                    outputBox.Text = string.Format("Time: {1}{0}Selected Acc: {2}",
                        Environment.NewLine,
                        DateTime.Now,
                        accountSelector.SelectedAccount.Name);
                });
            }

            catch (Exception error)
            {
                Dispatcher.InvokeAsync(() =>
                {
                    // It is important to protect NinjaTrader from any unhandled exceptions that may arise from your code
                    outputBox.Text = "AddOnFramework - OnPositionUpdate Exception: " + error.ToString();
                });
            }
        }

When I compile and open the AddOn along with a SuperDOM both selected to Sim101, when I select another account on the AddOn and open a trade through the SuperDOM on the Sim101 account, the OnPositionUpdate still fires even though selected account is different.

Please can someone assist, thanks.

The video link explains hopefully what is happening.:http://recordit.co/vCKDFjQS5k

[NinjaTrader_JessicaP]

Hello michaeldim, and thank you for your report.

Since Add-Ons can have their own account selectors (see http://ninjatrader.com/support/helpG...ntselector.htm), the cost to this freedom is that they are not tied down to the SuperDOM's account selector.

To work around this limitation, and retrieve an open SuperDOM's selector, please review the content my colleague Jesse has put together at this forums post, and please let us know if there are any further questions we could answer.

http://ninjatrader.com/support/forum/showpost.php?p=472644&postcount=7

[michaeldim]

Jessica,

Thanks for your reply.

To be honest I was using SuperDOM as an example and my expectation being that whether the trade was opened from the DOM, Basic Entry, Order Ticket, etc that the AddOn would only subscribe to positions related to the account selected within it.

It certainly works when the AddOn is initially opened, however as soon as I change the account within the AddOn do other account positions leak through.

My understanding of the this snippet in the initialize method led to me to believe that we are only subscribe to events relevant to the selected account within the AddOn.

   accountSelector.SelectionChanged += (o, args) =>
            {
                if (accountSelector.SelectedAccount != null)
                {
                    // Unsubscribe to any prior account subscriptions
                    accountSelector.SelectedAccount.PositionUpdate -= OnPositionUpdate;

                    // Subscribe to new account subscriptions
                    accountSelector.SelectedAccount.PositionUpdate += OnPositionUpdate;
                }
            };
        }

Thanks

[NinjaTrader_Jesse]

Hello,

Thank you for the reply.

I believe what you are seeing is that the account is not being un-subscibed in this case.

For example if I have two accounts, and the first selected in the addon is Sim101. I can places trades on Sim101 and see those trades. Now if I select Sim102 in the addon, I can still place trades on SIm101 and see the subscription. Is this the same as what you are experiencing?

I will need to research this further to see if any change is needed to the unsubscription syntax or if this is something happening internally. When I have more details I will reply back here.

I look forward to being of further assistance.

[michaeldim]

Jesse, yes this is what I'm experiencing, the account is not unsubscribing when it is changed. Thanks.

[NinjaTrader_Jesse]

Hello,

I wanted to reply back on this item.

It appears there is actually no problem here, the sample just does not contain the additional logic needed for actually un subscribing. I have suggested that we update the help guide samples to also include the changes in the attached script.

The existing unsubscription is simply making sure that there are not duplicate handlers for the same event, but does not reference the previous account object. You would need to store the selected account as a variable, and if the account changes to some other account than what is stored, remove the handler from the stored variable and reset it.

I look forward to being of further assistance.