Ninja Script compile error

[mtamaku]

Hello: I have this line of code in my script and getting below compile error. Please advise what is needed to fix this error. Thanks.

// Calculate daily PnL
dailyPnL += Position.GetProfitLoss(Close[0], PerformanceUnit.Currency);

// my logic here to go long
{
EnterLongLimit(Close[0] + (TickSize * 2), "Long", takeProfit, stopLoss);
}
// my logic to go short
{
EnterShortLimit(Close[0] - (TickSize * 2), "Short", takeProfit, stopLoss);

================================================== ===============================
here are the compile error.

[NinjaTrader_Gaby]

Hello mtamaku,

Thank you for your post.

GetProfitLoss() is not a valid NinjaScript method in NinjaTrader 8. Instead, use GetUnrealizedProfitLoss().

https://ninjatrader.com/support/helpguides/nt8/position_getunrealizedprofitloss.htm

Your EnterLongLimit and EnterShortLimit calls are not using the correct syntax. I suggest reviewing the Help Guide pages for the correct syntax.

https://ninjatrader.com/support/helpGuides/nt8/enterlonglimit.htm

https://ninjatrader.com/support/helpGuides/nt8/entershortlimit.htm

Please let us know if you have any further questions.

[mtamaku]

Thank you. This helped and I fixed the error and have a clean compile of my strategy.

But I do not see this strategy in the list when I tried to apply this strategy from the chart trader or from the strategy tab in main window using right click and clicking on strategy menu option.

Please advise how to add this strategy to a chart.

[NinjaTrader_Gaby]

If your strategies are not showing up in the list of available strategies then that suggests there is an issue with the strategies themselves. Specifically, there is likely an error in OnStateChange().

Keep in mind that while it may compile successfully, the compiler cannot check "run time" logic errors, which can only occur when you run (or load) the strategy.

A good first step here is to check the "Log" tab of the Ninjatrader Control center and look for any errors related to the strategies as if there is a run time error is would show in the log tab.

If there are no log errors, check (in the Ninjascript editor open each strategy) to see if the strategies have the same name (IE you made a copy of the strategy and made your changes but unintentionally left the name the same as an existing one).

In general, you want the filename of the strategy (this is what Ninjascript editor uses to open the script) to be the same as the public class name and most importantly that inside OnStateChange and within State.SetDefaults, the Name = field (This is what the drop-down or strategy selector uses) shows the same name as the public class name.

[mtamaku]

Hi, here was Addseries statement in onstatechange(_) section was the root cause which I found in log when I try to add the strategy.
After removing , I am able to see my new strategy and I can select it.
Thanks for help.