i cant figure out timespan

[tkaboris]

thank you for your patience...
Its compaining in strategy.

[NinjaTrader_ChelseaB]

Hello tkaboris,

Apologies, that was copied and pasted from post # 28.

fvgIndicator.FVGList[index].lowerPrice

[tkaboris]

Thank you it works now.
how can i find previous lowerPrice?
if i print this, it gives out onbarupdate error its out of range
Print(string.Format("index: {0}: fvg.start gap time previous[{0}]: {1}", index, fvgIndicator.FVGList[1].lowerPrice));

[NinjaTrader_ChelseaB]

Hello tkaboris,

This not a plot series. This is a List<> object.

You can loop through the list.

If the Count is greater than 2 you can use fvgIndicator.FVGList.Count() - 2 as the index of the second to last element.

[tkaboris]

thank you
I think i am doing it wrong trying to access previous lowerPrice

for (int index = 0; index < fvgIndicator.FVGList.Count(); index++)
            {
//            Print(string.Format("index: {0}: fvg.start gap time previous[{0}]: {1}", index, fvgIndicator.FVGList[1].gapStartTime));
            Print(string.Format("index: {0}: fvg.start gap time[{0}]: {1}", index, fvgIndicator.FVGList[index].gapStartTime));
            Print(string.Format("index: {0}: fvg.type[{0}]: {1}", index, fvgIndicator.FVGList[index].type));
            Print(string.Format("index: {0}: fvg.lowerPrice[{0}]: {1}", index, fvgIndicator.FVGList[index].lowerPrice));
            Print(string.Format("index: {0}: fvg.upperPrice[{0}]: {1}", index, fvgIndicator.FVGList[index].upperPrice));
            Print(string.Format("index: {0}: fvg.filled[{0}]: {1}", index, fvgIndicator.FVGList[index].filled));
            Print(string.Format("index: {0}: fvg.fill time[{0}]: {1}", index, fvgIndicator.FVGList[index].fillTime));
            Print(string.Format("index: {0}: fvg.tag[{0}]: {1}", index, fvgIndicator.FVGList[index].tag));

                if (fvgIndicator.FVGList.Count >= 2)
                {
                    Print("Previous");
                    Print(string.Format("index: {0}: fvg.lowerPrice[{0}]: {1}", index, fvgIndicator.FVGList[1].lowerPrice));
                }
            }​

[NinjaTrader_ChelseaB]

Hello tkaboris,

An index of [1] would be the second added FVG object to the list. (I'm not sure that would be the previous lowerPrice value. The author would know how this script's logic is designed)

An index of [fvgIndicator.FVGList.Count() - 2] would be the second to last object added to the list.

if (fvgIndicator.FVGList.Count() > 1)
Print(fvgIndicator.FVGList[fvgIndicator.FVGList.Count() - 2].lowerPrice);

This would be the index if you were trying to use it outside of a loop as you were trying to do in post # 31.

[tkaboris]

Thank you.
When i print
Print(string.Format("index: {0}: fvg.type[{0}]: {1}", index, fvgIndicator.FVGList[index].type));

it prints type R for resistnace or S for support

index: 13: fvg.type[13]: R

I need to evaluate if recent levels is of type R or S, but it gives error. I tried differnt ways but still cant get it to evaluate correctly
if ((fvgIndicator.FVGList[index].type = "R")
&& High[1] > fvgIndicator.FVGList[index].lowerPrice
)
{
EnterShort(1, "Short");
}

From indicaotor S R are enums
public enum FVGType
{
S, R
}
public FVGType type;
Can you please help?

[Leeroy_Jenkins]

if (fvgIndicator.FVGList[index].type == FVGType.R && High[1] > fvgIndicator.FVGList[index].lowerPrice)
{

}

[tkaboris]

Thank you when i implement that it throws an error. its not seeing FVGType
FVGType does not exist in current context.

[Leeroy_Jenkins]

You need to write full path where FVGType located. Open file where FVGType is defined and hover you mouse over it's name. You will see full namespace path. Something like "Ninjatrader.Indicators.....". Add this path before your FVGType.R and add dot. Like this "Ninjatrader.Indicators.SomeIndicator.FVGType. R".

[Leeroy_Jenkins]

Or just add that namespace at start of your code with "using" word.

[tkaboris]

Thank you again.

Can you also help me to access opposite upperPrice level, so i can create a condition to avoid if levels from S and R are too close.
Currently Print("opposite upper"); is not reached when entered short

for (int index = 0; index < fvgIndicator.FVGList.Count(); index++)
            {
                Print("================================");
//            Print(string.Format("index: {0}: fvg.start gap time previous[{0}]: {1}", index, fvgIndicator.FVGList[1].gapStartTime));
            Print(string.Format("index: {0}: fvg.start gap time[{0}]: {1}", index, fvgIndicator.FVGList[index].gapStartTime));
            Print(string.Format("index: {0}: fvg.type[{0}]: {1}", index, fvgIndicator.FVGList[index].type));

            Print(string.Format("index: {0}: fvg.lowerPrice[{0}]: {1}", index, fvgIndicator.FVGList[index].lowerPrice));
            Print(string.Format("index: {0}: fvg.upperPrice[{0}]: {1}", index, fvgIndicator.FVGList[index].upperPrice));
            Print(string.Format("index: {0}: fvg.filled[{0}]: {1}", index, fvgIndicator.FVGList[index].filled));
            Print(string.Format("index: {0}: fvg.fill time[{0}]: {1}", index, fvgIndicator.FVGList[index].fillTime));
            Print(string.Format("index: {0}: fvg.tag[{0}]: {1}", index, fvgIndicator.FVGList[index].tag));
            Print("================================");

            if (fvgIndicator.FVGList[index].type == NinjaTrader.NinjaScript.Indicators.FVGICT.FVGType.R
                && High[0] > fvgIndicator.FVGList[index].lowerPrice && Close[0] < Open[0])



            {
                EnterShort(1, "Short");
                Print("Entering Short");
                if (fvgIndicator.FVGList.Count() > 2 && fvgIndicator.FVGList[index].type == NinjaTrader.NinjaScript.Indicators.FVGICT.FVGType.S)
                    {
                        Print("opposite upper");
                        Print(fvgIndicator.FVGList[fvgIndicator.FVGList.Count() - 2].upperPrice);                
                    }
            }
            }​

Output: example

================================
index: 14: fvg.start gap time[14]: 8/30/2023 7:48:00 AM
index: 14: fvg.type[14]: S
index: 14: fvg.lowerPrice[14]: 15394.25
index: 14: fvg.upperPrice[14]: 15397
index: 14: fvg.filled[14]: False
index: 14: fvg.fill time[14]: 1/1/0001 12:00:00 AM
index: 14: fvg.tag[14]: FVGUP_c2410df2-b611-491e-925e-302585d7da4d_4966
================================

[Leeroy_Jenkins]

>Currently Print("opposite upper"); is not reached when entered short

Because you put "if" inside other "if". First one requires type == FVGType.R but second one requires type == FVGICT.FVGType.S with the same index. It's not possible.

You probably need to segregate S from R because you can't do that in single loop. But I'm not sure.

[tkaboris]

right i think we first need to loop through FVGList to find upperprice but maybe there could ne a nested loop to loop through List to find last type S..

@NinjaTrader_ChelseaB

[NinjaTrader_ChelseaB]

Hello tkaboris,

It is possible to put a loop in another loop if you want this custom logic.

Below is a link to a 3rd party educational site on nested loops.

https://www.tutorialspoint.com/csharp/csharp_nested_loops.htm

"Currently Print("opposite upper"); is not reached when entered short"

This would mean one of the conditions is not evaluating as true.

Print the values in the conditions with labels for the values and labels for the comparison operators so we can see how these are being compared.