The FindResource("LongBackground") and FindResource("ShortBackground") display to the 1st row in addition to the correct row.
Expected result:
The 1st row should not display the LongBackground or ShortBackground (only the row with the 3 value should display it).
Can you reproduce the bug on your end?
What fix do you suggest? thanks
The script:
//
// Copyright (C) 2023, NinjaTrader LLC <www.ninjatrader.com>.
// NinjaTrader reserves the right to modify or overwrite this NinjaScript component with each release.
//
region Using declarations
using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.ComponentModel.DataAnnotations;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows;
using System.Windows.Input;
using System.Windows.Media;
using System.Xml.Serialization;
using NinjaTrader.Cbi;
using NinjaTrader.Gui;
using NinjaTrader.Gui.Chart;
using NinjaTrader.Gui.SuperDom;
using NinjaTrader.Data;
using NinjaTrader.NinjaScript;
using NinjaTrader.Core.FloatingPoint;
#endregion
//This namespace holds Market Analyzer columns in this folder and is required. Do not change it.
namespace NinjaTrader.NinjaScript.MarketAnalyzerColumns
{
public class UnrealizedProfitLossInTicks : MarketAnalyzerColumn
{
private Cbi.Position position; // holds the position for the actual instrument
protected override void OnStateChange()
{
if (State == State.SetDefaults)
{
AccountName = DefaultAccountName;
Description = NinjaTrader.Custom.Resource.NinjaScriptMarketAnaly zerColumnDescriptionUnrealizedProfitLoss;
Name = "UnrealizedProfitLossInTicks";
IsDataSeriesRequired = false;
ShowInTotalRow = true;
FormatDecimals = 0;
}
}
protected override void OnConnectionStatusUpdate(Cbi.ConnectionStatusEvent Args connectionStatusUpdate)
{
BackColor = null; // reset color
if (connectionStatusUpdate.Status == Cbi.ConnectionStatus.Connected && connectionStatusUpdate.PreviousStatus == Cbi.ConnectionStatus.Connecting)
{
Cbi.Account account = null;
lock (connectionStatusUpdate.Connection.Accounts)
account = connectionStatusUpdate.Connection.Accounts.FirstOr Default(o => o.DisplayName == AccountName);
if (account != null)
{
lock (account.Positions)
position = account.Positions.FirstOrDefault(o => o.Instrument.FullName == Instrument.FullName);
}
}
else if (connectionStatusUpdate.Status == Cbi.ConnectionStatus.Disconnected && connectionStatusUpdate.PreviousStatus == Cbi.ConnectionStatus.Disconnecting)
{
if (position != null && position.Account.Connection == connectionStatusUpdate.Connection)
{
CurrentValue = 0;
position = null;
}
}
}
protected override void OnMarketData(Data.MarketDataEventArgs marketDataUpdate)
{
CurrentValue = (position == null ? 0 : position.GetUnrealizedProfitLoss(Cbi.PerformanceUn it.Ticks));
}
protected override void OnPositionUpdate(Cbi.PositionEventArgs positionUpdate)
{
if (positionUpdate.Position.Account.DisplayName == AccountName && positionUpdate.Position.Instrument == Instrument)
{
position = (positionUpdate.Operation == Cbi.Operation.Remove ? null : positionUpdate.Position);
CurrentValue = (position == null ? 0 : position.GetUnrealizedProfitLoss(Cbi.PerformanceUn it.Ticks));
}
}
region Properties
[NinjaScriptProperty]
[TypeConverter(typeof(AccountDisplayNameConverter))]
[Display(ResourceType = typeof(Resource), Name = "NinjaScriptColumnBaseAccount", GroupName = "NinjaScriptSetup", Order = 0)]
public string AccountName
{ get; set; }
#endregion
region Miscellaneous
public override string Format(double value)
{
if (CellConditions.Count == 0)
BackColor = value == 0 ? null : value > 0 ? Application.Current.FindResource("LongBackground") as Brush : Application.Current.FindResource("ShortBackground" ) as Brush;
return (value == 0 ? string.Empty : Core.Globals.FormatQuantity((long) value, false));
}
#endregion
}
}
Expected result:
The 1st row should not display the LongBackground or ShortBackground (only the row with the 3 value should display it).
Can you reproduce the bug on your end?
What fix do you suggest? thanks
The script:
//
// Copyright (C) 2023, NinjaTrader LLC <www.ninjatrader.com>.
// NinjaTrader reserves the right to modify or overwrite this NinjaScript component with each release.
//
region Using declarations
using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.ComponentModel.DataAnnotations;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows;
using System.Windows.Input;
using System.Windows.Media;
using System.Xml.Serialization;
using NinjaTrader.Cbi;
using NinjaTrader.Gui;
using NinjaTrader.Gui.Chart;
using NinjaTrader.Gui.SuperDom;
using NinjaTrader.Data;
using NinjaTrader.NinjaScript;
using NinjaTrader.Core.FloatingPoint;
#endregion
//This namespace holds Market Analyzer columns in this folder and is required. Do not change it.
namespace NinjaTrader.NinjaScript.MarketAnalyzerColumns
{
public class UnrealizedProfitLossInTicks : MarketAnalyzerColumn
{
private Cbi.Position position; // holds the position for the actual instrument
protected override void OnStateChange()
{
if (State == State.SetDefaults)
{
AccountName = DefaultAccountName;
Description = NinjaTrader.Custom.Resource.NinjaScriptMarketAnaly zerColumnDescriptionUnrealizedProfitLoss;
Name = "UnrealizedProfitLossInTicks";
IsDataSeriesRequired = false;
ShowInTotalRow = true;
FormatDecimals = 0;
}
}
protected override void OnConnectionStatusUpdate(Cbi.ConnectionStatusEvent Args connectionStatusUpdate)
{
BackColor = null; // reset color
if (connectionStatusUpdate.Status == Cbi.ConnectionStatus.Connected && connectionStatusUpdate.PreviousStatus == Cbi.ConnectionStatus.Connecting)
{
Cbi.Account account = null;
lock (connectionStatusUpdate.Connection.Accounts)
account = connectionStatusUpdate.Connection.Accounts.FirstOr Default(o => o.DisplayName == AccountName);
if (account != null)
{
lock (account.Positions)
position = account.Positions.FirstOrDefault(o => o.Instrument.FullName == Instrument.FullName);
}
}
else if (connectionStatusUpdate.Status == Cbi.ConnectionStatus.Disconnected && connectionStatusUpdate.PreviousStatus == Cbi.ConnectionStatus.Disconnecting)
{
if (position != null && position.Account.Connection == connectionStatusUpdate.Connection)
{
CurrentValue = 0;
position = null;
}
}
}
protected override void OnMarketData(Data.MarketDataEventArgs marketDataUpdate)
{
CurrentValue = (position == null ? 0 : position.GetUnrealizedProfitLoss(Cbi.PerformanceUn it.Ticks));
}
protected override void OnPositionUpdate(Cbi.PositionEventArgs positionUpdate)
{
if (positionUpdate.Position.Account.DisplayName == AccountName && positionUpdate.Position.Instrument == Instrument)
{
position = (positionUpdate.Operation == Cbi.Operation.Remove ? null : positionUpdate.Position);
CurrentValue = (position == null ? 0 : position.GetUnrealizedProfitLoss(Cbi.PerformanceUn it.Ticks));
}
}
region Properties
[NinjaScriptProperty]
[TypeConverter(typeof(AccountDisplayNameConverter))]
[Display(ResourceType = typeof(Resource), Name = "NinjaScriptColumnBaseAccount", GroupName = "NinjaScriptSetup", Order = 0)]
public string AccountName
{ get; set; }
#endregion
region Miscellaneous
public override string Format(double value)
{
if (CellConditions.Count == 0)
BackColor = value == 0 ? null : value > 0 ? Application.Current.FindResource("LongBackground") as Brush : Application.Current.FindResource("ShortBackground" ) as Brush;
return (value == 0 ? string.Empty : Core.Globals.FormatQuantity((long) value, false));
}
#endregion
}
}
Comment